Fixed extension tests

Author: darrelmiller

src/Microsoft.OpenApi/Services/OpenApiVisitorBase.cs

@@ -19,7 +19,7 @@ public abstract class OpenApiVisitorBase
         /// <summary>
         /// Allow Rule to indicate validation error occured a deeper context level.  
         /// </summary>
-        /// <param name="segment"></param>
+        /// <param name="segment">Identifier for context</param>
         public void Enter(string segment)
         {
             this._path.Push(segment);

src/Microsoft.OpenApi/Validations/IValidationContext.cs

@@ -23,7 +23,7 @@ public interface IValidationContext
         /// <summary>
         /// Allow Rule to indicate validation error occured a deeper context level.  
         /// </summary>
-        /// <param name="segment"></param>
+        /// <param name="segment">Identifier for context</param>
         void Enter(string segment);
 
         /// <summary>

test/Microsoft.OpenApi.Readers.Tests/TestCustomExtension.cs

@@ -28,27 +28,15 @@ public void ParseCustomExtension()
         baz: hi!
 paths: {}
 ";
-            var ruleset = Validations.ValidationRuleSet.DefaultRuleSet;
-            ruleset.Add(
-             new ValidationRule<FooExtension>(
-                 (context, item) =>
-                 {
-                     if (item.Bar == "hey")
-                     {
-                         context.AddError(new ValidationError(ErrorReason.Format, context.PathString, "Don't say hey"));
-                     }
-                 }));
-
-                     var settings = new OpenApiReaderSettings()
+            var settings = new OpenApiReaderSettings()
             {
                 ExtensionParsers = { { "x-foo", (a) => {
                         var fooNode = (OpenApiObject)a;
                         return new FooExtension() {
                               Bar = (fooNode["bar"] as OpenApiString)?.Value,
                               Baz = (fooNode["baz"] as OpenApiString)?.Value
                         };
-                } } },
-                RuleSet = ruleset
+                } } }
             };
 
             var reader = new OpenApiStringReader(settings);
@@ -61,9 +49,6 @@ public void ParseCustomExtension()
             fooExtension.Should().NotBeNull();
             fooExtension.Bar.Should().Be("hey");
             fooExtension.Baz.Should().Be("hi!");
-            var error = diag.Errors.First();
-            error.Message.Should().Be("Don't say hey");
-            error.Pointer.Should().Be("#/info/x-foo");
         }
     }
 

test/Microsoft.OpenApi.Tests/Services/OpenApiValidatorTests.cs

@@ -5,10 +5,12 @@
 using System.Collections.Generic;
 using FluentAssertions;
 using Microsoft.OpenApi.Exceptions;
+using Microsoft.OpenApi.Interfaces;
 using Microsoft.OpenApi.Models;
 using Microsoft.OpenApi.Properties;
 using Microsoft.OpenApi.Services;
 using Microsoft.OpenApi.Validations;
+using Microsoft.OpenApi.Writers;
 using Xunit;
 
 namespace Microsoft.OpenApi.Tests.Services
@@ -85,5 +87,63 @@ public void ServersShouldBeReferencedByIndex()
         });
         }
 
+
+        [Fact]
+        public void ValidateCustomExtension()
+        {
+
+            var ruleset = Validations.ValidationRuleSet.DefaultRuleSet;
+            ruleset.Add(
+             new ValidationRule<FooExtension>(
+                 (context, item) =>
+                 {
+                     if (item.Bar == "hey")
+                     {
+                         context.AddError(new ValidationError(ErrorReason.Format, context.PathString, "Don't say hey"));
+                     }
+                 }));
+
+
+            var openApiDocument = new OpenApiDocument();
+            openApiDocument.Info = new OpenApiInfo()
+            {
+                Title = "foo",
+                Version = "1.2.2"
+            };
+
+            var fooExtension = new FooExtension()
+            {
+                Bar = "hey",
+                Baz = "baz"
+            };
+
+            openApiDocument.Info.Extensions.Add("x-foo",fooExtension);
+
+            var validator = new OpenApiValidator(ruleset);
+            var walker = new OpenApiWalker(validator);
+            walker.Walk(openApiDocument);
+
+            validator.Errors.ShouldBeEquivalentTo(
+                   new List<ValidationError>
+                   {
+                       new ValidationError(ErrorReason.Format, "#/info/x-foo", "Don't say hey")
+                   });
+        }
+
+    }
+
+    public class FooExtension : IOpenApiExtension, IOpenApiElement
+    {
+        public string Baz { get; set; }
+
+        public string Bar { get; set; }
+
+        public void Write(IOpenApiWriter writer)
+        {
+            writer.WriteStartObject();
+            writer.WriteProperty("baz", Baz);
+            writer.WriteProperty("bar", Bar);
+            writer.WriteEndObject();
+        }
     }
 }