Skip to content

Commit b1578f3

Browse files
committed
fix: parameter reference annoation parsing
Signed-off-by: Vincent Biret <[email protected]>
1 parent 2a62c5a commit b1578f3

File tree

2 files changed

+43
-1
lines changed

2 files changed

+43
-1
lines changed

src/Microsoft.OpenApi/Reader/V31/OpenApiParameterDeserializer.cs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,9 @@ public static IOpenApiParameter LoadParameter(ParseNode node, OpenApiDocument ho
161161
if (pointer != null)
162162
{
163163
var reference = GetReferenceIdAndExternalResource(pointer);
164-
return new OpenApiParameterReference(reference.Item1, hostDocument, reference.Item2);
164+
var parameterReference = new OpenApiParameterReference(reference.Item1, hostDocument, reference.Item2);
165+
parameterReference.Reference.SetMetadataFromMapNode(mapNode);
166+
return parameterReference;
165167
}
166168

167169
var parameter = new OpenApiParameter();
Lines changed: 40 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,40 @@
1+
using System.Text.Json.Nodes;
2+
using Microsoft.OpenApi.Reader;
3+
using Microsoft.OpenApi.Reader.V31;
4+
using Xunit;
5+
6+
namespace Microsoft.OpenApi.Readers.Tests.V31Tests;
7+
8+
public class OpenApiParameterReferenceDeserializerTests
9+
{
10+
[Fact]
11+
public void ShouldDeserializeParameterReferenceAnnotations()
12+
{
13+
var json =
14+
"""
15+
{
16+
"$ref": "#/components/parameters/MyParameter",
17+
"description": "This is a parameter reference"
18+
}
19+
""";
20+
21+
var hostDocument = new OpenApiDocument();
22+
hostDocument.AddComponent("MyParameter", new OpenApiParameter
23+
{
24+
Name = "myParam",
25+
In = ParameterLocation.Query,
26+
Description = "This is a parameter description",
27+
});
28+
var jsonNode = JsonNode.Parse(json);
29+
var parseNode = ParseNode.Create(new ParsingContext(new()), jsonNode);
30+
31+
var result = OpenApiV31Deserializer.LoadParameter(parseNode, hostDocument);
32+
33+
Assert.NotNull(result);
34+
var resultReference = Assert.IsType<OpenApiParameterReference>(result);
35+
36+
Assert.Equal("MyParameter", resultReference.Reference.Id);
37+
Assert.Equal("This is a parameter reference", resultReference.Description);
38+
Assert.NotNull(resultReference.Target);
39+
}
40+
}

0 commit comments

Comments
 (0)