Change debug.assert to throw arugment null and use the resource from the product codes

Author: xuzhg

src/Microsoft.OpenApi/Properties/SRResource.Designer.cs

@@ -129,6 +129,9 @@
   <data name="IndentationLevelInvalid" xml:space="preserve">
     <value>Indentation level cannot be lower than 0.</value>
   </data>
+  <data name="InputItemShouldBeType" xml:space="preserve">
+    <value>The input item should be in type of '{0}'.</value>
+  </data>
   <data name="ObjectScopeNeededForPropertyNameWriting" xml:space="preserve">
     <value>The active scope must be an object scope for property name '{0}' to be written.</value>
   </data>

src/Microsoft.OpenApi/Properties/SRResource.resx

@@ -24,7 +24,7 @@ public static class OpenApiTagRules
                     if (String.IsNullOrEmpty(tag.Name))
                     {
                         ValidationError error = new ValidationError(ErrorReason.Required, context.PathString,
-                            String.Format(SRResource.Validation_FieldIsRequired, "name", "Tag"));
+                            String.Format(SRResource.Validation_FieldIsRequired, "name", "tag"));
                         context.AddError(error);
                     }
                     context.Pop();

src/Microsoft.OpenApi/Validations/Rules/OpenApiTagRules.cs

@@ -2,8 +2,8 @@
 // Licensed under the MIT license. 
 
 using System;
-using System.Diagnostics;
 using Microsoft.OpenApi.Interfaces;
+using Microsoft.OpenApi.Properties;
 
 namespace Microsoft.OpenApi.Validations
 {
@@ -49,7 +49,21 @@ internal override Type ElementType
 
         internal override void Evaluate(ValidationContext context, object item)
         {
-            Debug.Assert(item is T, "item should be " + typeof(T));
+            if (context == null)
+            {
+                throw Error.ArgumentNull(nameof(context));
+            }
+
+            if (item == null)
+            {
+                return;
+            }
+
+            if (!(item is T))
+            {
+                throw Error.Argument(string.Format(SRResource.InputItemShouldBeType, typeof(T).FullName));
+            }
+
             T typedItem = (T)item;
             this._validate(context, typedItem);
         }

src/Microsoft.OpenApi/Validations/ValidationRule.cs

@@ -1,7 +1,6 @@
 // Copyright (c) Microsoft Corporation. All rights reserved.
 // Licensed under the MIT license. 
 
-using System.Diagnostics;
 using Microsoft.OpenApi.Models;
 
 namespace Microsoft.OpenApi.Validations.Visitors
@@ -18,8 +17,15 @@ internal class CallbackVisitor : VisitorBase<OpenApiCallback>
         /// <param name="callback">The <see cref="OpenApiCallback"/>.</param>
         protected override void Next(ValidationContext context, OpenApiCallback callback)
         {
-            Debug.Assert(context != null);
-            Debug.Assert(callback != null);
+            if (context == null)
+            {
+                throw Error.ArgumentNull(nameof(context));
+            }
+
+            if (callback == null)
+            {
+                throw Error.ArgumentNull(nameof(callback));
+            }
 
             foreach (var pathItem in callback.PathItems)
             {

src/Microsoft.OpenApi/Validations/Visitors/CallbackVisitor.cs

@@ -1,7 +1,6 @@
 // Copyright (c) Microsoft Corporation. All rights reserved.
 // Licensed under the MIT license. 
 
-using System.Diagnostics;
 using Microsoft.OpenApi.Models;
 
 namespace Microsoft.OpenApi.Validations.Visitors
@@ -18,18 +17,34 @@ internal class ComponentsVisitor : VisitorBase<OpenApiComponents>
         /// <param name="components">The <see cref="OpenApiComponents"/>.</param>
         protected override void Next(ValidationContext context, OpenApiComponents components)
         {
-            Debug.Assert(context != null);
-            Debug.Assert(components != null);
+            if (context == null)
+            {
+                throw Error.ArgumentNull(nameof(context));
+            }
+
+            if (components == null)
+            {
+                throw Error.ArgumentNull(nameof(components));
+            }
 
             context.ValidateMap(components.Schemas);
+
             context.ValidateMap(components.Responses);
+
             context.ValidateMap(components.Parameters);
+
             context.ValidateMap(components.Examples);
+
             context.ValidateMap(components.RequestBodies);
+
             context.ValidateMap(components.Headers);
+
             context.ValidateMap(components.SecuritySchemes);
+
             context.ValidateMap(components.Links);
+
             context.ValidateMap(components.Callbacks);
+
             base.Next(context, components);
         }
     }

src/Microsoft.OpenApi/Validations/Visitors/ComponentsVisitor.cs

@@ -17,16 +17,31 @@ internal class DocumentVisitor : VisitorBase<OpenApiDocument>
         /// <param name="document">The <see cref="OpenApiDocument"/>.</param>
         protected override void Next(ValidationContext context, OpenApiDocument document)
         {
+            if (context == null)
+            {
+                throw Error.ArgumentNull(nameof(context));
+            }
+
             if (document == null)
             {
-                return;
+                throw Error.ArgumentNull(nameof(document));
             }
 
             context.Validate(document.Info);
 
+            context.ValidateCollection(document.Servers);
+
+            context.Validate(document.Paths);
+
+            context.Validate(document.Components);
+
+            context.ValidateCollection(document.SecurityRequirements);
+
             context.ValidateCollection(document.Tags);
 
-            // add more.
+            context.Validate(document.ExternalDocs);
+
+            base.Next(context, document);
         }
     }
 }

src/Microsoft.OpenApi/Validations/Visitors/DocumentVisitor.cs

@@ -1,7 +1,6 @@
 // Copyright (c) Microsoft Corporation. All rights reserved.
 // Licensed under the MIT license. 
 
-using System.Diagnostics;
 using Microsoft.OpenApi.Models;
 
 namespace Microsoft.OpenApi.Validations.Visitors
@@ -18,8 +17,15 @@ internal class EncodingVisitor : VisitorBase<OpenApiEncoding>
         /// <param name="encoding">The <see cref="OpenApiEncoding"/>.</param>
         protected override void Next(ValidationContext context, OpenApiEncoding encoding)
         {
-            Debug.Assert(context != null);
-            Debug.Assert(encoding != null);
+            if (context == null)
+            {
+                throw Error.ArgumentNull(nameof(context));
+            }
+
+            if (encoding == null)
+            {
+                throw Error.ArgumentNull(nameof(encoding));
+            }
 
             context.ValidateMap(encoding.Headers);
 

src/Microsoft.OpenApi/Validations/Visitors/EncodingVisitor.cs

@@ -1,7 +1,6 @@
 // Copyright (c) Microsoft Corporation. All rights reserved.
 // Licensed under the MIT license. 
 
-using System.Diagnostics;
 using Microsoft.OpenApi.Models;
 
 namespace Microsoft.OpenApi.Validations.Visitors
@@ -18,8 +17,15 @@ internal class HeaderVisitor : VisitorBase<OpenApiHeader>
         /// <param name="header">The <see cref="OpenApiHeader"/>.</param>
         protected override void Next(ValidationContext context, OpenApiHeader header)
         {
-            Debug.Assert(context != null);
-            Debug.Assert(header != null);
+            if (context == null)
+            {
+                throw Error.ArgumentNull(nameof(context));
+            }
+
+            if (header == null)
+            {
+                throw Error.ArgumentNull(nameof(header));
+            }
 
             context.Validate(header.Schema);
 

src/Microsoft.OpenApi/Validations/Visitors/HeaderVisitor.cs

@@ -1,7 +1,6 @@
 // Copyright (c) Microsoft Corporation. All rights reserved.
 // Licensed under the MIT license. 
 
-using System.Diagnostics;
 using Microsoft.OpenApi.Models;
 
 namespace Microsoft.OpenApi.Validations.Visitors
@@ -18,8 +17,15 @@ internal class InfoVisitor : VisitorBase<OpenApiInfo>
         /// <param name="info">The <see cref="OpenApiInfo"/>.</param>
         protected override void Next(ValidationContext context, OpenApiInfo info)
         {
-            Debug.Assert(context != null);
-            Debug.Assert(info != null);
+            if (context == null)
+            {
+                throw Error.ArgumentNull(nameof(context));
+            }
+
+            if (info == null)
+            {
+                throw Error.ArgumentNull(nameof(info));
+            }
 
             context.Validate(info.Contact);