Ensure OpenApiWriterSpecialCharacterTests cover terse output

Author: nulltoken

test/Microsoft.OpenApi.Tests/Writers/OpenApiWriterSpecialCharacterTests.cs

@@ -1,8 +1,10 @@
 // Copyright (c) Microsoft Corporation. All rights reserved.
 // Licensed under the MIT license. 
 
+using System.Collections.Generic;
 using System.Globalization;
 using System.IO;
+using System.Linq;
 using FluentAssertions;
 using Microsoft.OpenApi.Writers;
 using Xunit;
@@ -20,20 +22,35 @@ public OpenApiWriterSpecialCharacterTests(ITestOutputHelper output)
             _output = output;
         }
 
+        static bool[] shouldProduceTerseOutputValues = new[] { true, false };
+
+        public static IEnumerable<object[]> StringWithSpecialCharacters
+        {
+            get
+            {
+                return
+                    from inputExpected in new[] {
+                       new[]{ "Test\bTest", "\"Test\\bTest\"" },
+                       new[]{ "Test\fTest", "\"Test\\fTest\""},
+                       new[]{ "Test\nTest", "\"Test\\nTest\""},
+                       new[]{ "Test\rTest", "\"Test\\rTest\""},
+                       new[]{ "Test\tTest", "\"Test\\tTest\""},
+                       new[]{ "Test\\Test", "\"Test\\\\Test\""},
+                       new[]{ "Test\"Test", "\"Test\\\"Test\""},
+                       new[]{ "StringsWith\"Quotes\"", "\"StringsWith\\\"Quotes\\\"\""},
+                     }
+                    from shouldBeTerse in shouldProduceTerseOutputValues
+                    select new object[] { inputExpected[0], inputExpected[1], shouldBeTerse };
+            }
+        }
+
         [Theory]
-        [InlineData("Test\bTest", "\"Test\\bTest\"")]
-        [InlineData("Test\fTest", "\"Test\\fTest\"")]
-        [InlineData("Test\nTest", "\"Test\\nTest\"")]
-        [InlineData("Test\rTest", "\"Test\\rTest\"")]
-        [InlineData("Test\tTest", "\"Test\\tTest\"")]
-        [InlineData("Test\\Test", "\"Test\\\\Test\"")]
-        [InlineData("Test\"Test", "\"Test\\\"Test\"")]
-        [InlineData("StringsWith\"Quotes\"", "\"StringsWith\\\"Quotes\\\"\"")]
-        public void WriteStringWithSpecialCharactersAsJsonWorks(string input, string expected)
+        [MemberData(nameof(StringWithSpecialCharacters))]
+        public void WriteStringWithSpecialCharactersAsJsonWorks(string input, string expected, bool produceTerseOutput)
         {
             // Arrange
             var outputStringWriter = new StringWriter(CultureInfo.InvariantCulture);
-            var writer = new OpenApiJsonWriter(outputStringWriter);
+            var writer = new OpenApiJsonWriter(outputStringWriter, new OpenApiJsonWriterSettings { Terse = produceTerseOutput });
 
             // Act
             writer.WriteValue(input);
@@ -75,7 +92,7 @@ public void WriteStringWithSpecialCharactersAsYamlWorks(string input, string exp
             // Assert
             actual.Should().Be(expected);
         }
-        
+
         [Theory]
         [InlineData("multiline\r\nstring", "test: |-\n  multiline\n  string")]
         [InlineData("ends with\r\nline break\r\n", "test: |\n  ends with\n  line break")]
@@ -103,7 +120,7 @@ public void WriteStringWithNewlineCharactersInObjectAsYamlWorks(string input, st
             // Assert
             actual.Should().Be(expected);
         }
-        
+
         [Theory]
         [InlineData("multiline\r\nstring", "- |-\n  multiline\n  string")]
         [InlineData("ends with\r\nline break\r\n", "- |\n  ends with\n  line break")]