Fixed based on code review

Author: darrelmiller

src/Microsoft.OpenApi.Readers/ParseNodes/ParseNode.cs

@@ -32,8 +32,6 @@ public MapNode CheckMapNode(string nodeName)
             if (mapNode == null)
             {
                 throw new OpenApiException($"{nodeName} must be a map/object");
-                //Diagnostic.Errors.Add(
-                //    new OpenApiError("", $"{nodeName} must be a map/object at " + Context.GetLocation()));
             }
 
             return mapNode;
@@ -70,54 +68,50 @@ public static ParseNode Create(ParsingContext context, OpenApiDiagnostic diagnos
 
         public virtual List<T> CreateList<T>(Func<MapNode, T> map)
         {
-            throw new OpenApiException("Cannot create list");
+            throw new OpenApiException("Cannot create list from this type of node.");
         }
 
         public virtual Dictionary<string, T> CreateMap<T>(Func<MapNode, T> map)
         {
-            throw new OpenApiException("Cannot create map");
+            throw new OpenApiException("Cannot create map from this type of node.");
         }
 
         public virtual Dictionary<string, T> CreateMapWithReference<T>(
             ReferenceType referenceType,
             Func<MapNode, T> map)
             where T : class, IOpenApiReferenceable
         {
-            throw new OpenApiException("Cannot create map from reference");
+            throw new OpenApiException("Cannot create map from this reference.");
         }
 
         public virtual List<T> CreateSimpleList<T>(Func<ValueNode, T> map)
         {
-            throw new OpenApiException("Cannot create simple list");
+            throw new OpenApiException("Cannot create simple list from this type of node.");
         }
 
         public virtual Dictionary<string, T> CreateSimpleMap<T>(Func<ValueNode, T> map)
         {
-            throw new OpenApiException("Cannot create simple map");
+            throw new OpenApiException("Cannot create simple map from this type of node.");
         }
 
-        /// <summary>
-        /// Create a <see cref="IOpenApiAny"/>
-        /// </summary>
-        /// <returns></returns>
         public virtual IOpenApiAny CreateAny()
         {
-            throw new NotSupportedException();
+            throw new OpenApiException("Cannot create an Any object this type of node.");
         }
 
         public virtual string GetRaw()
         {
-            throw new OpenApiException("Cannot get raw value");
+            throw new OpenApiException("Cannot get raw value from this type of node.");
         }
 
         public virtual string GetScalarValue()
         {
-            throw new OpenApiException("Cannot get scalar value");
+            throw new OpenApiException("Cannot create a scalar value from this type of node.");
         }
 
         public virtual List<IOpenApiAny> CreateListOfAny()
         {
-            throw new OpenApiException("Cannot create list of any from here");
+            throw new OpenApiException("Cannot create a list from this type of node.");
         }
 
     }

src/Microsoft.OpenApi.Readers/Services/OpenApiReferenceResolver.cs

@@ -190,15 +190,16 @@ private void ResolveTags(IList<OpenApiTag> tags)
                 try
                 {
                     return _currentDocument.ResolveReference(reference) as T;
-                } catch(OpenApiException ex)
+                }
+                catch (OpenApiException ex)
                 {
                     _errors.Add(new OpenApiError(ex));
                     return null;
                 }
             }
             else if (_resolveRemoteReferences == true)
             {
-                // TODO: Resolve Remote reference
+                // TODO: Resolve Remote reference (Targeted for 1.1 release)
                 return new T()
                 {
                     UnresolvedReference = true,

src/Microsoft.OpenApi.Readers/V2/OpenApiDocumentDeserializer.cs

@@ -72,7 +72,8 @@ internal static partial class OpenApiV2Deserializer
                     o.Components.RequestBodies = n.CreateMapWithReference(ReferenceType.RequestBody, p => 
                             {
                                 var parameter = LoadParameter(p, evenBody: true);
-                                if (parameter.In == null) {
+                                if (parameter.In == null)
+                                {
                                     return CreateRequestBody(n.Context,parameter); 
                                 }
                                 return null;

src/Microsoft.OpenApi/Models/OpenApiDocument.cs

@@ -307,7 +307,7 @@ public IOpenApiReferenceable ResolveReference(OpenApiReference reference)
                 switch (reference.Type)
                 {
                     case ReferenceType.Schema:
-                        return this.Components.Schemas[reference.Id];  
+                        return this.Components.Schemas[reference.Id];
 
                     case ReferenceType.Response:
                         return this.Components.Responses[reference.Id];

test/Microsoft.OpenApi.SmokeTests/ApiGurus.cs

@@ -1,12 +1,14 @@
-using Microsoft.OpenApi.Readers;
-using Newtonsoft.Json;
-using Newtonsoft.Json.Linq;
+// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT license. 
+
 using System;
 using System.Collections.Generic;
 using System.Diagnostics;
 using System.Net;
 using System.Net.Http;
 using System.Threading.Tasks;
+using Microsoft.OpenApi.Readers;
+using Newtonsoft.Json.Linq;
 using Xunit;
 using Xunit.Abstractions;
 
@@ -15,28 +17,26 @@ namespace Microsoft.OpenApi.SmokeTests
     [Collection("DefaultSettings")]
     public class ApisGuruTests
     {
-        private static HttpClient _httpClient = new HttpClient(new HttpClientHandler() {
-            AutomaticDecompression = DecompressionMethods.GZip
-        });
-
-        private readonly ITestOutputHelper output;
+        private static HttpClient _httpClient;
+        private readonly ITestOutputHelper _output;
 
         public ApisGuruTests(ITestOutputHelper output)
         {
-           
-            this.output = output;
+            _output = output;
         }
 
         static ApisGuruTests()
         {
+            _httpClient = new HttpClient(new HttpClientHandler()
+            {
+                AutomaticDecompression = DecompressionMethods.GZip
+            });
             _httpClient.DefaultRequestHeaders.AcceptEncoding.Add(new System.Net.Http.Headers.StringWithQualityHeaderValue("gzip"));
             _httpClient.DefaultRequestHeaders.UserAgent.Add(new System.Net.Http.Headers.ProductInfoHeaderValue("OpenApi.Net.Tests", "1.0"));
-           
         }
 
         public static IEnumerable<object[]> GetSchemas()
         {
-
             var listJsonStr = _httpClient
                     .GetStringAsync("https://api.apis.guru/v2/list.json")
                     .GetAwaiter().GetResult();
@@ -69,39 +69,36 @@ JToken GetProp(JToken obj, string prop)
             }
         }
 
-
         [Theory(DisplayName = "APIs.guru")]
         [MemberData(nameof(GetSchemas))]
         public async Task EnsureThatICouldParse(string url)
-        {
-            var stopwatch = new Stopwatch();
-            
+        {  
             var response = await _httpClient.GetAsync(url);
             if (!response.IsSuccessStatusCode)
             {
-                output.WriteLine($"Couldn't load {url}");
+                _output.WriteLine($"Couldn't load {url}");
                 return;
             }
+
             await response.Content.LoadIntoBufferAsync();
             var stream = await response.Content.ReadAsStreamAsync();
 
+            var stopwatch = new Stopwatch();
             stopwatch.Start();
 
-            var reader = new OpenApiStreamReader(new OpenApiReaderSettings() {
-            });
+            var reader = new OpenApiStreamReader();
             var openApiDocument = reader.Read(stream, out var diagnostic);
 
             if (diagnostic.Errors.Count > 0)
             {
-                output.WriteLine($"Errors parsing {url}");
-                output.WriteLine(String.Join("\n", diagnostic.Errors));
+                _output.WriteLine($"Errors parsing {url}");
+                _output.WriteLine(String.Join("\n", diagnostic.Errors));
  //               Assert.True(false);  // Uncomment to identify descriptions with errors.
             }
 
             Assert.NotNull(openApiDocument);
             stopwatch.Stop();
-                output.WriteLine($"Parsing {url} took {stopwatch.ElapsedMilliseconds} ms.");
+                _output.WriteLine($"Parsing {url} took {stopwatch.ElapsedMilliseconds} ms.");
         }
-
-      }
+    }
 }