Clean up tests

Author: MaggieKimani1

test/Microsoft.OpenApi.Tests/Models/OpenApiOperationTests.cs

@@ -89,11 +89,6 @@ public class OpenApiOperationTests
         {
             Tags = new List<OpenApiTag>
             {
-                new()
-                {
-                    Name = "tagName1",
-                    Description = "tagDescription1",
-                },
                 new OpenApiTagReference("tagId1", null)
             },
             Summary = "summary1",
@@ -360,7 +355,6 @@ public void SerializeAdvancedOperationWithTagAndSecurityAsV3JsonWorks()
                 """
                 {
                   "tags": [
-                    "tagName1",
                     "tagId1"
                   ],
                   "summary": "summary1",
@@ -669,7 +663,6 @@ public void SerializeAdvancedOperationWithTagAndSecurityAsV2JsonWorks()
                 """
                 {
                   "tags": [
-                    "tagName1",
                     "tagId1"
                   ],
                   "summary": "summary1",

test/Microsoft.OpenApi.Tests/Models/OpenApiTagTests.SerializeAdvancedTagAsV2JsonWorksAsync_produceTerseOutput=False.verified.txt

@@ -1 +1,9 @@
-"pet"
+{
+  "name": "pet",
+  "description": "Pets operations",
+  "externalDocs": {
+    "description": "Find more info here",
+    "url": "https://example.com"
+  },
+  "x-tag-extension": null
+}

test/Microsoft.OpenApi.Tests/Models/OpenApiTagTests.SerializeAdvancedTagAsV2JsonWorksAsync_produceTerseOutput=True.verified.txt

@@ -1 +1 @@
-"pet"
+{"name":"pet","description":"Pets operations","externalDocs":{"description":"Find more info here","url":"https://example.com"},"x-tag-extension":null}

test/Microsoft.OpenApi.Tests/Models/OpenApiTagTests.SerializeAdvancedTagAsV3JsonWorksAsync_produceTerseOutput=False.verified.txt

@@ -1 +1,9 @@
-"pet"
+{
+  "name": "pet",
+  "description": "Pets operations",
+  "externalDocs": {
+    "description": "Find more info here",
+    "url": "https://example.com"
+  },
+  "x-tag-extension": null
+}

test/Microsoft.OpenApi.Tests/Models/OpenApiTagTests.SerializeAdvancedTagAsV3JsonWorksAsync_produceTerseOutput=True.verified.txt

@@ -1 +1 @@
-"pet"
+{"name":"pet","description":"Pets operations","externalDocs":{"description":"Find more info here","url":"https://example.com"},"x-tag-extension":null}

test/Microsoft.OpenApi.Tests/Models/OpenApiTagTests.cs

@@ -8,6 +8,7 @@
 using FluentAssertions;
 using Microsoft.OpenApi.Interfaces;
 using Microsoft.OpenApi.Models;
+using Microsoft.OpenApi.Models.References;
 using Microsoft.OpenApi.Writers;
 using VerifyXunit;
 using Xunit;
@@ -30,21 +31,7 @@ public class OpenApiTagTests
             }
         };
 
-        public static OpenApiTag ReferencedTag = new()
-        {
-            Name = "pet",
-            Description = "Pets operations",
-            ExternalDocs = OpenApiExternalDocsTests.AdvanceExDocs,
-            Extensions = new Dictionary<string, IOpenApiExtension>
-            {
-                {"x-tag-extension", null}
-            },
-            Reference = new()
-            {
-                Type = ReferenceType.Tag,
-                Id = "pet"
-            }
-        };
+        public static OpenApiTag ReferencedTag = new OpenApiTagReference("pet", null);
 
         [Theory]
         [InlineData(true)]
@@ -56,7 +43,7 @@ public async Task SerializeBasicTagAsV3JsonWithoutReferenceWorksAsync(bool produ
             var writer = new OpenApiJsonWriter(outputStringWriter, new() { Terse = produceTerseOutput });
 
             // Act
-            BasicTag.SerializeAsV3WithoutReference(writer);
+            BasicTag.SerializeAsV3(writer);
             writer.Flush();
 
             // Assert
@@ -73,7 +60,7 @@ public async Task SerializeBasicTagAsV2JsonWithoutReferenceWorksAsync(bool produ
             var writer = new OpenApiJsonWriter(outputStringWriter, new() { Terse = produceTerseOutput });
 
             // Act
-            BasicTag.SerializeAsV2WithoutReference(writer);
+            BasicTag.SerializeAsV2(writer);
             writer.Flush();
 
             // Assert
@@ -89,7 +76,7 @@ public void SerializeBasicTagAsV3YamlWithoutReferenceWorks()
             var expected = "{ }";
 
             // Act
-            BasicTag.SerializeAsV3WithoutReference(writer);
+            BasicTag.SerializeAsV3(writer);
             var actual = outputStringWriter.GetStringBuilder().ToString();
 
             // Assert
@@ -107,7 +94,7 @@ public void SerializeBasicTagAsV2YamlWithoutReferenceWorks()
             var expected = "{ }";
 
             // Act
-            BasicTag.SerializeAsV2WithoutReference(writer);
+            BasicTag.SerializeAsV2(writer);
             writer.Flush();
             var actual = outputStringWriter.GetStringBuilder().ToString();
 
@@ -127,7 +114,7 @@ public async Task SerializeAdvancedTagAsV3JsonWithoutReferenceWorksAsync(bool pr
             var writer = new OpenApiJsonWriter(outputStringWriter, new() { Terse = produceTerseOutput });
 
             // Act
-            AdvancedTag.SerializeAsV3WithoutReference(writer);
+            AdvancedTag.SerializeAsV3(writer);
             writer.Flush();
 
             // Assert
@@ -144,7 +131,7 @@ public async Task SerializeAdvancedTagAsV2JsonWithoutReferenceWorksAsync(bool pr
             var writer = new OpenApiJsonWriter(outputStringWriter, new() { Terse = produceTerseOutput });
 
             // Act
-            AdvancedTag.SerializeAsV2WithoutReference(writer);
+            AdvancedTag.SerializeAsV2(writer);
             writer.Flush();
 
             // Assert
@@ -168,7 +155,7 @@ public void SerializeAdvancedTagAsV3YamlWithoutReferenceWorks()
                 """;
 
             // Act
-            AdvancedTag.SerializeAsV3WithoutReference(writer);
+            AdvancedTag.SerializeAsV3(writer);
             writer.Flush();
             var actual = outputStringWriter.GetStringBuilder().ToString();
 
@@ -195,7 +182,7 @@ public void SerializeAdvancedTagAsV2YamlWithoutReferenceWorks()
                 """;
 
             // Act
-            AdvancedTag.SerializeAsV2WithoutReference(writer);
+            AdvancedTag.SerializeAsV2(writer);
             writer.Flush();
             var actual = outputStringWriter.GetStringBuilder().ToString();
 
@@ -246,7 +233,12 @@ public void SerializeAdvancedTagAsV3YamlWorks()
             var outputStringWriter = new StringWriter(CultureInfo.InvariantCulture);
             var writer = new OpenApiYamlWriter(outputStringWriter);
 
-            var expected = @" pet";
+            var expected = @"name: pet
+description: Pets operations
+externalDocs:
+  description: Find more info here
+  url: https://example.com
+x-tag-extension:";
 
             // Act
             AdvancedTag.SerializeAsV3(writer);
@@ -266,7 +258,12 @@ public void SerializeAdvancedTagAsV2YamlWorks()
             var outputStringWriter = new StringWriter(CultureInfo.InvariantCulture);
             var writer = new OpenApiYamlWriter(outputStringWriter);
 
-            var expected = @" pet";
+            var expected = @"name: pet
+description: Pets operations
+externalDocs:
+  description: Find more info here
+  url: https://example.com
+x-tag-extension:";
 
             // Act
             AdvancedTag.SerializeAsV2(writer);

test/Microsoft.OpenApi.Tests/PublicApi/PublicApi.approved.txt

@@ -995,11 +995,8 @@ namespace Microsoft.OpenApi.Models
         public virtual Microsoft.OpenApi.Models.OpenApiExternalDocs ExternalDocs { get; set; }
         public virtual string Name { get; set; }
         public virtual void SerializeAsV2(Microsoft.OpenApi.Writers.IOpenApiWriter writer) { }
-        public void SerializeAsV2WithoutReference(Microsoft.OpenApi.Writers.IOpenApiWriter writer) { }
         public virtual void SerializeAsV3(Microsoft.OpenApi.Writers.IOpenApiWriter writer) { }
         public virtual void SerializeAsV31(Microsoft.OpenApi.Writers.IOpenApiWriter writer) { }
-        public virtual void SerializeAsV31WithoutReference(Microsoft.OpenApi.Writers.IOpenApiWriter writer) { }
-        public virtual void SerializeAsV3WithoutReference(Microsoft.OpenApi.Writers.IOpenApiWriter writer) { }
     }
     public class OpenApiXml : Microsoft.OpenApi.Interfaces.IOpenApiElement, Microsoft.OpenApi.Interfaces.IOpenApiExtensible, Microsoft.OpenApi.Interfaces.IOpenApiSerializable
     {