Merge branch 'master' into patch-1

Author: darrelmiller

src/Microsoft.OpenApi/Models/OpenApiParameter.cs

@@ -177,7 +177,7 @@ public void SerializeAsV3WithoutReference(IOpenApiWriter writer)
             writer.WriteProperty(OpenApiConstants.Style, Style?.GetDisplayName());
 
             // explode
-            writer.WriteProperty(OpenApiConstants.Explode, Explode, false);
+            writer.WriteProperty(OpenApiConstants.Explode, Explode, Style.HasValue && Style.Value == ParameterStyle.Form);
 
             // allowReserved
             writer.WriteProperty(OpenApiConstants.AllowReserved, AllowReserved, false);

test/Microsoft.OpenApi.Tests/Models/OpenApiParameterTests.cs

@@ -5,6 +5,7 @@
 using System.Globalization;
 using System.IO;
 using FluentAssertions;
+using Microsoft.OpenApi.Any;
 using Microsoft.OpenApi.Extensions;
 using Microsoft.OpenApi.Models;
 using Microsoft.OpenApi.Writers;
@@ -58,6 +59,50 @@ public class OpenApiParameterTests
             }
         };
 
+        public static OpenApiParameter ParameterWithFormStyleAndExplodeFalse = new OpenApiParameter
+        {
+            Name = "name1",
+            In = ParameterLocation.Query,
+            Description = "description1",
+            Style = ParameterStyle.Form,
+            Explode = false,
+            Schema = new OpenApiSchema
+            {
+                Type = "array",
+                Items = new OpenApiSchema
+                {
+                    Enum = new List<IOpenApiAny>
+                    {
+                        new OpenApiString("value1"),
+                        new OpenApiString("value2")
+                    }
+                }
+            }
+
+        };
+
+        public static OpenApiParameter ParameterWithFormStyleAndExplodeTrue = new OpenApiParameter
+        {
+            Name = "name1",
+            In = ParameterLocation.Query,
+            Description = "description1",
+            Style = ParameterStyle.Form,
+            Explode = true,
+            Schema = new OpenApiSchema
+            {
+                Type = "array",
+                Items = new OpenApiSchema
+                {
+                    Enum = new List<IOpenApiAny>
+                    {
+                        new OpenApiString("value1"),
+                        new OpenApiString("value2")
+                    }
+                }
+            }
+
+        };
+
         public static OpenApiParameter AdvancedHeaderParameterWithSchemaReference = new OpenApiParameter
         {
             Name = "name1",
@@ -309,5 +354,74 @@ public void SerializeParameterWithSchemaTypeObjectAsV2JsonWorks()
             expected = expected.MakeLineBreaksEnvironmentNeutral();
             actual.Should().Be(expected);
         }
+
+        [Fact]
+        public void SerializeParameterWithFormStyleAndExplodeFalseWorks()
+        {
+            // Arrange
+            var outputStringWriter = new StringWriter(CultureInfo.InvariantCulture);
+            var writer = new OpenApiJsonWriter(outputStringWriter);
+            var expected =
+                @"{
+  ""name"": ""name1"",
+  ""in"": ""query"",
+  ""description"": ""description1"",
+  ""style"": ""form"",
+  ""explode"": false,
+  ""schema"": {
+    ""type"": ""array"",
+    ""items"": {
+      ""enum"": [
+        ""value1"",
+        ""value2""
+      ]
+    }
+  }
+}";
+
+            // Act
+            ParameterWithFormStyleAndExplodeFalse.SerializeAsV3WithoutReference(writer);
+            writer.Flush();
+            var actual = outputStringWriter.GetStringBuilder().ToString();
+
+            // Assert
+            actual = actual.MakeLineBreaksEnvironmentNeutral();
+            expected = expected.MakeLineBreaksEnvironmentNeutral();
+            actual.Should().Be(expected);
+        }
+
+        [Fact]
+        public void SerializeParameterWithFormStyleAndExplodeTrueWorks()
+        {
+            // Arrange
+            var outputStringWriter = new StringWriter(CultureInfo.InvariantCulture);
+            var writer = new OpenApiJsonWriter(outputStringWriter);
+            var expected =
+                @"{
+  ""name"": ""name1"",
+  ""in"": ""query"",
+  ""description"": ""description1"",
+  ""style"": ""form"",
+  ""schema"": {
+    ""type"": ""array"",
+    ""items"": {
+      ""enum"": [
+        ""value1"",
+        ""value2""
+      ]
+    }
+  }
+}";
+
+            // Act
+            ParameterWithFormStyleAndExplodeTrue.SerializeAsV3WithoutReference(writer);
+            writer.Flush();
+            var actual = outputStringWriter.GetStringBuilder().ToString();
+
+            // Assert
+            actual = actual.MakeLineBreaksEnvironmentNeutral();
+            expected = expected.MakeLineBreaksEnvironmentNeutral();
+            actual.Should().Be(expected);
+        }
     }
 }