Code cleanup

Author: darrelmiller

src/Microsoft.OpenApi.Readers/Interface/IOpenApiVersionService.cs

@@ -30,11 +30,6 @@ internal interface IOpenApiVersionService
         /// <returns>Instance of OpenAPIElement</returns>
         T LoadElement<T>(ParseNode node) where T : IOpenApiElement;
 
-        /// <summary>
-        /// Function that converts a MapNode into a Tag object in a version specific way
-        /// </summary>
-        Func<MapNode, OpenApiTag> TagLoader { get; }
-
         /// <summary>
         /// Converts a generic RootNode instance into a strongly typed OpenApiDocument
         /// </summary>

src/Microsoft.OpenApi.Readers/ParsingContext.cs

@@ -68,6 +68,7 @@ internal OpenApiDocument Parse(YamlDocument yamlDocument, OpenApiDiagnostic diag
         /// Initiates the parsing process of a fragment.  Not thread safe and should only be called once on a parsing context
         /// </summary>
         /// <param name="yamlDocument"></param>
+        /// <param name="version">OpenAPI version of the fragment</param>
         /// <param name="diagnostic"></param>
         /// <returns>An OpenApiDocument populated based on the passed yamlDocument </returns>
         internal T ParseFragment<T>(YamlDocument yamlDocument, OpenApiSpecVersion version, OpenApiDiagnostic diagnostic) where T: IOpenApiElement
@@ -109,20 +110,6 @@ private static string GetVersion(RootNode rootNode)
             return versionNode?.GetScalarValue();
         }
 
-        private void ComputeTags(List<OpenApiTag> tags, Func<MapNode, OpenApiTag> loadTag)
-        {
-            // Precompute the tags array so that each tag reference does not require a new deserialization.
-            var tagListPointer = new JsonPointer("#/tags");
-
-            var tagListNode = RootNode.Find(tagListPointer);
-
-            if (tagListNode != null && tagListNode is ListNode)
-            {
-                var tagListNodeAsListNode = (ListNode)tagListNode;
-                tags.AddRange(tagListNodeAsListNode.CreateList(loadTag));
-            }
-        }
-
         /// <summary>
         /// Service providing all Version specific conversion functions
         /// </summary>
@@ -135,7 +122,6 @@ internal IOpenApiVersionService VersionService
             set
             {
                 _versionService = value;
-                //ComputeTags(Tags, VersionService.TagLoader);
             }
         }
 

src/Microsoft.OpenApi.Readers/V2/OpenApiV2VersionService.cs

@@ -39,12 +39,6 @@ internal class OpenApiV2VersionService : IOpenApiVersionService
             [typeof(OpenApiXml)] = OpenApiV2Deserializer.LoadXml
         };
 
-
-        /// <summary>
-        /// Return a function that converts a MapNode into a V2 OpenApiTag
-        /// </summary>
-        public Func<MapNode, OpenApiTag> TagLoader => OpenApiV2Deserializer.LoadTag;
-
         private static OpenApiReference ParseLocalReference(string localReference)
         {
             if (string.IsNullOrWhiteSpace(localReference))

src/Microsoft.OpenApi.Readers/V3/OpenApiV3VersionService.cs

@@ -49,11 +49,6 @@ internal class OpenApiV3VersionService : IOpenApiVersionService
             [typeof(OpenApiXml)] = OpenApiV3Deserializer.LoadXml
         };
 
-        /// <summary>
-        /// Return a function that converts a MapNode into a V3 OpenApiTag
-        /// </summary>
-        public Func<MapNode, OpenApiTag> TagLoader => OpenApiV3Deserializer.LoadTag;
-
         /// <summary>
         /// Parse the string to a <see cref="OpenApiReference"/> object.
         /// </summary>

test/Microsoft.OpenApi.SmokeTests/ApiGurus.cs

@@ -27,6 +27,7 @@ public ApisGuruTests(ITestOutputHelper output)
 
         static ApisGuruTests()
         {
+            System.Net.ServicePointManager.SecurityProtocol = SecurityProtocolType.Tls12;
             _httpClient = new HttpClient(new HttpClientHandler()
             {
                 AutomaticDecompression = DecompressionMethods.GZip