Skip to content

Commit d758803

Browse files
committed
Update extensions to return null instead of throwing
1 parent 2bb1203 commit d758803

6 files changed

+7
-7
lines changed

src/Microsoft.OpenApi/MicrosoftExtensions/OpenApiDeprecationExtension.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ public void Write(IOpenApiWriter writer, OpenApiSpecVersion specVersion)
7878
/// <exception cref="ArgumentOutOfRangeException">When the source element is not an object</exception>
7979
public static OpenApiDeprecationExtension Parse(IOpenApiAny source)
8080
{
81-
if (source is not OpenApiObject rawObject) throw new ArgumentOutOfRangeException(nameof(source));
81+
if (source is not OpenApiObject rawObject) return null;
8282
var extension = new OpenApiDeprecationExtension();
8383
if (rawObject.TryGetValue(nameof(RemovalDate).ToFirstCharacterLowerCase(), out var removalDate) && removalDate is OpenApiDateTime removalDateValue)
8484
extension.RemovalDate = removalDateValue.Value;

src/Microsoft.OpenApi/MicrosoftExtensions/OpenApiEnumFlagsExtension.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ public void Write(IOpenApiWriter writer, OpenApiSpecVersion specVersion)
4545
/// <exception cref="ArgumentOutOfRangeException">When the source element is not an object</exception>
4646
public static OpenApiEnumFlagsExtension Parse(IOpenApiAny source)
4747
{
48-
if (source is not OpenApiObject rawObject) throw new ArgumentOutOfRangeException(nameof(source));
48+
if (source is not OpenApiObject rawObject) return null;
4949
var extension = new OpenApiEnumFlagsExtension();
5050
if (rawObject.TryGetValue(nameof(IsFlags).ToFirstCharacterLowerCase(), out var flagsValue) && flagsValue is OpenApiBoolean isFlags)
5151
{

src/Microsoft.OpenApi/MicrosoftExtensions/OpenApiEnumValuesDescriptionExtension.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ public void Write(IOpenApiWriter writer, OpenApiSpecVersion specVersion)
6464
/// <exception cref="ArgumentOutOfRangeException">When the source element is not an object</exception>
6565
public static OpenApiEnumValuesDescriptionExtension Parse(IOpenApiAny source)
6666
{
67-
if (source is not OpenApiObject rawObject) throw new ArgumentOutOfRangeException(nameof(source));
67+
if (source is not OpenApiObject rawObject) return null;
6868
var extension = new OpenApiEnumValuesDescriptionExtension();
6969
if (rawObject.TryGetValue("values", out var values) && values is OpenApiArray valuesArray)
7070
{

src/Microsoft.OpenApi/MicrosoftExtensions/OpenApiPagingExtension.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ public void Write(IOpenApiWriter writer, OpenApiSpecVersion specVersion)
7373
/// <exception cref="ArgumentOutOfRangeException">When the source element is not an object</exception>
7474
public static OpenApiPagingExtension Parse(IOpenApiAny source)
7575
{
76-
if (source is not OpenApiObject rawObject) throw new ArgumentOutOfRangeException(nameof(source));
76+
if (source is not OpenApiObject rawObject) return null;
7777
var extension = new OpenApiPagingExtension();
7878
if (rawObject.TryGetValue(nameof(NextLinkName).ToFirstCharacterLowerCase(), out var nextLinkName) && nextLinkName is OpenApiString nextLinkNameStr)
7979
{

src/Microsoft.OpenApi/MicrosoftExtensions/OpenApiPrimaryErrorMessageExtension.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// ------------------------------------------------------------
1+
// ------------------------------------------------------------
22
// Copyright (c) Microsoft Corporation. All rights reserved.
33
// Licensed under the MIT License (MIT). See LICENSE in the repo root for license information.
44
// ------------------------------------------------------------
@@ -39,7 +39,7 @@ public void Write(IOpenApiWriter writer, OpenApiSpecVersion specVersion)
3939
/// <returns>The <see cref="OpenApiPrimaryErrorMessageExtension"/>.</returns>
4040
public static OpenApiPrimaryErrorMessageExtension Parse(IOpenApiAny source)
4141
{
42-
if (source is not OpenApiBoolean rawObject) throw new ArgumentOutOfRangeException(nameof(source));
42+
if (source is not OpenApiBoolean rawObject) return null;
4343
return new()
4444
{
4545
IsPrimaryErrorMessage = rawObject.Value

src/Microsoft.OpenApi/MicrosoftExtensions/OpenApiReservedParameterExtension.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ public bool? IsReserved
4141
/// <returns></returns>
4242
public static OpenApiReservedParameterExtension Parse(IOpenApiAny source)
4343
{
44-
if (source is not OpenApiBoolean rawBoolean) throw new ArgumentOutOfRangeException(nameof(source));
44+
if (source is not OpenApiBoolean rawBoolean) return null;
4545
return new()
4646
{
4747
IsReserved = rawBoolean.Value

0 commit comments

Comments
 (0)