More cleanup

Author: MaggieKimani1

src/Microsoft.OpenApi.Readers/V2/OpenApiDocumentDeserializer.cs

@@ -321,7 +321,7 @@ private static void RegisterComponentsSchemasInGlobalRegistry(IDictionary<string
 
             foreach (var schema in schemas)
             {
-                var refUri = new Uri($"http://everything.json/definitions/{schema.Key}");
+                var refUri = new Uri(OpenApiConstants.v2ReferenceUri + schema.Key);
                 SchemaRegistry.Global.Register(refUri, schema.Value);
             }
         }

src/Microsoft.OpenApi.Readers/V31/OpenApiComponentsDeserializer.cs

@@ -1,5 +1,6 @@
-using System.Text.Json.Nodes;
-using System.Text.Json;
+// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT license.
+
 using System;
 using Json.Schema;
 using Microsoft.OpenApi.Extensions;
@@ -43,7 +44,7 @@ public static OpenApiComponents LoadComponents(ParseNode node)
 
             foreach (var schema in components.Schemas)
             {
-                var refUri = new Uri($"http://everything.json/components/schemas/{schema.Key}");
+                var refUri = new Uri(OpenApiConstants.v3ReferenceUri + schema.Key);
                 SchemaRegistry.Global.Register(refUri, schema.Value);
             }
 

src/Microsoft.OpenApi/Models/OpenApiConstants.cs

@@ -595,6 +595,16 @@ public static class OpenApiConstants
         /// </summary>
         public static readonly Uri defaultUrl = new Uri("http://localhost/");
 
+        /// <summary>
+        /// Field: V3 JsonSchema Reference Uri
+        /// </summary>
+        public const string v3ReferenceUri = "https://everything.json/components/schemas/";
+
+        /// <summary>
+        /// Field: V2 JsonSchema Reference Uri
+        /// </summary>
+        public const string v2ReferenceUri = "https://everything.json/definitions/";
+
         #region V2.0
 
         /// <summary>

src/Microsoft.OpenApi/Services/OpenApiReferenceResolver.cs

@@ -245,7 +245,7 @@ private Dictionary<string, JsonSchema> ResolveJsonSchemas(IDictionary<string, Js
         /// <returns></returns>
         public JsonSchema ResolveJsonSchemaReference(Uri reference, string description = null, string summary = null)
         {
-            var refUri = $"http://everything.json{reference.OriginalString.Split('#').LastOrDefault()}";
+            var refUri = $"https://everything.json{reference.OriginalString.Split('#').LastOrDefault()}";
             var resolvedSchema = (JsonSchema)SchemaRegistry.Global.Get(new Uri(refUri));
 
             if (resolvedSchema != null)

src/Microsoft.OpenApi/Services/OpenApiWorkspace.cs

@@ -155,7 +155,7 @@ public JsonSchema ResolveJsonSchemaReference(Uri reference)
                 {
                     foreach (var jsonSchema in doc.Components.Schemas)
                     {
-                        var refUri = new Uri($"http://everything.json/components/schemas/{jsonSchema.Key}");
+                        var refUri = new Uri(OpenApiConstants.v3ReferenceUri + jsonSchema.Key);
                         SchemaRegistry.Global.Register(refUri, jsonSchema.Value);
                     }
 

test/Microsoft.OpenApi.Tests/PublicApi/PublicApi.approved.txt

@@ -460,6 +460,8 @@ namespace Microsoft.OpenApi.Models
         public const string Wrapped = "wrapped";
         public const string WriteOnly = "writeOnly";
         public const string Xml = "xml";
+        public const string v2ReferenceUri = "https://everything.json/definitions/";
+        public const string v3ReferenceUri = "https://everything.json/components/schemas/";
         public static readonly System.Uri defaultUrl;
         public static readonly System.Version version2_0;
         public static readonly System.Version version3_0_0;

test/Microsoft.OpenApi.Tests/Workspaces/OpenApiWorkspaceTests.cs

@@ -80,7 +80,7 @@ public void OpenApiWorkspacesCanResolveExternalReferences()
 
             workspace.AddDocument(location, doc);
 
-            var schema = workspace.ResolveJsonSchemaReference(new Uri("http://everything.json/common#/components/schemas/test"));
+            var schema = workspace.ResolveJsonSchemaReference(new Uri("https://everything.json/common#/components/schemas/test"));
 
             Assert.NotNull(schema);
             Assert.Equal("The referenced one", schema.GetDescription());
@@ -147,7 +147,7 @@ public void OpenApiWorkspacesCanResolveReferencesToDocumentFragments()
             workspace.AddSchemaFragment("fragment", schemaFragment);
 
             // Act
-            var schema = workspace.ResolveJsonSchemaReference(new Uri("http://everything.json/common#/components/schemas/test"));
+            var schema = workspace.ResolveJsonSchemaReference(new Uri("https://everything.json/common#/components/schemas/test"));
 
             // Assert
             Assert.NotNull(schema);