chore: clean up nullability of params

Author: MaggieKimani1

src/Microsoft.OpenApi/Writers/IOpenApiWriter.cs

@@ -39,7 +39,7 @@ public interface IOpenApiWriter
         /// <summary>
         /// Write the string value.
         /// </summary>
-        void WriteValue(string? value);
+        void WriteValue(string value);
 
         /// <summary>
         /// Write the decimal value.

src/Microsoft.OpenApi/Writers/OpenApiJsonWriter.cs

@@ -153,7 +153,7 @@ public override void WriteEndArray()
         /// </summary>
         /// <param name="name">The property name.</param>
         /// public override void WritePropertyName(string name)
-        public override void WritePropertyName(string? name)
+        public override void WritePropertyName(string name)
         {
             VerifyCanWritePropertyName(name);
 
@@ -169,7 +169,7 @@ public override void WritePropertyName(string? name)
 
             WriteIndentation();
 
-            name = name?.GetJsonCompatibleString();
+            name = name.GetJsonCompatibleString();
 
             Writer.Write(name);
 
@@ -185,11 +185,11 @@ public override void WritePropertyName(string? name)
         /// Write string value.
         /// </summary>
         /// <param name="value">The string value.</param>
-        public override void WriteValue(string? value)
+        public override void WriteValue(string value)
         {
             WriteValueSeparator();
 
-            value = value?.GetJsonCompatibleString();
+            value = value.GetJsonCompatibleString();
 
             Writer.Write(value);
         }

src/Microsoft.OpenApi/Writers/OpenApiWriterBase.cs

@@ -100,7 +100,7 @@ protected OpenApiWriterBase(TextWriter textWriter, OpenApiWriterSettings? settin
         /// <summary>
         /// Write the start property.
         /// </summary>
-        public abstract void WritePropertyName(string? name);
+        public abstract void WritePropertyName(string name);
 
         /// <summary>
         /// Writes a separator of a value if it's needed for the next value to be written.
@@ -131,7 +131,7 @@ public Task FlushAsync(CancellationToken cancellationToken = default)
         /// Write string value.
         /// </summary>
         /// <param name="value">The string value.</param>
-        public abstract void WriteValue(string? value);
+        public abstract void WriteValue(string value);
 
         /// <summary>
         /// Write float value.
@@ -420,7 +420,7 @@ private bool IsScopeType(ScopeType type)
         /// the property name is a valid string and whether the current scope is an object scope.
         /// </summary>
         /// <param name="name">property name</param>
-        protected void VerifyCanWritePropertyName(string? name)
+        protected void VerifyCanWritePropertyName(string name)
         {
             Utils.CheckArgumentNull(name);
 

src/Microsoft.OpenApi/Writers/OpenApiYamlWriter.cs

@@ -135,7 +135,7 @@ public override void WriteEndArray()
         /// <summary>
         /// Write the property name and the delimiter.
         /// </summary>
-        public override void WritePropertyName(string? name)
+        public override void WritePropertyName(string name)
         {
             VerifyCanWritePropertyName(name);
 
@@ -156,7 +156,7 @@ public override void WritePropertyName(string? name)
                 WriteIndentation();
             }
 
-            name = name?.GetYamlCompatibleString();
+            name = name.GetYamlCompatibleString();
 
             Writer.Write(name);
             Writer.Write(":");
@@ -168,13 +168,13 @@ public override void WritePropertyName(string? name)
         /// Write string value.
         /// </summary>
         /// <param name="value">The string value.</param>
-        public override void WriteValue(string? value)
+        public override void WriteValue(string value)
         {
             if (!UseLiteralStyle || value?.IndexOfAny(new[] { '\n', '\r' }) == -1)
             {
                 WriteValueSeparator();
 
-                value = value?.GetYamlCompatibleString();
+                value = value.GetYamlCompatibleString();
 
                 Writer.Write(value);
             }