add the OpenApiRuleAttribute for each rule classes

xuzhg · xuzhg · commit da5f90a05a0c · 2017-12-18T14:17:41.000-08:00
diff --git a/src/Microsoft.OpenApi/Validations/Rules/OpenApiComponentsRules.cs b/src/Microsoft.OpenApi/Validations/Rules/OpenApiComponentsRules.cs
@@ -11,6 +11,7 @@ namespace Microsoft.OpenApi.Validations.Rules
     /// <summary>
     /// The validation rules for <see cref="OpenApiComponents"/>.
     /// </summary>
+    [OpenApiRule]
     public static class OpenApiComponentsRules
     {
         /// <summary>
@@ -22,7 +23,7 @@ public static class OpenApiComponentsRules
         /// All the fixed fields declared above are objects
         /// that MUST use keys that match the regular expression: ^[a-zA-Z0-9\.\-_]+$.
         /// </summary>
-        public static readonly ValidationRule<OpenApiComponents> KeyMustBeRegularExpression =
+        public static ValidationRule<OpenApiComponents> KeyMustBeRegularExpression =>
             new ValidationRule<OpenApiComponents>(
                 (context, components) =>
                 {
diff --git a/src/Microsoft.OpenApi/Validations/Rules/OpenApiContactRules.cs b/src/Microsoft.OpenApi/Validations/Rules/OpenApiContactRules.cs
@@ -10,12 +10,13 @@ namespace Microsoft.OpenApi.Validations.Rules
     /// <summary>
     /// The validation rules for <see cref="OpenApiContact"/>.
     /// </summary>
+    [OpenApiRule]
     internal static class OpenApiContactRules
     {
         /// <summary>
         /// Email field MUST be email address.
         /// </summary>
-        public static readonly ValidationRule<OpenApiContact> EmailMustBeEmailFormat =
+        public static ValidationRule<OpenApiContact> EmailMustBeEmailFormat =>
             new ValidationRule<OpenApiContact>(
                 (context, item) =>
                 {
@@ -35,7 +36,7 @@ internal static class OpenApiContactRules
         /// <summary>
         /// Url field MUST be url format.
         /// </summary>
-        public static readonly ValidationRule<OpenApiContact> UrlMustBeUrlFormat =
+        public static ValidationRule<OpenApiContact> UrlMustBeUrlFormat =>
             new ValidationRule<OpenApiContact>(
                 (context, item) =>
                 {
diff --git a/src/Microsoft.OpenApi/Validations/Rules/OpenApiDocumentRules.cs b/src/Microsoft.OpenApi/Validations/Rules/OpenApiDocumentRules.cs
@@ -10,12 +10,13 @@ namespace Microsoft.OpenApi.Validations.Rules
     /// <summary>
     /// The validation rules for <see cref="OpenApiDocument"/>.
     /// </summary>
+    [OpenApiRule]
     internal static class OpenApiDocumentRules
     {
         /// <summary>
         /// The Info field is required.
         /// </summary>
-        public static readonly ValidationRule<OpenApiDocument> FieldIsRequired =
+        public static ValidationRule<OpenApiDocument> FieldIsRequired =>
             new ValidationRule<OpenApiDocument>(
                 (context, item) =>
                 {
diff --git a/src/Microsoft.OpenApi/Validations/Rules/OpenApiExtensionRules.cs b/src/Microsoft.OpenApi/Validations/Rules/OpenApiExtensionRules.cs
@@ -10,12 +10,13 @@ namespace Microsoft.OpenApi.Validations.Rules
     /// <summary>
     /// The validation rules for <see cref="IOpenApiExtensible"/>.
     /// </summary>
+    [OpenApiRule]
     public static class OpenApiExtensibleRules
     {
         /// <summary>
         /// Extension name MUST start with "x-".
         /// </summary>
-        public static readonly ValidationRule<IOpenApiExtensible> ExtensionNameMustStartWithXDash =
+        public static ValidationRule<IOpenApiExtensible> ExtensionNameMustStartWithXDash =>
             new ValidationRule<IOpenApiExtensible>(
                 (context, item) =>
                 {
diff --git a/src/Microsoft.OpenApi/Validations/Rules/OpenApiExternalDocsRules.cs b/src/Microsoft.OpenApi/Validations/Rules/OpenApiExternalDocsRules.cs
@@ -10,12 +10,13 @@ namespace Microsoft.OpenApi.Validations.Rules
     /// <summary>
     /// The validation rules for <see cref="OpenApiExternalDocs"/>.
     /// </summary>
+    [OpenApiRule]
     internal static class OpenApiExternalDocsRules
     {
         /// <summary>
         /// Validate the field is required.
         /// </summary>
-        public static readonly ValidationRule<OpenApiExternalDocs> FieldIsRequired =
+        public static ValidationRule<OpenApiExternalDocs> FieldIsRequired =>
             new ValidationRule<OpenApiExternalDocs>(
                 (context, item) =>
                 {
diff --git a/src/Microsoft.OpenApi/Validations/Rules/OpenApiInfoRules.cs b/src/Microsoft.OpenApi/Validations/Rules/OpenApiInfoRules.cs
@@ -10,12 +10,13 @@ namespace Microsoft.OpenApi.Validations.Rules
     /// <summary>
     /// The validation rules for <see cref="OpenApiInfo"/>.
     /// </summary>
+    [OpenApiRule]
     internal static class OpenApiInfoRules
     {
         /// <summary>
         /// Validate the field is required.
         /// </summary>
-        public static readonly ValidationRule<OpenApiInfo> FieldIsRequired =
+        public static ValidationRule<OpenApiInfo> FieldIsRequired =>
             new ValidationRule<OpenApiInfo>(
                 (context, item) =>
                 {
diff --git a/src/Microsoft.OpenApi/Validations/Rules/OpenApiLicenseRules.cs b/src/Microsoft.OpenApi/Validations/Rules/OpenApiLicenseRules.cs
@@ -10,12 +10,13 @@ namespace Microsoft.OpenApi.Validations.Rules
     /// <summary>
     /// The validation rules for <see cref="OpenApiLicense"/>.
     /// </summary>
+    [OpenApiRule]
     public static class OpenApiLicenseRules
     {
         /// <summary>
         /// REQUIRED.
         /// </summary>
-        public static readonly ValidationRule<OpenApiLicense> FieldIsRequired =
+        public static ValidationRule<OpenApiLicense> FieldIsRequired =>
             new ValidationRule<OpenApiLicense>(
                 (context, license) =>
                 {
diff --git a/src/Microsoft.OpenApi/Validations/Rules/OpenApiOAuthFlowRules.cs b/src/Microsoft.OpenApi/Validations/Rules/OpenApiOAuthFlowRules.cs
@@ -10,12 +10,13 @@ namespace Microsoft.OpenApi.Validations.Rules
     /// <summary>
     /// The validation rules for <see cref="OpenApiOAuthFlow"/>.
     /// </summary>
+    [OpenApiRule]
     internal static class OpenApiOAuthFlowRules
     {
         /// <summary>
         /// Validate the field is required.
         /// </summary>
-        public static readonly ValidationRule<OpenApiOAuthFlow> FieldIsRequired =
+        public static ValidationRule<OpenApiOAuthFlow> FieldIsRequired =>
             new ValidationRule<OpenApiOAuthFlow>(
                 (context, flow) =>
                 {
diff --git a/src/Microsoft.OpenApi/Validations/Rules/OpenApiPathsRules.cs b/src/Microsoft.OpenApi/Validations/Rules/OpenApiPathsRules.cs
@@ -9,12 +9,13 @@ namespace Microsoft.OpenApi.Validations.Rules
     /// <summary>
     /// The validation rules for <see cref="OpenApiPaths"/>.
     /// </summary>
+    [OpenApiRule]
     public static class OpenApiPathsRules
     {
         /// <summary>
         /// A relative path to an individual endpoint. The field name MUST begin with a slash. 
         /// </summary>
-        public static readonly ValidationRule<OpenApiPaths> PathNameMustBeginWithSlash =
+        public static ValidationRule<OpenApiPaths> PathNameMustBeginWithSlash =>
             new ValidationRule<OpenApiPaths>(
                 (context, item) =>
                 {
diff --git a/src/Microsoft.OpenApi/Validations/Rules/OpenApiResponseRules.cs b/src/Microsoft.OpenApi/Validations/Rules/OpenApiResponseRules.cs
@@ -10,12 +10,13 @@ namespace Microsoft.OpenApi.Validations.Rules
     /// <summary>
     /// The validation rules for <see cref="OpenApiResponse"/>.
     /// </summary>
+    [OpenApiRule]
     internal static class OpenApiResponseRules
     {
         /// <summary>
         /// Validate the field is required.
         /// </summary>
-        public static readonly ValidationRule<OpenApiResponse> FieldIsRequired =
+        public static ValidationRule<OpenApiResponse> FieldIsRequired =>
             new ValidationRule<OpenApiResponse>(
                 (context, response) =>
                 {
diff --git a/src/Microsoft.OpenApi/Validations/Rules/OpenApiRuleAttribute.cs b/src/Microsoft.OpenApi/Validations/Rules/OpenApiRuleAttribute.cs
@@ -0,0 +1,15 @@
+﻿// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT license.
+
+using System;
+
+namespace Microsoft.OpenApi.Validations.Rules
+{
+    /// <summary>
+    /// The Validator attribute.
+    /// </summary>
+    [AttributeUsage(AttributeTargets.Class, AllowMultiple = false, Inherited = false)]
+    internal class OpenApiRuleAttribute : Attribute
+    {
+    }
+}
diff --git a/src/Microsoft.OpenApi/Validations/Rules/OpenApiServerRules.cs b/src/Microsoft.OpenApi/Validations/Rules/OpenApiServerRules.cs
@@ -10,12 +10,13 @@ namespace Microsoft.OpenApi.Validations.Rules
     /// <summary>
     /// The validation rules for <see cref="OpenApiServer"/>.
     /// </summary>
+    [OpenApiRule]
     public static class OpenApiServerRules
     {
         /// <summary>
         /// REQUIRED.
         /// </summary>
-        public static readonly ValidationRule<OpenApiServer> FieldIsRequired =
+        public static ValidationRule<OpenApiServer> FieldIsRequired =>
             new ValidationRule<OpenApiServer>(
                 (context, server) =>
                 {
diff --git a/src/Microsoft.OpenApi/Validations/Rules/OpenApiTagRules.cs b/src/Microsoft.OpenApi/Validations/Rules/OpenApiTagRules.cs
@@ -10,12 +10,13 @@ namespace Microsoft.OpenApi.Validations.Rules
     /// <summary>
     /// The validation rules for <see cref="OpenApiTag"/>.
     /// </summary>
+    [OpenApiRule]
     public static class OpenApiTagRules
     {
         /// <summary>
         /// REQUIRED.
         /// </summary>
-        public static readonly ValidationRule<OpenApiTag> FieldIsRequired =
+        public static ValidationRule<OpenApiTag> FieldIsRequired =>
             new ValidationRule<OpenApiTag>(
                 (context, tag) =>
                 {
diff --git a/src/Microsoft.OpenApi/Validations/ValidationRuleSet.cs b/src/Microsoft.OpenApi/Validations/ValidationRuleSet.cs
@@ -3,6 +3,7 @@
 
 using System;
 using System.Linq;
+using System.Reflection;
 using System.Collections;
 using System.Collections.Generic;
 using Microsoft.OpenApi.Exceptions;
@@ -17,34 +18,23 @@ public sealed class ValidationRuleSet : IEnumerable<ValidationRule>
     {
         private IDictionary<Type, IList<ValidationRule>> _rules = new Dictionary<Type, IList<ValidationRule>>();
 
+        private static ValidationRuleSet _defaultRuleSet;
+
         /// <summary>
-        /// The default rule set.
+        /// Gets the default validation rule sets.
         /// </summary>
-        public static ValidationRuleSet DefaultRuleSet = new ValidationRuleSet
+        public static ValidationRuleSet DefaultRuleSet
         {
-            OpenApiComponentsRules.KeyMustBeRegularExpression,
-
-            OpenApiDocumentRules.FieldIsRequired,
-
-            OpenApiInfoRules.FieldIsRequired,
-
-            OpenApiLicenseRules.FieldIsRequired,
-
-            OpenApiContactRules.EmailMustBeEmailFormat,
-
-            OpenApiExternalDocsRules.FieldIsRequired,
-
-            OpenApiServerRules.FieldIsRequired,
-
-            OpenApiTagRules.FieldIsRequired,
-
-            OpenApiResponseRules.FieldIsRequired,
-
-            OpenApiOAuthFlowRules.FieldIsRequired,
+            get
+            {
+                if (_defaultRuleSet == null)
+                {
+                    _defaultRuleSet = new Lazy<ValidationRuleSet>(() => BuildDefaultRuleSet(), isThreadSafe: false).Value;
+                }
 
-            OpenApiExtensibleRules.ExtensionNameMustStartWithXDash,
-            // add more default rules.
-        };
+                return _defaultRuleSet;
+            }
+        }
 
         /// <summary>
         /// Initializes a new instance of the <see cref="ValidationRuleSet"/> class.
@@ -123,5 +113,36 @@ IEnumerator IEnumerable.GetEnumerator()
         {
             return this.GetEnumerator();
         }
+
+        private static ValidationRuleSet BuildDefaultRuleSet()
+        {
+            ValidationRuleSet ruleSet = new ValidationRuleSet();
+
+            IEnumerable<Type> allTypes = typeof(ValidationRuleSet).Assembly.GetTypes().Where(t => t.IsClass && t != typeof(object));
+            Type validationRuleType = typeof(ValidationRule);
+            foreach (Type type in allTypes)
+            {
+                if (!type.GetCustomAttributes(typeof(OpenApiRuleAttribute), false).Any())
+                {
+                    continue;
+                }
+
+                var properties = type.GetProperties(BindingFlags.Static | BindingFlags.Public);
+                foreach (var property in properties)
+                {
+                    if (validationRuleType.IsAssignableFrom(property.PropertyType))
+                    {
+                        var propertyValue = property.GetValue(null); // static property
+                        ValidationRule rule = propertyValue as ValidationRule;
+                        if (rule != null)
+                        {
+                            ruleSet.Add(rule);
+                        }
+                    }
+                }
+            }
+
+            return ruleSet;
+        }
     }
 }
