Skip to content

Commit dade489

Browse files
committed
chore: removes extraneous virtual keywords
Signed-off-by: Vincent Biret <[email protected]>
1 parent 914d9f9 commit dade489

File tree

1 file changed

+20
-22
lines changed

1 file changed

+20
-22
lines changed

docs/upgrade-guide-2.md

Lines changed: 20 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -159,24 +159,22 @@ The OpenAPI 3.1 specification changes significantly how it leverages JSON Schema
159159

160160
```csharp
161161

162-
public virtual decimal? ExclusiveMaximum { get; set; } // New, but currently named v31ExclusiveMaximum
163-
public virtual decimal? ExclusiveMinimum { get; set; } // New, but Currently named v31ExclusiveMinimum)
164-
public virtual decimal? ExclusiveMaximum { get; set; } //type changed to reflect the new version of JSON schema
165-
public virtual decimal? ExclusiveMinimum { get; set; } // type changed to reflect the new version of JSON schema
166-
public virtual JsonSchemaType? Type { get; set; } // Was string, now flagged enum
167-
public virtual decimal? Maximum { get; set; } // Double???
168-
public virtual decimal? Minimum { get; set; } // Double???
169-
170-
public virtual JsonNode Default { get; set; } // Type matching no longer enforced. Was IOpenApiAny
171-
public virtual bool ReadOnly { get; set; } // No longer has defined semantics in OpenAPI 3.1
172-
public virtual bool WriteOnly { get; set; } // No longer has defined semantics in OpenAPI 3.1
173-
174-
public virtual JsonNode Example { get; set; } // No longer IOpenApiAny
175-
public virtual IList<JsonNode> Examples { get; set; }
176-
public virtual IList<JsonNode> Enum { get; set; }
177-
public virtual OpenApiExternalDocs ExternalDocs { get; set; } // OpenApi Vocab
178-
public virtual bool Deprecated { get; set; } // OpenApi Vocab
179-
public virtual OpenApiXml Xml { get; set; } // OpenApi Vocab
162+
public decimal? ExclusiveMaximum { get; set; } //type changed to reflect the new version of JSON schema
163+
public decimal? ExclusiveMinimum { get; set; } // type changed to reflect the new version of JSON schema
164+
public JsonSchemaType? Type { get; set; } // Was string, now flagged enum
165+
public decimal? Maximum { get; set; } // Double???
166+
public decimal? Minimum { get; set; } // Double???
167+
168+
public JsonNode Default { get; set; } // Type matching no longer enforced. Was IOpenApiAny
169+
public bool ReadOnly { get; set; } // No longer has defined semantics in OpenAPI 3.1
170+
public bool WriteOnly { get; set; } // No longer has defined semantics in OpenAPI 3.1
171+
172+
public JsonNode Example { get; set; } // No longer IOpenApiAny
173+
public IList<JsonNode> Examples { get; set; }
174+
public IList<JsonNode> Enum { get; set; }
175+
public OpenApiExternalDocs ExternalDocs { get; set; } // OpenApi Vocab
176+
public bool Deprecated { get; set; } // OpenApi Vocab
177+
public OpenApiXml Xml { get; set; } // OpenApi Vocab
180178
181179
public IDictionary<string, object> Annotations { get; set; } // Custom keywords?
182180
```
@@ -190,9 +188,9 @@ public class OpenApiSchema : IOpenApiAnnotatable, IOpenApiExtensible, IOpenApiRe
190188
{
191189
public OpenApiSchema() { }
192190
public OpenApiSchema(OpenApiSchema schema) { }
193-
public virtual void SerializeAsV31(IOpenApiWriter writer) { }
194-
public virtual void SerializeAsV3(IOpenApiWriter writer) { }
195-
public virtual void SerializeAsV2(IOpenApiWriter writer) { }
191+
public void SerializeAsV31(IOpenApiWriter writer) { }
192+
public void SerializeAsV3(IOpenApiWriter writer) { }
193+
public void SerializeAsV2(IOpenApiWriter writer) { }
196194
}
197195

198196
```
@@ -258,7 +256,7 @@ public class OpenApiDocument : IOpenApiSerializable, IOpenApiExtensible, IOpenA
258256
/// <summary>
259257
/// An object to hold reusable <see cref="OpenApiPathItem"/> Object.
260258
/// </summary>
261-
public virtual IDictionary<string, OpenApiPathItem>? PathItems { get; set; } = new Dictionary<string, OpenApiPathItem>();
259+
public IDictionary<string, OpenApiPathItem>? PathItems { get; set; } = new Dictionary<string, OpenApiPathItem>();
262260
}
263261
```
264262

0 commit comments

Comments
 (0)