Skip to content

Commit e1f0cbf

Browse files
committed
Remove the inlining code and test
1 parent 012ed30 commit e1f0cbf

File tree

2 files changed

+1
-41
lines changed

2 files changed

+1
-41
lines changed

src/Microsoft.OpenApi/Writers/OpenApiWriterBase.cs

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -446,10 +446,6 @@ public void WriteJsonSchema(JsonSchema schema, OpenApiSpecVersion version)
446446
{
447447
FindJsonSchemaRefs.ResolveJsonSchema(schema);
448448
}
449-
else if (Settings.InlineLocalReferences)
450-
{
451-
schema = FindJsonSchemaRefs.FetchSchemaFromRegistry(schema, reference);
452-
}
453449
if (!Settings.LoopDetector.PushLoop(schema))
454450
{
455451
Settings.LoopDetector.SaveLoop(schema);
@@ -459,10 +455,7 @@ public void WriteJsonSchema(JsonSchema schema, OpenApiSpecVersion version)
459455
}
460456
}
461457

462-
if (schema != null)
463-
{
464-
WriteJsonSchemaWithoutReference(this, schema, version);
465-
}
458+
WriteJsonSchemaWithoutReference(this, schema, version);
466459

467460
if (reference != null)
468461
{

test/Microsoft.OpenApi.Tests/Models/References/OpenApiRequestBodyReferenceTests.cs

Lines changed: 0 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -97,39 +97,6 @@ public OpenApiRequestBodyReferenceTests()
9797
};
9898
}
9999

100-
[Fact]
101-
public void RequestBodyReferenceResolutionWorks()
102-
{
103-
// Arrange
104-
var expectedMediaType = @"{
105-
""schema"": {
106-
""type"": ""object"",
107-
""properties"": {
108-
""name"": {
109-
""type"": ""string""
110-
},
111-
""email"": {
112-
""type"": ""string""
113-
}
114-
}
115-
}
116-
}";
117-
var mediaType = _localRequestBodyReference.Content["application/json"];
118-
var outputStringWriter = new StringWriter(CultureInfo.InvariantCulture);
119-
120-
// Act
121-
mediaType.SerializeAsV3(new OpenApiJsonWriter(outputStringWriter,
122-
new OpenApiJsonWriterSettings { InlineLocalReferences = true }));
123-
var serialized = outputStringWriter.GetStringBuilder().ToString();
124-
125-
// Assert
126-
serialized.MakeLineBreaksEnvironmentNeutral().Should().BeEquivalentTo(expectedMediaType.MakeLineBreaksEnvironmentNeutral());
127-
Assert.Equal("User request body", _localRequestBodyReference.Description);
128-
Assert.Equal("application/json", _localRequestBodyReference.Content.First().Key);
129-
Assert.Equal("External Reference: User request body", _externalRequestBodyReference.Description);
130-
Assert.Equal("User creation request body", _openApiDoc.Components.RequestBodies.First().Value.Description);
131-
}
132-
133100
[Theory]
134101
[InlineData(true)]
135102
[InlineData(false)]

0 commit comments

Comments
 (0)