Fixes more failing tests

Author: MaggieKimani1

src/Microsoft.OpenApi.Readers/OpenApiReaderSettings.cs

@@ -49,7 +49,7 @@ public class OpenApiReaderSettings
         /// <summary>
         /// Dictionary of parsers for converting extensions into strongly typed classes
         /// </summary>
-        public Dictionary<string, Func<JsonNode, OpenApiSpecVersion, IOpenApiExtension>> ExtensionParsers { get; set; } = new Dictionary<string, Func<JsonNode, OpenApiSpecVersion, IOpenApiExtension>>();
+        public Dictionary<string, Func<JsonNode, OpenApiSpecVersion, JsonNode>> ExtensionParsers { get; set; } = new Dictionary<string, Func<JsonNode, OpenApiSpecVersion, JsonNode>>();
 
         /// <summary>
         /// Rules to use for validating OpenAPI specification.  If none are provided a default set of rules are applied.

src/Microsoft.OpenApi.Readers/ParseNodes/OpenApiAnyConverter.cs

@@ -85,7 +85,7 @@ public static JsonNode GetSpecificOpenApiAny(JsonNode jsonNode, OpenApiSchema sc
             var type = schema?.Type;
             var format = schema?.Format;
 
-            if (value.StartsWith("\"") && value.EndsWith("\""))
+            if (value.Contains("\""))
             {
                 // More narrow type detection for explicit strings, only check types that are passed as strings
                 if (schema == null)
@@ -275,9 +275,9 @@ public static JsonNode GetSpecificOpenApiAny(JsonNode jsonNode, OpenApiSchema sc
 
                 if (type == "string")
                 {
-                    return jsonNode;
+                    return value;
                 }
-
+                
                 if (type == "boolean")
                 {
                     if (bool.TryParse(value, out var booleanValue))
@@ -290,7 +290,7 @@ public static JsonNode GetSpecificOpenApiAny(JsonNode jsonNode, OpenApiSchema sc
             // If data conflicts with the given type, return a string.
             // This converter is used in the parser, so it does not perform any validations, 
             // but the validator can be used to validate whether the data and given type conflicts.
-            return jsonNode;
+            return value;
         }
     }
 }

src/Microsoft.OpenApi.Readers/ParsingContext.cs

@@ -24,8 +24,8 @@ public class ParsingContext
         private readonly Dictionary<string, object> _tempStorage = new Dictionary<string, object>();
         private readonly Dictionary<object, Dictionary<string, object>> _scopedTempStorage = new Dictionary<object, Dictionary<string, object>>();
         private readonly Dictionary<string, Stack<string>> _loopStacks = new Dictionary<string, Stack<string>>();
-        internal Dictionary<string, Func<JsonNode, OpenApiSpecVersion, IOpenApiExtension>> ExtensionParsers { get; set; } = 
-            new Dictionary<string, Func<JsonNode, OpenApiSpecVersion, IOpenApiExtension>>();
+        internal Dictionary<string, Func<JsonNode, OpenApiSpecVersion, JsonNode>> ExtensionParsers { get; set; } = 
+            new Dictionary<string, Func<JsonNode, OpenApiSpecVersion, JsonNode>>();
         internal RootNode RootNode { get; set; }
         internal List<OpenApiTag> Tags { get; private set; } = new List<OpenApiTag>();
         internal Uri BaseUrl { get; set; }

src/Microsoft.OpenApi.Readers/V2/OpenApiOperationDeserializer.cs

@@ -213,7 +213,7 @@ internal static OpenApiRequestBody CreateRequestBody(
                 Extensions = bodyParameter.Extensions
             };
 
-            requestBody.Extensions[OpenApiConstants.BodyName] = new ExtensionTypeCaster<string>(bodyParameter.Name);
+            requestBody.Extensions[OpenApiConstants.BodyName] = bodyParameter.Name;
             return requestBody;
         }
 

src/Microsoft.OpenApi.Readers/V2/OpenApiV2Deserializer.cs

@@ -148,7 +148,7 @@ public static JsonNode LoadAny(ParseNode node)
             return OpenApiAnyConverter.GetSpecificOpenApiAny(node.CreateAny());
         }
 
-        private static IOpenApiExtension LoadExtension(string name, ParseNode node)
+        private static JsonNode LoadExtension(string name, ParseNode node)
         {
             if (node.Context.ExtensionParsers.TryGetValue(name, out var parser))
             {
@@ -158,7 +158,7 @@ private static IOpenApiExtension LoadExtension(string name, ParseNode node)
             }
             else
             {
-                return (IOpenApiExtension)OpenApiAnyConverter.GetSpecificOpenApiAny(node.CreateAny());
+                return OpenApiAnyConverter.GetSpecificOpenApiAny(node.CreateAny());
             }
         }
 

src/Microsoft.OpenApi.Readers/V3/OpenApiV3Deserializer.cs

@@ -168,15 +168,15 @@ public static JsonNode LoadAny(ParseNode node)
             return OpenApiAnyConverter.GetSpecificOpenApiAny(node.CreateAny());
         }
 
-        private static IOpenApiExtension LoadExtension(string name, ParseNode node)
+        private static JsonNode LoadExtension(string name, ParseNode node)
         {
             if (node.Context.ExtensionParsers.TryGetValue(name, out var parser))
             {
                 return parser(OpenApiAnyConverter.GetSpecificOpenApiAny(node.CreateAny()), OpenApiSpecVersion.OpenApi3_0);
             }
             else
             {
-                return (IOpenApiExtension)OpenApiAnyConverter.GetSpecificOpenApiAny(node.CreateAny());
+                return OpenApiAnyConverter.GetSpecificOpenApiAny(node.CreateAny());
             }
         }
 

src/Microsoft.OpenApi/Extensions/ExtensionTypeCaster.cs

@@ -0,0 +1,17 @@
+using System;
+using System.Collections.Generic;
+using System.Text;
+using System.Text.Json.Nodes;
+using Microsoft.OpenApi.Writers;
+
+namespace Microsoft.OpenApi.Extensions
+{
+    internal static class JsonNodeExtension
+    {
+        //private static void Write(this JsonNode, IOpenApiWriter writer) => writer.WriteValue(this);
+        //public void Write(IOpenApiWriter writer, OpenApiSpecVersion specVersion)
+        //{
+        //    writer.WriteValue(_value);
+        //}
+    }
+}

src/Microsoft.OpenApi/Extensions/JsonNodeExtension.cs

@@ -1,6 +1,7 @@
 // Copyright (c) Microsoft Corporation. All rights reserved.
 // Licensed under the MIT license. 
 
+using System.Text.Json.Nodes;
 using Microsoft.OpenApi.Exceptions;
 using Microsoft.OpenApi.Interfaces;
 using Microsoft.OpenApi.Models;
@@ -20,7 +21,7 @@ public static class OpenApiExtensibleExtensions
         /// <param name="element">The extensible Open API element. </param>
         /// <param name="name">The extension name.</param>
         /// <param name="any">The extension value.</param>
-        public static void AddExtension<T>(this T element, string name, IOpenApiExtension any)
+        public static void AddExtension<T>(this T element, string name, JsonNode any)
             where T : IOpenApiExtensible
         {
             if (element == null)

src/Microsoft.OpenApi/Extensions/OpenApiExtensibleExtensions.cs

@@ -2,6 +2,7 @@
 // Licensed under the MIT license. 
 
 using System.Collections.Generic;
+using System.Text.Json.Nodes;
 
 namespace Microsoft.OpenApi.Interfaces
 {
@@ -13,6 +14,6 @@ public interface IOpenApiExtensible : IOpenApiElement
         /// <summary>
         /// Specification extensions.
         /// </summary>
-        IDictionary<string, IOpenApiExtension> Extensions { get; set; }
+        IDictionary<string, JsonNode> Extensions { get; set; }
     }
 }