Skip to content

Commit e54e0c3

Browse files
committed
- fixes an issue where log entries would be missing
Signed-off-by: Vincent Biret <[email protected]>
1 parent 6294631 commit e54e0c3

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

src/Microsoft.OpenApi.Hidi/OpenApiService.cs

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,8 @@ public static async Task<int> TransformOpenApiDocument(
5454
CancellationToken cancellationToken
5555
)
5656
{
57-
var logger = ConfigureLoggerInstance(loglevel);
57+
using var loggerFactory = ConfigureLoggerInstance(loglevel);
58+
var logger = loggerFactory.CreateLogger<OpenApiService>();
5859

5960
try
6061
{
@@ -258,7 +259,8 @@ public static async Task<int> ValidateOpenApiDocument(
258259
LogLevel loglevel,
259260
CancellationToken cancellationToken)
260261
{
261-
var logger = ConfigureLoggerInstance(loglevel);
262+
using var loggerFactory = ConfigureLoggerInstance(loglevel);
263+
var logger = loggerFactory.CreateLogger<OpenApiService>();
262264

263265
try
264266
{
@@ -573,14 +575,14 @@ private static OpenApiFormat GetOpenApiFormat(string input, ILogger logger)
573575
return !input.StartsWith("http") && Path.GetExtension(input) == ".json" ? OpenApiFormat.Json : OpenApiFormat.Yaml;
574576
}
575577

576-
private static ILogger ConfigureLoggerInstance(LogLevel loglevel)
578+
private static ILoggerFactory ConfigureLoggerInstance(LogLevel loglevel)
577579
{
578580
// Configure logger options
579581
#if DEBUG
580582
loglevel = loglevel > LogLevel.Debug ? LogLevel.Debug : loglevel;
581583
#endif
582584

583-
var logger = LoggerFactory.Create((builder) => {
585+
return LoggerFactory.Create((builder) => {
584586
builder
585587
.AddSimpleConsole(c => {
586588
c.IncludeScopes = true;
@@ -589,9 +591,7 @@ private static ILogger ConfigureLoggerInstance(LogLevel loglevel)
589591
.AddDebug()
590592
#endif
591593
.SetMinimumLevel(loglevel);
592-
}).CreateLogger<OpenApiService>();
593-
594-
return logger;
594+
});
595595
}
596596
}
597597
}

0 commit comments

Comments
 (0)