Moved reference resolution into the OpenApi model project

Author: darrelmiller

src/Microsoft.OpenApi.Readers/OpenApiStreamReader.cs

@@ -51,7 +51,7 @@ public OpenApiDocument Read(Stream input, out OpenApiDiagnostic diagnostic)
                 case ReferenceResolutionSetting.ResolveAllReferences:
                     throw new ArgumentException("Cannot resolve remote references using synchronous Read method, use ReadAsync instead");
                 case ReferenceResolutionSetting.ResolveLocalReferences:
-                    ResolveReferences(document,false);
+                    document.ResolveReferences(false);
                     break;
                 case
                     ReferenceResolutionSetting.DoNotResolveReferences:
@@ -97,14 +97,14 @@ internal async Task<OpenApiDocument> ReadAsync(Stream input, OpenApiDiagnostic d
                     // Resolve references in documents
                     foreach (var item in workspace.Documents)
                     {
-                        ResolveReferences(item, true);
+                        item.ResolveReferences(true);
                     }
                     break;
                 case ReferenceResolutionSetting.ResolveLocalReferences:
                     // Resolve references in documents
                     foreach (var item in workspace.Documents)
                     {
-                        ResolveReferences(item,false);
+                        item.ResolveReferences(false);
                     }
                     break;
                 case
@@ -156,7 +156,6 @@ private void ValidateDocument(OpenApiDiagnostic diagnostic, OpenApiDocument docu
             } 
         }
 
-
         /// <summary>
         /// Helper method to turn streams into YamlDocument
         /// </summary>
@@ -173,13 +172,5 @@ internal static YamlDocument LoadYamlDocument(Stream input)
             }
             return yamlDocument;
         }
-
-        private static void ResolveReferences(OpenApiDocument document, bool includeRemote)
-        {
-            var resolver = new OpenApiReferenceResolver(document, includeRemote);
-            var walker = new OpenApiWalker(resolver);
-            walker.Walk(document);
-        }
-
     }
 }

src/Microsoft.OpenApi/Extensions/OpenApiElementExtensions.cs

@@ -27,5 +27,6 @@ public static IEnumerable<OpenApiError> Validate(this IOpenApiElement element, V
             walker.Walk(element);
             return validator.Errors;
         }
+
     }
 }

src/Microsoft.OpenApi/Models/OpenApiDocument.cs

@@ -271,6 +271,17 @@ private static void WriteHostInfoV2(IOpenApiWriter writer, IList<OpenApiServer>
             writer.WriteOptionalCollection(OpenApiConstants.Schemes, schemes, (w, s) => w.WriteValue(s));
         }
 
+        /// <summary>
+        /// Walk the OpenApiDocument and resolve unresolved references
+        /// </summary>
+        /// <param name="useExternal">Indicates if external references should be resolved.  Document needs to reference a workspace for this to be possible.</param>
+        public void ResolveReferences(bool useExternal = false)
+        {
+            var resolver = new OpenApiReferenceResolver(this, useExternal);
+            var walker = new OpenApiWalker(resolver);
+            walker.Walk(this);
+        }
+
         /// <summary>
         /// Load the referenced <see cref="IOpenApiReferenceable"/> object from a <see cref="OpenApiReference"/> object
         /// </summary>

src/Microsoft.OpenApi.Readers/Services/OpenApiReferenceResolver.cs renamed to src/Microsoft.OpenApi/Services/OpenApiReferenceResolver.cs

@@ -9,7 +9,7 @@
 using Microsoft.OpenApi.Models;
 using Microsoft.OpenApi.Services;
 
-namespace Microsoft.OpenApi.Readers.Services
+namespace Microsoft.OpenApi.Services
 {
     /// <summary>
     /// This class is used to walk an OpenApiDocument and convert unresolved references to references to populated objects

src/Microsoft.OpenApi/Services/OpenApiWorkspace.cs

@@ -18,12 +18,18 @@ public class OpenApiWorkspace
     {
         private Dictionary<string, OpenApiDocument> _documents = new Dictionary<string, OpenApiDocument>();
 
+        /// <summary>
+        /// A list of OpenApiDocuments contained in the workspace
+        /// </summary>
         public IEnumerable<OpenApiDocument> Documents {
             get {
                 return _documents.Values;
             }
         }  
 
+        /// <summary>
+        /// A list of document fragments that are contained in the workspace
+        /// </summary>
         public IEnumerable<IOpenApiFragment> Fragments { get; }