Clean up

Author: darrelmiller

src/Microsoft.OpenApi.Readers/ParsingContext.cs

@@ -22,14 +22,12 @@ namespace Microsoft.OpenApi.Readers
     public class ParsingContext
     {
         private readonly Stack<string> _currentLocation = new Stack<string>();
-
         private readonly Dictionary<string, object> _tempStorage = new Dictionary<string, object>();
         private IOpenApiVersionService _versionService;
         private readonly Dictionary<string, Stack<string>> _loopStacks = new Dictionary<string, Stack<string>>();        
         internal Dictionary<string, Func<IOpenApiAny, IOpenApiExtension>> ExtensionParsers { get; set; }  = new Dictionary<string, Func<IOpenApiAny, IOpenApiExtension>>();
         internal RootNode RootNode { get; set; }
         internal List<OpenApiTag> Tags { get; private set; } = new List<OpenApiTag>();
- 
 
         /// <summary>
         /// Initiates the parsing process.  Not thread safe and should only be called once on a parsing context

src/Microsoft.OpenApi.Readers/Services/OpenApiReferenceResolver.cs

@@ -44,7 +44,6 @@ public override void Visit(OpenApiComponents components)
             ResolveMap(components.SecuritySchemes);
         }
 
-
         public override void Visit(IDictionary<string, OpenApiCallback> callbacks)
         {
             ResolveMap(callbacks);
@@ -173,7 +172,6 @@ private void ResolveTags(IList<OpenApiTag> tags)
             }
         }
 
-
         private T ResolveReference<T>(OpenApiReference reference) where T : class, IOpenApiReferenceable, new()
         {
             if (string.IsNullOrEmpty(reference.ExternalResource))

src/Microsoft.OpenApi/Models/OpenApiDocument.cs

@@ -271,7 +271,6 @@ private static void WriteHostInfoV2(IOpenApiWriter writer, IList<OpenApiServer>
         /// </summary>
         public IOpenApiReferenceable ResolveReference(OpenApiReference reference)
         {
-
             if (reference == null)
             {
                 return null;
@@ -335,15 +334,12 @@ public IOpenApiReferenceable ResolveReference(OpenApiReference reference)
                         return this.Components.Callbacks[reference.Id];
 
                     default:
-                        // TODO: Create resource
-                        throw new OpenApiException("Invalid Reference type");
+                        throw new OpenApiException(Properties.SRResource.InvalidReferenceType);
                 }
             } catch(KeyNotFoundException)
             {
-                throw new OpenApiException("Invalid Reference id");
+                throw new OpenApiException(string.Format(Properties.SRResource.InvalidReferenceId,reference.Id));
             }
-
         }
-
     }
 }

src/Microsoft.OpenApi/Properties/SRResource.Designer.cs

@@ -132,6 +132,12 @@
   <data name="InputItemShouldBeType" xml:space="preserve">
     <value>The input item should be in type of '{0}'.</value>
   </data>
+  <data name="InvalidReferenceId" xml:space="preserve">
+    <value>Invalid Reference identifier '{0}'.</value>
+  </data>
+  <data name="InvalidReferenceType" xml:space="preserve">
+    <value>Invalid Reference Type.</value>
+  </data>
   <data name="ObjectScopeNeededForPropertyNameWriting" xml:space="preserve">
     <value>The active scope must be an object scope for property name '{0}' to be written.</value>
   </data>