Skip to content

Commit f5309ce

Browse files
authored
Merge pull request #1422 from SimonCropp/remove-redundant-CheckArguments
remove redundant CheckArguments
2 parents dcc1e83 + 428b9e4 commit f5309ce

File tree

1 file changed

+8
-23
lines changed

1 file changed

+8
-23
lines changed

src/Microsoft.OpenApi/Writers/OpenApiWriterExtensions.cs

Lines changed: 8 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ public static void WriteProperty(this IOpenApiWriter writer, string name, string
2727
return;
2828
}
2929

30-
CheckArguments(writer, name);
30+
Utils.CheckArgumentNullOrEmpty(name);
3131
writer.WritePropertyName(name);
3232
writer.WriteValue(value);
3333
}
@@ -40,7 +40,7 @@ public static void WriteProperty(this IOpenApiWriter writer, string name, string
4040
/// <param name="value">The property value.</param>
4141
public static void WriteRequiredProperty(this IOpenApiWriter writer, string name, string value)
4242
{
43-
CheckArguments(writer, name);
43+
Utils.CheckArgumentNullOrEmpty(name);
4444
writer.WritePropertyName(name);
4545
if (value == null)
4646
{
@@ -66,7 +66,7 @@ public static void WriteProperty(this IOpenApiWriter writer, string name, bool v
6666
return;
6767
}
6868

69-
CheckArguments(writer, name);
69+
Utils.CheckArgumentNullOrEmpty(name);
7070
writer.WritePropertyName(name);
7171
writer.WriteValue(value);
7272
}
@@ -89,7 +89,7 @@ public static void WriteProperty(
8989
return;
9090
}
9191

92-
CheckArguments(writer, name);
92+
Utils.CheckArgumentNullOrEmpty(name);
9393
writer.WritePropertyName(name);
9494
writer.WriteValue(value.Value);
9595
}
@@ -120,7 +120,7 @@ public static void WriteProperty<T>(this IOpenApiWriter writer, string name, T?
120120
public static void WriteProperty<T>(this IOpenApiWriter writer, string name, T value)
121121
where T : struct
122122
{
123-
CheckArguments(writer, name);
123+
Utils.CheckArgumentNullOrEmpty(name);
124124
writer.WritePropertyName(name);
125125
writer.WriteValue(value);
126126
}
@@ -166,7 +166,7 @@ public static void WriteRequiredObject<T>(
166166
Action<IOpenApiWriter, T> action)
167167
where T : IOpenApiElement
168168
{
169-
CheckArguments(writer, name, action);
169+
Utils.CheckArgumentNull(action);
170170

171171
writer.WritePropertyName(name);
172172
if (value != null)
@@ -339,7 +339,7 @@ private static void WriteCollectionInternal<T>(
339339
IEnumerable<T> elements,
340340
Action<IOpenApiWriter, T> action)
341341
{
342-
CheckArguments(writer, name, action);
342+
Utils.CheckArgumentNull(action);
343343

344344
writer.WritePropertyName(name);
345345
writer.WriteStartArray();
@@ -376,7 +376,7 @@ private static void WriteMapInternal<T>(
376376
IDictionary<string, T> elements,
377377
Action<IOpenApiWriter, string, T> action)
378378
{
379-
CheckArguments(writer, name, action);
379+
Utils.CheckArgumentNull(action);
380380

381381
writer.WritePropertyName(name);
382382
writer.WriteStartObject();
@@ -399,20 +399,5 @@ private static void WriteMapInternal<T>(
399399

400400
writer.WriteEndObject();
401401
}
402-
403-
private static void CheckArguments<T>(IOpenApiWriter writer, string name, Action<IOpenApiWriter, T> action)
404-
{
405-
Utils.CheckArgumentNull(action);
406-
}
407-
408-
private static void CheckArguments<T>(IOpenApiWriter writer, string name, Action<IOpenApiWriter, string, T> action)
409-
{
410-
Utils.CheckArgumentNull(action);
411-
}
412-
413-
private static void CheckArguments(IOpenApiWriter writer, string name)
414-
{
415-
Utils.CheckArgumentNullOrEmpty(name);
416-
}
417402
}
418403
}

0 commit comments

Comments
 (0)