From 512352277d0d909389deea25e98a7a7c08c4f61f Mon Sep 17 00:00:00 2001 From: martincostello Date: Sat, 12 Apr 2025 17:39:46 +0100 Subject: [PATCH 1/2] Use Convert.ToHexString Use `Convert.ToHexString()` when targeting .NET 8 instead of using a `StringBuilder`. --- src/Microsoft.OpenApi/Models/OpenApiDocument.cs | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/Microsoft.OpenApi/Models/OpenApiDocument.cs b/src/Microsoft.OpenApi/Models/OpenApiDocument.cs index 0f15a27d9..3913d75f8 100644 --- a/src/Microsoft.OpenApi/Models/OpenApiDocument.cs +++ b/src/Microsoft.OpenApi/Models/OpenApiDocument.cs @@ -544,6 +544,9 @@ private static string ConvertByteArrayToString(byte[] hash) { // Build the final string by converting each byte // into hex and appending it to a StringBuilder +#if NET + return Convert.ToHexString(hash); +#else var sb = new StringBuilder(); for (var i = 0; i < hash.Length; i++) { @@ -551,6 +554,7 @@ private static string ConvertByteArrayToString(byte[] hash) } return sb.ToString(); +#endif } /// From 33e20aa098b714946a29ead88ad1889d94d32350 Mon Sep 17 00:00:00 2001 From: Vincent Biret Date: Mon, 14 Apr 2025 08:27:47 -0400 Subject: [PATCH 2/2] Update src/Microsoft.OpenApi/Models/OpenApiDocument.cs --- src/Microsoft.OpenApi/Models/OpenApiDocument.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Microsoft.OpenApi/Models/OpenApiDocument.cs b/src/Microsoft.OpenApi/Models/OpenApiDocument.cs index 3913d75f8..42273f729 100644 --- a/src/Microsoft.OpenApi/Models/OpenApiDocument.cs +++ b/src/Microsoft.OpenApi/Models/OpenApiDocument.cs @@ -544,7 +544,7 @@ private static string ConvertByteArrayToString(byte[] hash) { // Build the final string by converting each byte // into hex and appending it to a StringBuilder -#if NET +#if NET5_0_OR_GREATER return Convert.ToHexString(hash); #else var sb = new StringBuilder();