Skip to content

Commit 53a2427

Browse files
msft-idomamsft-idoma
committed
Merged PR 621256: [Scanner Admin APIs][Bug Fix] change expression to string
change expression from ASMashupExpression to string to solve #210 Tests completed: ![image.png](https://dev.azure.com/powerbi/4c7b5adb-c2d0-4f18-b23c-edc4ac30f4e1/_apis/git/repositories/4f4b7330-5c73-4eb2-b9cb-d2f4c16debf7/pullRequests/621256/attachments/image.png) Related work items: #1507497
1 parent fddd78e commit 53a2427

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

41 files changed

+382
-595
lines changed

‎sdk/PowerBI.Api/Source/Admin.cs‎

Lines changed: 15 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -53,8 +53,7 @@ public Admin(PowerBIClient client)
5353
///
5454
/// ## Permissions
5555
///
56-
/// The user must have administrator rights (such as Office 365 Global
57-
/// Administrator or Power BI Service Administrator).
56+
/// The user must be a Fabric administrator.
5857
///
5958
/// ## Required Scope
6059
///
@@ -215,9 +214,8 @@ public Admin(PowerBIClient client)
215214
///
216215
/// ## Permissions
217216
///
218-
/// - The user must have administrator rights (such as Office 365 Global
219-
/// Administrator or Power BI Service Administrator) or authenticate using a
220-
/// service principal.
217+
/// - The user must be a Fabric administrator or authenticate using a service
218+
/// principal.
221219
/// - Delegated permissions are supported.
222220
///
223221
/// When running under service prinicipal authentication, an app **must not**
@@ -363,8 +361,7 @@ public Admin(PowerBIClient client)
363361
///
364362
/// ## Permissions
365363
///
366-
/// The user must have administrator rights (such as Office 365 Global
367-
/// Administrator or Power BI Service Administrator).
364+
/// The user must be a Fabric administrator.
368365
///
369366
/// ## Required Scope
370367
///
@@ -530,9 +527,8 @@ public Admin(PowerBIClient client)
530527
///
531528
/// ## Permissions
532529
///
533-
/// - The user must have administrator rights (such as Office 365 Global
534-
/// Administrator or Power BI Service Administrator) or authenticate using a
535-
/// service principal.
530+
/// - The user must be a Fabric administrator or authenticate using a service
531+
/// principal.
536532
/// - Delegated permissions are supported.
537533
///
538534
/// When running under service prinicipal authentication, an app **must not**
@@ -692,8 +688,7 @@ public Admin(PowerBIClient client)
692688
///
693689
/// ## Permissions
694690
///
695-
/// The user must have administrator rights (such as Office 365 Global
696-
/// Administrator or Power BI Service Administrator).
691+
/// The user must be a Fabric administrator.
697692
///
698693
/// ## Required Scope
699694
///
@@ -837,9 +832,8 @@ public Admin(PowerBIClient client)
837832
///
838833
/// ## Permissions
839834
///
840-
/// - The user must have administrator rights (such as Office 365 Global
841-
/// Administrator or Power BI Service Administrator) or authenticate using a
842-
/// service principal.
835+
/// - The user must be a Fabric administrator or authenticate using a service
836+
/// principal.
843837
/// - Delegated permissions are supported.
844838
///
845839
/// When running under service prinicipal authentication, an app **must not**
@@ -1031,9 +1025,8 @@ public Admin(PowerBIClient client)
10311025
///
10321026
/// ## Permissions
10331027
///
1034-
/// - The user must have administrator rights (such as Office 365 Global
1035-
/// Administrator or Power BI Service Administrator) or authenticate using a
1036-
/// service principal.
1028+
/// - The user must be a Fabric administrator or authenticate using a service
1029+
/// principal.
10371030
/// - Delegated permissions are supported.
10381031
///
10391032
/// When running under service prinicipal authentication, an app **must not**
@@ -1230,9 +1223,8 @@ public Admin(PowerBIClient client)
12301223
///
12311224
/// ## Permissions
12321225
///
1233-
/// - The user must have administrator rights (such as Office 365 Global
1234-
/// Administrator or Power BI Service Administrator) or authenticate using a
1235-
/// service principal.
1226+
/// - The user must be a Fabric administrator or authenticate using a service
1227+
/// principal.
12361228
/// - Delegated permissions are supported.
12371229
///
12381230
/// When running under service prinicipal authentication, an app **must not**
@@ -1416,9 +1408,8 @@ public Admin(PowerBIClient client)
14161408
///
14171409
/// ## Permissions
14181410
///
1419-
/// - The user must have administrator rights (such as Office 365 Global
1420-
/// Administrator or Power BI Service Administrator) or authenticate using a
1421-
/// service principal.
1411+
/// - The user must be a Fabric administrator or authenticate using a service
1412+
/// principal.
14221413
/// - Delegated permissions are supported.
14231414
///
14241415
/// When running under service prinicipal authentication, an app **must not**

‎sdk/PowerBI.Api/Source/AdminExtensions.cs‎

Lines changed: 30 additions & 48 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,7 @@ public static partial class AdminExtensions
2222
///
2323
/// ## Permissions
2424
///
25-
/// The user must have administrator rights (such as Office 365 Global
26-
/// Administrator or Power BI Service Administrator).
25+
/// The user must be a Fabric administrator.
2726
///
2827
/// ## Required Scope
2928
///
@@ -52,8 +51,7 @@ public static TenantKey AddPowerBIEncryptionKey(this IAdmin operations, TenantKe
5251
///
5352
/// ## Permissions
5453
///
55-
/// The user must have administrator rights (such as Office 365 Global
56-
/// Administrator or Power BI Service Administrator).
54+
/// The user must be a Fabric administrator.
5755
///
5856
/// ## Required Scope
5957
///
@@ -88,9 +86,8 @@ public static TenantKey AddPowerBIEncryptionKey(this IAdmin operations, TenantKe
8886
///
8987
/// ## Permissions
9088
///
91-
/// - The user must have administrator rights (such as Office 365 Global
92-
/// Administrator or Power BI Service Administrator) or authenticate using a
93-
/// service principal.
89+
/// - The user must be a Fabric administrator or authenticate using a service
90+
/// principal.
9491
/// - Delegated permissions are supported.
9592
///
9693
/// When running under service prinicipal authentication, an app **must not**
@@ -121,9 +118,8 @@ public static TenantKeys GetPowerBIEncryptionKeys(this IAdmin operations)
121118
///
122119
/// ## Permissions
123120
///
124-
/// - The user must have administrator rights (such as Office 365 Global
125-
/// Administrator or Power BI Service Administrator) or authenticate using a
126-
/// service principal.
121+
/// - The user must be a Fabric administrator or authenticate using a service
122+
/// principal.
127123
/// - Delegated permissions are supported.
128124
///
129125
/// When running under service prinicipal authentication, an app **must not**
@@ -160,8 +156,7 @@ public static TenantKeys GetPowerBIEncryptionKeys(this IAdmin operations)
160156
///
161157
/// ## Permissions
162158
///
163-
/// The user must have administrator rights (such as Office 365 Global
164-
/// Administrator or Power BI Service Administrator).
159+
/// The user must be a Fabric administrator.
165160
///
166161
/// ## Required Scope
167162
///
@@ -193,8 +188,7 @@ public static TenantKey RotatePowerBIEncryptionKey(this IAdmin operations, Syste
193188
///
194189
/// ## Permissions
195190
///
196-
/// The user must have administrator rights (such as Office 365 Global
197-
/// Administrator or Power BI Service Administrator).
191+
/// The user must be a Fabric administrator.
198192
///
199193
/// ## Required Scope
200194
///
@@ -232,9 +226,8 @@ public static TenantKey RotatePowerBIEncryptionKey(this IAdmin operations, Syste
232226
///
233227
/// ## Permissions
234228
///
235-
/// - The user must have administrator rights (such as Office 365 Global
236-
/// Administrator or Power BI Service Administrator) or authenticate using a
237-
/// service principal.
229+
/// - The user must be a Fabric administrator or authenticate using a service
230+
/// principal.
238231
/// - Delegated permissions are supported.
239232
///
240233
/// When running under service prinicipal authentication, an app **must not**
@@ -268,9 +261,8 @@ public static TenantKey RotatePowerBIEncryptionKey(this IAdmin operations, Syste
268261
///
269262
/// ## Permissions
270263
///
271-
/// - The user must have administrator rights (such as Office 365 Global
272-
/// Administrator or Power BI Service Administrator) or authenticate using a
273-
/// service principal.
264+
/// - The user must be a Fabric administrator or authenticate using a service
265+
/// principal.
274266
/// - Delegated permissions are supported.
275267
///
276268
/// When running under service prinicipal authentication, an app **must not**
@@ -311,8 +303,7 @@ public static TenantKey RotatePowerBIEncryptionKey(this IAdmin operations, Syste
311303
///
312304
/// ## Permissions
313305
///
314-
/// The user must have administrator rights (such as Office 365 Global
315-
/// Administrator or Power BI Service Administrator).
306+
/// The user must be a Fabric administrator.
316307
///
317308
/// ## Required Scope
318309
///
@@ -341,8 +332,7 @@ public static void PatchCapacityAsAdmin(this IAdmin operations, System.Guid capa
341332
///
342333
/// ## Permissions
343334
///
344-
/// The user must have administrator rights (such as Office 365 Global
345-
/// Administrator or Power BI Service Administrator).
335+
/// The user must be a Fabric administrator.
346336
///
347337
/// ## Required Scope
348338
///
@@ -376,9 +366,8 @@ public static void PatchCapacityAsAdmin(this IAdmin operations, System.Guid capa
376366
///
377367
/// ## Permissions
378368
///
379-
/// - The user must have administrator rights (such as Office 365 Global
380-
/// Administrator or Power BI Service Administrator) or authenticate using a
381-
/// service principal.
369+
/// - The user must be a Fabric administrator or authenticate using a service
370+
/// principal.
382371
/// - Delegated permissions are supported.
383372
///
384373
/// When running under service prinicipal authentication, an app **must not**
@@ -428,9 +417,8 @@ public static void PatchCapacityAsAdmin(this IAdmin operations, System.Guid capa
428417
///
429418
/// ## Permissions
430419
///
431-
/// - The user must have administrator rights (such as Office 365 Global
432-
/// Administrator or Power BI Service Administrator) or authenticate using a
433-
/// service principal.
420+
/// - The user must be a Fabric administrator or authenticate using a service
421+
/// principal.
434422
/// - Delegated permissions are supported.
435423
///
436424
/// When running under service prinicipal authentication, an app **must not**
@@ -487,9 +475,8 @@ public static void PatchCapacityAsAdmin(this IAdmin operations, System.Guid capa
487475
///
488476
/// ## Permissions
489477
///
490-
/// - The user must have administrator rights (such as Office 365 Global
491-
/// Administrator or Power BI Service Administrator) or authenticate using a
492-
/// service principal.
478+
/// - The user must be a Fabric administrator or authenticate using a service
479+
/// principal.
493480
/// - Delegated permissions are supported.
494481
///
495482
/// When running under service prinicipal authentication, an app **must not**
@@ -543,9 +530,8 @@ public static void PatchCapacityAsAdmin(this IAdmin operations, System.Guid capa
543530
///
544531
/// ## Permissions
545532
///
546-
/// - The user must have administrator rights (such as Office 365 Global
547-
/// Administrator or Power BI Service Administrator) or authenticate using a
548-
/// service principal.
533+
/// - The user must be a Fabric administrator or authenticate using a service
534+
/// principal.
549535
/// - Delegated permissions are supported.
550536
///
551537
/// When running under service prinicipal authentication, an app **must not**
@@ -605,9 +591,8 @@ public static void PatchCapacityAsAdmin(this IAdmin operations, System.Guid capa
605591
///
606592
/// ## Permissions
607593
///
608-
/// - The user must have administrator rights (such as Office 365 Global
609-
/// Administrator or Power BI Service Administrator) or authenticate using a
610-
/// service principal.
594+
/// - The user must be a Fabric administrator or authenticate using a service
595+
/// principal.
611596
/// - Delegated permissions are supported.
612597
///
613598
/// When running under service prinicipal authentication, an app **must not**
@@ -652,9 +637,8 @@ public static void PatchCapacityAsAdmin(this IAdmin operations, System.Guid capa
652637
///
653638
/// ## Permissions
654639
///
655-
/// - The user must have administrator rights (such as Office 365 Global
656-
/// Administrator or Power BI Service Administrator) or authenticate using a
657-
/// service principal.
640+
/// - The user must be a Fabric administrator or authenticate using a service
641+
/// principal.
658642
/// - Delegated permissions are supported.
659643
///
660644
/// When running under service prinicipal authentication, an app **must not**
@@ -705,9 +689,8 @@ public static void PatchCapacityAsAdmin(this IAdmin operations, System.Guid capa
705689
///
706690
/// ## Permissions
707691
///
708-
/// - The user must have administrator rights (such as Office 365 Global
709-
/// Administrator or Power BI Service Administrator) or authenticate using a
710-
/// service principal.
692+
/// - The user must be a Fabric administrator or authenticate using a service
693+
/// principal.
711694
/// - Delegated permissions are supported.
712695
///
713696
/// When running under service prinicipal authentication, an app **must not**
@@ -762,9 +745,8 @@ public static void PatchCapacityAsAdmin(this IAdmin operations, System.Guid capa
762745
///
763746
/// ## Permissions
764747
///
765-
/// - The user must have administrator rights (such as Office 365 Global
766-
/// Administrator or Power BI Service Administrator) or authenticate using a
767-
/// service principal.
748+
/// - The user must be a Fabric administrator or authenticate using a service
749+
/// principal.
768750
/// - Delegated permissions are supported.
769751
///
770752
/// When running under service prinicipal authentication, an app **must not**

‎sdk/PowerBI.Api/Source/AppsOperations.cs‎

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1216,9 +1216,8 @@ public AppsOperations(PowerBIClient client)
12161216
///
12171217
/// ## Permissions
12181218
///
1219-
/// - The user must have administrator rights (such as Office 365 Global
1220-
/// Administrator or Power BI Service Administrator) or authenticate using a
1221-
/// service principal.
1219+
/// - The user must be a Fabric administrator or authenticate using a service
1220+
/// principal.
12221221
/// - Delegated permissions are supported.
12231222
///
12241223
/// When running under service prinicipal authentication, an app **must not**
@@ -1394,9 +1393,8 @@ public AppsOperations(PowerBIClient client)
13941393
///
13951394
/// ## Permissions
13961395
///
1397-
/// - The user must have administrator rights (such as Office 365 Global
1398-
/// Administrator or Power BI Service Administrator) or authenticate using a
1399-
/// service principal.
1396+
/// - The user must be a Fabric administrator or authenticate using a service
1397+
/// principal.
14001398
/// - Delegated permissions are supported.
14011399
///
14021400
/// When running under service prinicipal authentication, an app **must not**

‎sdk/PowerBI.Api/Source/AppsOperationsExtensions.cs‎

Lines changed: 8 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -506,9 +506,8 @@ public static Tile GetTile(this IAppsOperations operations, System.Guid appId, S
506506
///
507507
/// ## Permissions
508508
///
509-
/// - The user must have administrator rights (such as Office 365 Global
510-
/// Administrator or Power BI Service Administrator) or authenticate using a
511-
/// service principal.
509+
/// - The user must be a Fabric administrator or authenticate using a service
510+
/// principal.
512511
/// - Delegated permissions are supported.
513512
///
514513
/// When running under service prinicipal authentication, an app **must not**
@@ -551,9 +550,8 @@ public static Tile GetTile(this IAppsOperations operations, System.Guid appId, S
551550
///
552551
/// ## Permissions
553552
///
554-
/// - The user must have administrator rights (such as Office 365 Global
555-
/// Administrator or Power BI Service Administrator) or authenticate using a
556-
/// service principal.
553+
/// - The user must be a Fabric administrator or authenticate using a service
554+
/// principal.
557555
/// - Delegated permissions are supported.
558556
///
559557
/// When running under service prinicipal authentication, an app **must not**
@@ -600,9 +598,8 @@ public static Tile GetTile(this IAppsOperations operations, System.Guid appId, S
600598
///
601599
/// ## Permissions
602600
///
603-
/// - The user must have administrator rights (such as Office 365 Global
604-
/// Administrator or Power BI Service Administrator) or authenticate using a
605-
/// service principal.
601+
/// - The user must be a Fabric administrator or authenticate using a service
602+
/// principal.
606603
/// - Delegated permissions are supported.
607604
///
608605
/// When running under service prinicipal authentication, an app **must not**
@@ -640,9 +637,8 @@ public static AppUsers GetAppUsersAsAdmin(this IAppsOperations operations, Syste
640637
///
641638
/// ## Permissions
642639
///
643-
/// - The user must have administrator rights (such as Office 365 Global
644-
/// Administrator or Power BI Service Administrator) or authenticate using a
645-
/// service principal.
640+
/// - The user must be a Fabric administrator or authenticate using a service
641+
/// principal.
646642
/// - Delegated permissions are supported.
647643
///
648644
/// When running under service prinicipal authentication, an app **must not**

0 commit comments

Comments
 (0)