Skip to content

Commit 5703295

Browse files
committed
Fix static analysis misses with new Fork featurework
1 parent 1076239 commit 5703295

File tree

3 files changed

+18
-6
lines changed

3 files changed

+18
-6
lines changed

CHANGELOG.md

Lines changed: 15 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,33 @@
11
# PowerShellForGitHub PowerShell Module
22
## Changelog
33

4-
## [0.0.2](https://github.com/PowerShell/PowerShellForGitHub/tree/0.3.0) - (2018/11/13)
4+
## [0.3.1](https://github.com/PowerShell/PowerShellForGitHub/tree/0.3.1) - (2018/11/13)
5+
### Fixes:
6+
* Minor static analysis issues fixed.
7+
* Corrected name of the test file for `GitHubRepositoryForks`
8+
* Ensured the `getParams` are used during execution of `Get-GitHubRepositoryFork`
9+
10+
More Info: [[pr]](https://github.com/PowerShell/PowerShellForGitHub/pull/42) | [[cl]](https://github.com/PowerShell/PowerHellForGitHub/commit/TODO)
11+
12+
Author: [**@HowardWolosky**](https://github.com/HowardWolosky)
13+
14+
------
15+
16+
## [0.3.0](https://github.com/PowerShell/PowerShellForGitHub/tree/0.3.0) - (2018/11/13)
517
### Features:
618
+ Added support for querying forks and creating new ones.
719

820
### Fixes:
921
* Will only perform a retry when receiving a `202` response on a `GET` request. Previously, it would
1022
retry regardless of the method of the request.
1123

12-
More Info: [[pr]](https://github.com/PowerShell/PowerShellForGitHub/pull/41) | [[cl]](https://github.com/PowerShell/PowerHellForGitHub/commit/TODO)
24+
More Info: [[pr]](https://github.com/PowerShell/PowerShellForGitHub/pull/41) | [[cl]](https://github.com/PowerShell/PowerHellForGitHub/commit/1076239d7639497984a6e0b04df1e69019c4ec28)
1325

1426
Author: [**@HowardWolosky**](https://github.com/HowardWolosky)
1527

1628
------
1729

18-
## [0.0.2](https://github.com/PowerShell/PowerShellForGitHub/tree/0.2.0) - (2018/11/13)
30+
## [0.2.0](https://github.com/PowerShell/PowerShellForGitHub/tree/0.2.0) - (2018/11/13)
1931
### Features:
2032
+ Significant restructing and refactoring of entire module to make future expansion easier.
2133
+ Significant documentation updates ([CHANGELOG](./CHANGELOG.md), [CONTRIBUTING.md](./CONTRIBUTING.md),

GitHubRepositoryForks.ps1

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ function Get-GitHubRepositoryFork
8484
)
8585

8686
$params = @{
87-
'UriFragment' = "repos/$OwnerName/$RepositoryName/forks"
87+
'UriFragment' = "repos/$OwnerName/$RepositoryName/forks`?" + ($getParams -join '&')
8888
'Description' = "Getting all forks of $RepositoryName"
8989
'AccessToken' = $AccessToken
9090
'TelemetryEventName' = $MyInvocation.MyCommand.Name

Tests/GitHubRepositoryForks.ps1 renamed to Tests/GitHubRepositoryForks.tests.ps1

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ Describe 'Creating a new fork for user' {
8888
$newForks[0].full_name | Should be "$($script:ownerName)/PowerShellForGitHub"
8989
}
9090

91-
Remove-GitHubRepository -OwnerName $script:ownerName -RepositoryName PowerShellForGitHub
91+
Remove-GitHubRepository -Uri $repo.svn_url
9292
}
9393
}
9494

@@ -107,7 +107,7 @@ Describe 'Creating a new fork for an org' {
107107
$newForks[0].full_name | Should be "$($script:organizationName)/PowerShellForGitHub"
108108
}
109109

110-
Remove-GitHubRepository -OwnerName $script:organizationName -RepositoryName PowerShellForGitHub
110+
Remove-GitHubRepository -Uri $repo.svn_url
111111
}
112112
}
113113

0 commit comments

Comments
 (0)