Skip to content

Commit cd449a1

Browse files
Remove AppVeyor references from docs and code (#152)
1 parent abe88ae commit cd449a1

File tree

2 files changed

+13
-12
lines changed

2 files changed

+13
-12
lines changed

CONTRIBUTING.md

Lines changed: 12 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -352,19 +352,20 @@ There are many more nuances to code-coverage, see
352352
[![Build status](https://dev.azure.com/ms/PowerShellForGitHub/_apis/build/status/PowerShellForGitHub-CI?branchName=master)](https://dev.azure.com/ms/PowerShellForGitHub/_build/latest?definitionId=109&branchName=master)
353353

354354
These test are configured to automatically execute upon any update to the `master` branch
355-
on the `HowardWolosky` fork of `PowerShellForGitHub`. (At this time, we don't have the proper
356-
permissions to have AppVeyor execute the tests on the main instance.) This setup thus depends
357-
on the `HowardWolosky` fork always being kept up-to-date with the `PowerShell` master.
358-
359-
The [AppVeyor project](https://ci.appveyor.com/project/HowardWolosky/powershellforgithub) has
360-
been [configured](./appveyor.yml) to execute the tests against a test GitHub account (for the user
361-
`PowerShellForGitHubTeam`, and the org `PowerShellForGitHubTeamTestOrg`).
362-
363-
Additionally, the Access Token with administrator access for that account has been encrypted on
364-
AppVeyor and mentioned in the [config file](./appveyor.yml). That Access Token is not accessible
365-
by anyone else. To run the tests locally with your own account, see
355+
of `microsoft/PowerShellForGitHub`.
356+
357+
The [Azure DevOps pipeline](https://dev.azure.com/ms/PowerShellForGitHub/_build?definitionId=109&_a=summary)
358+
has been [configured](https://github.com/microsoft/PowerShellForGitHub/blob/master/build/pipelines/templates/run-unitTests.yaml#L25-L28)
359+
to execute the tests against a test GitHub account (for the user `PowerShellForGitHubTeam`,
360+
and the org `PowerShellForGitHubTeamTestOrg`). You will see the AccessToken being referenced there
361+
as well...it is stored, encryted, within Azure DevOps. It is not accessible for use outside of
362+
the CI pipeline. To run the tests locally with your own account, see
366363
[configuring-your-environment](#configuring-your-environment).
367364

365+
> NOTE: We're currently encountering issues with the tests successfully running within the pipeline.
366+
> They do complete successfully locally, so please test your changes locally before submitting a
367+
> pull request.
368+
368369
#### New Test Guidelines
369370
Your tests should have NO dependencies on an account being set up in a specific way. They should
370371
get the configured account set up in the appropriate state that it can then test/verify. In this

Tests/Common.ps1

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ function Initialize-CommonTestSetup
2929
This method is invoked immediately after the declaration.
3030
#>
3131
[CmdletBinding()]
32-
[Diagnostics.CodeAnalysis.SuppressMessageAttribute("PSAvoidUsingConvertToSecureStringWithPlainText", "", Justification="Needed to configure with the stored, encrypted string value in AppVeyor.")]
32+
[Diagnostics.CodeAnalysis.SuppressMessageAttribute("PSAvoidUsingConvertToSecureStringWithPlainText", "", Justification="Needed to configure with the stored, encrypted string value in Azure DevOps.")]
3333
param()
3434

3535
$moduleRootPath = Split-Path -Path $PSScriptRoot -Parent

0 commit comments

Comments
 (0)