Toolset update: MSVC Compiler 19.50 Preview 1, Clang 20 (#5717)

Author: StephanTLavavej

.clang-format

@@ -1,7 +1,7 @@
 # Copyright (c) Microsoft Corporation.
 # SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 
-# https://releases.llvm.org/19.1.0/tools/clang/docs/ClangFormatStyleOptions.html
+# https://releases.llvm.org/20.1.0/tools/clang/docs/ClangFormatStyleOptions.html
 
 # To update this .clang-format file for a new clang-format version:
 # 1. Update the documentation link above.
@@ -26,6 +26,7 @@ AlignAfterOpenBracket: DontAlign
 #   AcrossEmptyLines: false
 #   AcrossComments:  false
 #   AlignCompound:   false
+#   AlignFunctionDeclarations: false
 #   AlignFunctionPointers: false
 #   PadOperators:    true
 AlignConsecutiveAssignments: Consecutive
@@ -34,20 +35,23 @@ AlignConsecutiveAssignments: Consecutive
 #   AcrossEmptyLines: false
 #   AcrossComments:  false
 #   AlignCompound:   false
+#   AlignFunctionDeclarations: false
 #   AlignFunctionPointers: false
 #   PadOperators:    false
 # AlignConsecutiveDeclarations:
 #   Enabled:         false
 #   AcrossEmptyLines: false
 #   AcrossComments:  false
 #   AlignCompound:   false
+#   AlignFunctionDeclarations: true
 #   AlignFunctionPointers: false
 #   PadOperators:    false
 # AlignConsecutiveMacros:
 #   Enabled:         false
 #   AcrossEmptyLines: false
 #   AcrossComments:  false
 #   AlignCompound:   false
+#   AlignFunctionDeclarations: false
 #   AlignFunctionPointers: false
 #   PadOperators:    false
 AlignConsecutiveMacros: Consecutive
@@ -62,20 +66,23 @@ AlignConsecutiveMacros: Consecutive
 #   AcrossEmptyLines: false
 #   AcrossComments:  false
 #   AlignCompound:   false
+#   AlignFunctionDeclarations: false
 #   AlignFunctionPointers: false
 #   PadOperators:    false
 # AlignConsecutiveTableGenCondOperatorColons:
 #   Enabled:         false
 #   AcrossEmptyLines: false
 #   AcrossComments:  false
 #   AlignCompound:   false
+#   AlignFunctionDeclarations: false
 #   AlignFunctionPointers: false
 #   PadOperators:    false
 # AlignConsecutiveTableGenDefinitionColons:
 #   Enabled:         false
 #   AcrossEmptyLines: false
 #   AcrossComments:  false
 #   AlignCompound:   false
+#   AlignFunctionDeclarations: false
 #   AlignFunctionPointers: false
 #   PadOperators:    false
 # AlignEscapedNewlines: Right
@@ -101,12 +108,13 @@ AllowShortFunctionsOnASingleLine: Empty
 # AllowShortIfStatementsOnASingleLine: Never
 # AllowShortLambdasOnASingleLine: All
 # AllowShortLoopsOnASingleLine: false
+# AllowShortNamespacesOnASingleLine: false
 # AlwaysBreakAfterDefinitionReturnType: None
 # AlwaysBreakBeforeMultilineStrings: false
 # AttributeMacros:
 #   - __capability
 # BinPackArguments: true
-# BinPackParameters: true
+# BinPackParameters: BinPack
 # BitFieldColonSpacing: Both
 # BraceWrapping:
 #   AfterCaseLabel:  false
@@ -139,6 +147,7 @@ BreakBeforeBinaryOperators: NonAssignment
 # BreakBeforeBraces: Attach
 # BreakBeforeInlineASMColon: OnlyMultiline
 # BreakBeforeTernaryOperators: true
+# BreakBinaryOperations: Never
 # BreakConstructorInitializers: BeforeColon
 # BreakFunctionDefinitionParameters: false
 # BreakInheritanceList: BeforeColon
@@ -203,6 +212,7 @@ IncludeCategories:
 # IndentCaseBlocks: false
 IndentCaseBlocks: true
 # IndentCaseLabels: false
+# IndentExportBlock: true
 # IndentExternBlock: AfterExternBlock
 # IndentGotoLabels: true
 # IndentPPDirectives: None
@@ -231,6 +241,7 @@ InsertNewlineAtEOF: true
 #   AtStartOfFile:   true
 KeepEmptyLines:
   AtStartOfFile:   false
+# KeepFormFeed:    false
 # LambdaBodyIndentation: Signature
 # LineEnding:      DeriveLF
 LineEnding:      CRLF
@@ -250,6 +261,7 @@ NamespaceIndentation: All
 # PackConstructorInitializers: BinPack
 # PenaltyBreakAssignment: 2
 # PenaltyBreakBeforeFirstCallParameter: 19
+# PenaltyBreakBeforeMemberAccess: 150
 # PenaltyBreakComment: 300
 # PenaltyBreakFirstLessLess: 120
 # PenaltyBreakOpenParenthesis: 0
@@ -264,8 +276,9 @@ PointerAlignment: Left
 # PPIndentWidth:   -1
 # QualifierAlignment: Leave
 # ReferenceAlignment: Pointer
-# ReflowComments:  true
+# ReflowComments:  Always
 # RemoveBracesLLVM: false
+# RemoveEmptyLinesInUnwrappedLines: false
 # RemoveParentheses: Leave
 # RemoveSemicolon: false
 RemoveSemicolon: true
@@ -349,4 +362,5 @@ StatementMacros:
 #   - NS_SWIFT_NAME
 #   - PP_STRINGIZE
 #   - STRINGIZE
+# WrapNamespaceBodyWithEmptyLines: Leave
 ...

.github/ISSUE_TEMPLATE/bug-report.md

@@ -53,17 +53,32 @@ Alternatively, include `static_assert` or `assert` lines in your
 test case above whose failure clearly indicates the problem.
 
 # STL version
-* Option 1: Visual Studio version
-  + Help > About Microsoft Visual Studio > Copy Info, we need only the first two lines
+* Option 1: MSVC Compiler version
   + Example:
     ```
-    Microsoft Visual Studio Community 2022
-    Version 17.6.0 Preview 3.0
+    C:\Temp>cl.exe
+    Microsoft (R) C/C++ Optimizing Compiler Version 19.50.35503 for x64
+    Copyright (C) Microsoft Corporation.  All rights reserved.
+
+    usage: cl [ option... ] filename... [ /link linkoption... ]
+    ```
+* Option 2: `_MSVC_STL_UPDATE` value
+  + Example:
+    ```
+    C:\Temp>type meow.cpp
+    #include <iostream>
+    int main() {
+        std::cout << _MSVC_STL_UPDATE << "\n";
+    }
+
+    C:\Temp>cl /EHsc /nologo /W4 meow.cpp && meow
+    meow.cpp
+    202507
     ```
-* Option 2: git commit hash
+* Option 3: git commit hash
   + Example:
     ```
-    https://github.com/microsoft/STL/commit/2195148
+    https://github.com/microsoft/STL/commit/219514876ea86491de191ceaa88632616bbc0f19
     ```
 
 # Additional context

CMakeLists.txt

@@ -6,8 +6,8 @@ cmake_minimum_required(VERSION 3.31.0)
 set(CMAKE_TRY_COMPILE_TARGET_TYPE STATIC_LIBRARY)
 project(msvc_standard_libraries LANGUAGES CXX)
 
-if(CMAKE_CXX_COMPILER_VERSION VERSION_LESS "19.44.35214")
-    message(FATAL_ERROR "The STL must be built with VS 2022 17.14.12 Preview 1 or later.")
+if(CMAKE_CXX_COMPILER_VERSION VERSION_LESS "19.50.35503")
+    message(FATAL_ERROR "The STL must be built with MSVC Compiler 19.50 Preview 1 or later.")
 endif()
 
 include(CheckCXXSourceCompiles)
@@ -18,7 +18,7 @@ int main() {}
 ]=] WINDOWS_SDK_VERSION_CHECK)
 
 if(NOT WINDOWS_SDK_VERSION_CHECK)
-    message(FATAL_ERROR "The STL must be built with the Windows 11 SDK (10.0.26100.4188) or later. Make sure it's available by selecting it in the Individual Components tab of the VS Installer.")
+    message(FATAL_ERROR "The STL must be built with the Windows 11 SDK (10.0.26100) or later. Make sure it's available by selecting it in the Individual Components tab of the VS Installer.")
 endif()
 
 if(NOT DEFINED VCLIBS_TARGET_ARCHITECTURE)
@@ -97,13 +97,13 @@ add_compile_definitions(
     _WIN32_WINNT=0x0A00 NTDDI_VERSION=NTDDI_WIN11_GE)
 
 if(STL_USE_ANALYZE)
-    # TRANSITION, Windows SDK 10.0.26100.4188 emits
+    # TRANSITION, Windows SDK 10.0.26100 emits
     # "warning C6553: The annotation for function 'LCMapStringEx' on _Param_(9) does not apply to a value type."
     # Reported as OS-40109504 "Windows SDK: incorrect SAL annotations on functions the STL uses".
     add_compile_options("$<$<COMPILE_LANGUAGE:CXX>:/analyze:autolog-;/wd6553>")
 
     if(VCLIBS_TARGET_ARCHITECTURE STREQUAL "arm64ec")
-        # TRANSITION, Windows SDK 10.0.26100.4188 emits
+        # TRANSITION, Windows SDK 10.0.26100 emits
         # "warning C28301: No annotations for first declaration of 'meow'"
         # for various intrinsics when building for ARM64EC.
         add_compile_options("$<$<COMPILE_LANGUAGE:CXX>:/wd28301>")

CMakePresets.json

@@ -13,35 +13,35 @@
       "binaryDir": "${sourceDir}/out/${presetName}"
     },
     {
-      "name": "x86",
+      "name": "x64",
       "inherits": "base",
-      "description": "x86 Ninja Config",
+      "description": "x64 Ninja Config",
       "architecture": {
         "strategy": "external",
-        "value": "x86"
+        "value": "x64"
       },
       "condition": {
         "type": "inList",
         "string": "$env{Platform}",
         "list": [
-          "x86",
+          "x64",
           ""
         ]
       }
     },
     {
-      "name": "x64",
+      "name": "x86",
       "inherits": "base",
-      "description": "x64 Ninja Config",
+      "description": "x86 Ninja Config",
       "architecture": {
         "strategy": "external",
-        "value": "x64"
+        "value": "x86"
       },
       "condition": {
         "type": "inList",
         "string": "$env{Platform}",
         "list": [
-          "x64",
+          "x86",
           ""
         ]
       }
@@ -89,16 +89,16 @@
     }
   ],
   "buildPresets": [
-    {
-      "name": "x86",
-      "configurePreset": "x86",
-      "description": "Build x86 STL"
-    },
     {
       "name": "x64",
       "configurePreset": "x64",
       "description": "Build x64 STL"
     },
+    {
+      "name": "x86",
+      "configurePreset": "x86",
+      "description": "Build x86 STL"
+    },
     {
       "name": "ARM64",
       "configurePreset": "ARM64",