fix how to extract property from vfp port state (#541)

This pull request updates the logic for parsing VFP port state
properties in `Get-SdnVfpPortState` to better handle properties that are
output without explicit key/value pairs, and adds support for the
`SriovEnabled` property in the `VfpPortState` class. The main changes
focus on improving how enabled features are detected and mapped to the
state object.

**Enhancements to VFP Port State Parsing:**

* Updated the parsing logic in `Get-SdnVfpPortState` to handle lines
that only contain a property name (without a value), assuming these
properties are enabled by default when present in the output. This
ensures properties like "SR-IOV Enabled" and various offload features
are correctly set to `$true` when detected.

* Moved the mapping of several port state and offload properties (such
as "DTLS Offload Enabled", "GFT Offload Enabled", and various
NVGRE/VXLAN offload features) from the key/value parsing block to the
new single-property-line parsing block, improving robustness and
accuracy.
[[1]](diffhunk://#diff-11217f20b55d3b4ea34c8c217794c81d65acc4852dff9bf4295e5cc4d6dfaeedL2231-L2250)
[[2]](diffhunk://#diff-11217f20b55d3b4ea34c8c217794c81d65acc4852dff9bf4295e5cc4d6dfaeedL2265-R2280)

**VfpPortState Class Update:**

* Added a new `[boolean]$SriovEnabled` property to the `VfpPortState`
class to track the SR-IOV enablement state.

# Change type
- [x] Bug fix (non-breaking change)
- [ ] Code style update (formatting, local variables)
- [ ] New Feature (non-breaking change that adds new functionality
without impacting existing)
- [ ] Breaking change (fix or feature that may cause functionality
impact)
- [ ] Other

# Checklist:
- [x] My code follows the style and contribution guidelines of this
project.
- [x] I have tested and validated my code changes.

Author: arudell

src/modules/SdnDiag.Server.psm1

@@ -163,6 +163,7 @@ class VfpPortState {
     [boolean]$PreserveVlan
     [boolean]$IsVmContextSet
     [boolean]$VmqEnabled
+    [boolean]$SriovEnabled
     $OffloadState = [OffLoadStateDetails]::new()
     [boolean]$QosHardwareReservationsEnabled
     [boolean]$QosHardwareCapsEnabled
@@ -2228,26 +2229,9 @@ function Get-SdnVfpPortState {
                     'Blocked' { $object.Blocked = $propertyValue }
                     'BlockedOnRestore' { $object.BlockOnRestore = $propertyValue }
                     'BlockedLayerCreation' { $object.BlockLayerCreation = $propertyValue }
-                    'DTLS Offload Enabled' { $object.DtlsOffloadEnabled = $propertyValue }
-                    'GFT Offload Enabled' { $object.GftOffloadEnabled = $propertyValue }
-                    'QoS Hardware Transmit Cap Offload Enabled' { $object.QosHardwareCapsEnabled = $propertyValue }
-                    'QoS Hardware Transmit Reservation Offload Enabled' { $object.QosHardwareReservationsEnabled = $propertyValue }
                     'Preserving Vlan' { $object.PreserveVlan = $propertyValue }
                     'VM Context Set' { $object.IsVmContextSet = $propertyValue }
 
-                    # update the OffLoadStateDetails properties
-                    'NVGRE LSO Offload Enabled' { $object.OffloadState.LsoV2Supported = $propertyValue}
-                    'NVGRE RSS Enabled' { $object.OffloadState.RssSupported = $propertyValue }
-                    'NVGRE Transmit Checksum Offload Enabled' { $object.OffloadState.TransmitChecksumOffloadSupported = $propertyValue }
-                    'NVGRE Receive Checksum Offload Enabled' { $object.OffloadState.ReceiveChecksumOffloadSupported = $propertyValue }
-                    'NVGRE VMQ Enabled' { $object.OffloadState.VmqSupported = $propertyValue }
-                    'VXLAN LSO Offload Enabled' { $object.OffloadState.LsoV2SupportedVxlan = $propertyValue }
-                    'VXLAN RSS Enabled' { $object.OffloadState.RssSupportedVxlan = $propertyValue }
-                    'VXLAN Transmit Checksum Offload Enabled' { $object.OffloadState.TransmitChecksumOffloadSupportedVxlan = $propertyValue }
-                    'VXLAN Receive Checksum Offload Enabled' { $object.OffloadState.ReceiveChecksumOffloadSupportedVxlan = $propertyValue }
-                    'VXLAN VMQ Enabled' { $object.OffloadState.VmqSupportedVxlan = $propertyValue }
-                    'Inner MAC VMQ Enabled' { $object.OffloadState.InnerMacVmqEnabled = $propertyValue }
-
                     default {
                         $propertyName = $propertyName.Replace(' ','').Trim()
 
@@ -2262,8 +2246,36 @@ function Get-SdnVfpPortState {
                 }
             }
             else {
-                # if the line does not have key/value pairs, then continue to next line
-                continue
+                # in this scenario, we do not have a key/value pair, so we will need to extract the property differently
+                # in most instances, if we see the property defined in the line, we can assume it is enabled since default is disabled and will not print
+                # with vfpctrl /get-port-state output
+                switch ($line.Trim()) {
+                    # these will map to VfpPortState
+                    "DTLS Offload Enabled" { $object.DtlsOffloadEnabled = $true }
+                    "GFT Offload Enabled" { $object.GftOffloadEnabled = $true }
+                    "VMQ Enabled" { $object.VmqEnabled = $true }
+                    "QoS Hardware Transmit Cap Offload Enabled" { $object.QosHardwareCapsEnabled = $true }
+                    "QoS Hardware Transmit Reservation Offload Enabled" { $object.QosHardwareReservationsEnabled = $true }
+                    "SR-IOV Enabled" { $object.SriovEnabled = $true }
+
+                    # these will map to the OffloadState property within VfpPortState
+                    "NVGRE LSO Offload Enabled" { $object.OffloadState.LsoV2Supported = $true  }
+                    "NVGRE RSS Enabled" { $object.OffloadState.RssSupported = $true  }                    
+                    "NVGRE Transmit Checksum Offload Enabled" { $object.OffloadState.TransmitChecksumOffloadSupported = $true }
+                    "NVGRE Receive Checksum Offload Enabled" { $object.OffloadState.ReceiveChecksumOffloadSupported = $true }
+                    "NVGRE VMQ Enabled" { $object.OffloadState.VmqSupported = $true }
+                    "VXLAN LSO Offload Enabled" { $object.OffloadState.LsoV2SupportedVxlan = $true }
+                    "VXLAN RSS Enabled" { $object.OffloadState.RssSupportedVxlan = $true }
+                    "VXLAN Transmit Checksum Offload Enabled" { $object.OffloadState.TransmitChecksumOffloadSupportedVxlan = $true }
+                    "VXLAN Receive Checksum Offload Enabled" { $object.OffloadState.ReceiveChecksumOffloadSupportedVxlan = $true }
+                    "VXLAN VMQ Enabled" { $object.OffloadState.VmqSupportedVxlan = $true }
+                    "Inner MAC VMQ Enabled" { $object.OffloadState.InnerMacVmqEnabled = $true }
+                    
+                    default {
+                        # this may just be random lines that do not map to a property, so we will just skip them
+                        continue
+                    }
+                }
             }
         }