Merged PR 13588380: Add accessor functions for extern const data symbols

Exporting data symbols from a dynamic module makes linking complicated on Windows. It requires the headers to define the symbols as `__declspec(dllimport)` only on the consuming side, which requires either two separate headers, or special macros. Without `declspec(dllimport)` the linker will not be able to find the data symbols. This has tripped up a number of consumers.

Providing accessor functions alleviates this issue, and is better practice for a dynamic library anyway, because it provides better ABI stability and encapsulation.

Background:
- [Import into an application using __declspec(dllimport)](https://learn.microsoft.com/en-us/cpp/build/importing-into-an-application-using-declspec-dllimport?view=msvc-170)
 - [LNK4217 - Russ Keldorph's WebLog - Site Home - MSDN Blogs (archive.org)](https://web.archive.org/web/20140911111411/http://blogs.msdn.com/b/russellk/archive/2005/03/20/399465.aspx?wa=wsignin1.0)

Related work items: #52850075

Author: mlindgren

CHANGELOG.md

@@ -3,10 +3,14 @@
 New changes will be listed here as they are developed. The version number is determined
 prior to the creation of a new release, based on the changes contained in that release.
 
+# Version 103.10.0
+
+- Fixed [#51](https://github.com/microsoft/SymCrypt/issues/51): Added accessor functions for `extern const` data symbols to prevent error `LNK2001` when dynamic linking on Windows
+
 # Version 103.9.1
 
+- Fixed [#48](https://github.com/microsoft/SymCrypt/issues/48): Fix minor interop issue in RSA PKCS1
 - Removed dependency on external randomness in ECDSA self-test
-- Fix minor interop issue in RSA PKCS1
 - Add FIPS CAST for ML-DSA and pairwise consistency tests for ML-KEM and ML-DSA on key generation
 
 # Version 103.9.0

inc/symcrypt.h

@@ -764,6 +764,35 @@ SymCryptEqual(
 // signature verification library.
 //
 
+typedef enum _SYMCRYPT_HASH_ID
+{
+    SYMCRYPT_HASH_ID_NULL                = 0,
+    SYMCRYPT_HASH_ID_MD2                 = 1,
+    SYMCRYPT_HASH_ID_MD4                 = 2,
+    SYMCRYPT_HASH_ID_MD5                 = 3,
+    SYMCRYPT_HASH_ID_SHA1                = 4,
+    SYMCRYPT_HASH_ID_SHA224              = 5,
+    SYMCRYPT_HASH_ID_SHA256              = 6,
+    SYMCRYPT_HASH_ID_SHA384              = 7,
+    SYMCRYPT_HASH_ID_SHA512              = 8,
+    SYMCRYPT_HASH_ID_SHA512_224          = 9,
+    SYMCRYPT_HASH_ID_SHA512_256          = 10,
+    SYMCRYPT_HASH_ID_SHA3_224            = 11,
+    SYMCRYPT_HASH_ID_SHA3_256            = 12,
+    SYMCRYPT_HASH_ID_SHA3_384            = 13,
+    SYMCRYPT_HASH_ID_SHA3_512            = 14,
+    SYMCRYPT_HASH_ID_SHAKE128            = 15,
+    SYMCRYPT_HASH_ID_SHAKE256            = 16
+} SYMCRYPT_HASH_ID;
+
+PCSYMCRYPT_HASH
+SYMCRYPT_CALL
+SymCryptGetHashAlgorithm( SYMCRYPT_HASH_ID hashId );
+//
+// Returns a pointer to the hash algorithm structure for the specified hash ID.
+// Returns NULL if the hash ID is invalid.
+//
+
 SIZE_T
 SYMCRYPT_CALL
 SymCryptHashResultSize( _In_ PCSYMCRYPT_HASH pHash );
@@ -2540,6 +2569,33 @@ SymCryptParallelSha512Selftest(void);
 // computation can be selected at runtime.
 //
 
+typedef enum _SYMCRYPT_MAC_ID
+{
+    SYMCRYPT_MAC_ID_NULL                = 0,
+    SYMCRYPT_MAC_ID_HMAC_MD5            = 1,
+    SYMCRYPT_MAC_ID_HMAC_SHA1           = 2,
+    SYMCRYPT_MAC_ID_HMAC_SHA224         = 3,
+    SYMCRYPT_MAC_ID_HMAC_SHA256         = 4,
+    SYMCRYPT_MAC_ID_HMAC_SHA384         = 5,
+    SYMCRYPT_MAC_ID_HMAC_SHA512         = 6,
+    SYMCRYPT_MAC_ID_HMAC_SHA512_224     = 7,
+    SYMCRYPT_MAC_ID_HMAC_SHA512_256     = 8,
+    SYMCRYPT_MAC_ID_HMAC_SHA3_224       = 9,
+    SYMCRYPT_MAC_ID_HMAC_SHA3_256       = 10,
+    SYMCRYPT_MAC_ID_HMAC_SHA3_384       = 11,
+    SYMCRYPT_MAC_ID_HMAC_SHA3_512       = 12,
+    SYMCRYPT_MAC_ID_AES_CMAC            = 13,
+    SYMCRYPT_MAC_ID_KMAC_128            = 14,
+    SYMCRYPT_MAC_ID_KMAC_256            = 15
+} SYMCRYPT_MAC_ID;
+
+PCSYMCRYPT_MAC
+SYMCRYPT_CALL
+SymCryptGetMacAlgorithm( SYMCRYPT_MAC_ID macId );
+//
+// Returns a pointer to the MAC algorithm structure for the specified MAC ID.
+// Returns NULL if the MAC ID is invalid.
+//
 
 //
 // Generic HMAC API with parametrized hash function
@@ -3948,6 +4004,13 @@ SymCryptMarvin32ExpandSeed(
 
 extern PCSYMCRYPT_MARVIN32_EXPANDED_SEED const SymCryptMarvin32DefaultSeed;
 
+PCSYMCRYPT_MARVIN32_EXPANDED_SEED
+SYMCRYPT_CALL
+SymCryptGetMarvin32DefaultSeed( void );
+//
+// Returns a pointer to the default Marvin32 seed.
+//
+
 VOID
 SYMCRYPT_CALL
 SymCryptMarvin32SeedCopy(   _In_    PCSYMCRYPT_MARVIN32_EXPANDED_SEED   pSrc,
@@ -4552,6 +4615,24 @@ extern const PCSYMCRYPT_BLOCKCIPHER SymCryptRc2BlockCipher;
 // (The SYMCRYPT_BLOCKCIPHER structure is a private one not available to callers.)
 //
 
+typedef enum _SYMCRYPT_BLOCKCIPHER_ID
+{
+    SYMCRYPT_BLOCKCIPHER_ID_NULL        = 0,
+    SYMCRYPT_BLOCKCIPHER_ID_AES         = 1,
+    SYMCRYPT_BLOCKCIPHER_ID_DES         = 2,
+    SYMCRYPT_BLOCKCIPHER_ID_3DES        = 3,
+    SYMCRYPT_BLOCKCIPHER_ID_DESX        = 4,
+    SYMCRYPT_BLOCKCIPHER_ID_RC2         = 5
+} SYMCRYPT_BLOCKCIPHER_ID;
+
+PCSYMCRYPT_BLOCKCIPHER
+SYMCRYPT_CALL
+SymCryptGetBlockCipher( SYMCRYPT_BLOCKCIPHER_ID blockCipherId );
+//
+// Returns a pointer to the block cipher structure for the specified block cipher ID.
+// Returns NULL if the block cipher ID is invalid.
+//
+
 VOID
 SYMCRYPT_CALL
 SymCryptEcbEncrypt(
@@ -8213,6 +8294,28 @@ extern const PCSYMCRYPT_ECURVE_PARAMS    SymCryptEcurveParamsNumsP512t1;
 
 extern const PCSYMCRYPT_ECURVE_PARAMS    SymCryptEcurveParamsCurve25519;
 
+typedef enum _SYMCRYPT_ECURVE_ID
+{
+    SYMCRYPT_ECURVE_ID_NULL             = 0,
+    SYMCRYPT_ECURVE_ID_NIST_P192        = 1,
+    SYMCRYPT_ECURVE_ID_NIST_P224        = 2,
+    SYMCRYPT_ECURVE_ID_NIST_P256        = 3,
+    SYMCRYPT_ECURVE_ID_NIST_P384        = 4,
+    SYMCRYPT_ECURVE_ID_NIST_P521        = 5,
+    SYMCRYPT_ECURVE_ID_NUMS_P256T1      = 6,
+    SYMCRYPT_ECURVE_ID_NUMS_P384T1      = 7,
+    SYMCRYPT_ECURVE_ID_NUMS_P512T1      = 8,
+    SYMCRYPT_ECURVE_ID_CURVE25519       = 9
+} SYMCRYPT_ECURVE_ID;
+
+PCSYMCRYPT_ECURVE_PARAMS
+SYMCRYPT_CALL
+SymCryptGetEcurveParams( SYMCRYPT_ECURVE_ID ecurveId );
+//
+// Returns a pointer to the elliptic curve parameters structure for the specified curve ID.
+// Returns NULL if the curve ID is invalid.
+//
+
 //=====================================================
 // ECC flags
 //

inc/symcrypt_internal.h

@@ -1097,15 +1097,15 @@ extern const SYMCRYPT_OID SymCryptSha256OidList[SYMCRYPT_SHA256_OID_COUNT];
 #define SYMCRYPT_SHA384_OID_COUNT      (2)
 extern const SYMCRYPT_OID SymCryptSha384OidList[SYMCRYPT_SHA384_OID_COUNT];
 
+#define SYMCRYPT_SHA512_OID_COUNT      (2)
+extern const SYMCRYPT_OID SymCryptSha512OidList[SYMCRYPT_SHA512_OID_COUNT];
+
 #define SYMCRYPT_SHA512_224_OID_COUNT      (2)
 extern const SYMCRYPT_OID SymCryptSha512_224OidList[SYMCRYPT_SHA512_224_OID_COUNT];
 
 #define SYMCRYPT_SHA512_256_OID_COUNT      (2)
 extern const SYMCRYPT_OID SymCryptSha512_256OidList[SYMCRYPT_SHA512_256_OID_COUNT];
 
-#define SYMCRYPT_SHA512_OID_COUNT      (2)
-extern const SYMCRYPT_OID SymCryptSha512OidList[SYMCRYPT_SHA512_OID_COUNT];
-
 #define SYMCRYPT_SHA3_224_OID_COUNT      (2)
 extern const SYMCRYPT_OID SymCryptSha3_224OidList[SYMCRYPT_SHA3_224_OID_COUNT];
 
@@ -1124,6 +1124,34 @@ extern const SYMCRYPT_OID SymCryptShake128OidList[SYMCRYPT_SHAKE128_OID_COUNT];
 #define SYMCRYPT_SHAKE256_OID_COUNT      (2)
 extern const SYMCRYPT_OID SymCryptShake256OidList[SYMCRYPT_SHAKE256_OID_COUNT];
 
+typedef enum _SYMCRYPT_OID_LIST_ID
+{
+    SYMCRYPT_OID_LIST_ID_NULL           = 0,
+    SYMCRYPT_OID_LIST_ID_MD5            = 1,
+    SYMCRYPT_OID_LIST_ID_SHA1           = 2,
+    SYMCRYPT_OID_LIST_ID_SHA224         = 3,
+    SYMCRYPT_OID_LIST_ID_SHA256         = 4,
+    SYMCRYPT_OID_LIST_ID_SHA384         = 5,
+    SYMCRYPT_OID_LIST_ID_SHA512         = 6,
+    SYMCRYPT_OID_LIST_ID_SHA512_224     = 7,
+    SYMCRYPT_OID_LIST_ID_SHA512_256     = 8,
+    SYMCRYPT_OID_LIST_ID_SHA3_224       = 9,
+    SYMCRYPT_OID_LIST_ID_SHA3_256       = 10,
+    SYMCRYPT_OID_LIST_ID_SHA3_384       = 11,
+    SYMCRYPT_OID_LIST_ID_SHA3_512       = 12,
+    SYMCRYPT_OID_LIST_ID_SHAKE128       = 13,
+    SYMCRYPT_OID_LIST_ID_SHAKE256       = 14
+} SYMCRYPT_OID_LIST_ID;
+
+PCSYMCRYPT_OID
+SYMCRYPT_CALL
+SymCryptGetOidList( SYMCRYPT_OID_LIST_ID oidId, _Out_opt_ SIZE_T* pCount );
+//
+// Returns a pointer to the OID list for the specified OID list ID. If pCount is non-NULL, the
+// pointed-to value will be set to the number of elements in the OID list.
+// Returns NULL if the OID list ID is invalid.
+//
+
 typedef union _SYMCRYPT_HASH_STATE
 {
     SYMCRYPT_MD2_STATE          md2State;

lib/CMakeLists.txt

@@ -22,6 +22,7 @@ set(SOURCES_COMMON
     cpuid_um.c
     cpuid.c
     crt.c
+    data_accessors.c
     DesTables.c
     desx.c
     dh.c