cache methodinfos

Author: markusheiliger

src/TeamCloud.Orchestrator/Command/CommandHandler.cs

@@ -4,10 +4,14 @@
  */
 
 using System;
+using System.Collections.Concurrent;
+using System.Reflection;
 using System.Threading.Tasks;
+using Jose;
 using Microsoft.Azure.WebJobs;
 using Microsoft.Azure.WebJobs.Extensions.DurableTask;
 using Microsoft.Extensions.Logging;
+using Microsoft.VisualStudio.Services.Common;
 using TeamCloud.Model.Commands.Core;
 
 namespace TeamCloud.Orchestrator.Command;
@@ -20,6 +24,21 @@ public abstract class CommandHandler<TCommand> : CommandHandler, ICommandHandler
 
 public abstract class CommandHandler : ICommandHandler
 {
+    private static readonly ConcurrentDictionary<Type, ConcurrentDictionary<Type, MethodInfo>> HandleMethodCache = new ConcurrentDictionary<Type, ConcurrentDictionary<Type, MethodInfo>>();
+
+    private MethodInfo GetHandleMethod(ICommand command) => HandleMethodCache
+        .GetOrAdd(GetType(), handlerType => new ConcurrentDictionary<Type, MethodInfo>())
+        .GetOrAdd(command.GetType(), commandType =>
+    {
+        var handlerInterface = typeof(ICommandHandler<>)
+            .MakeGenericType(commandType);
+
+        if (handlerInterface.IsAssignableFrom(GetType()))
+            return handlerInterface.GetMethod(nameof(HandleAsync), new Type[] { command.GetType(), typeof(IAsyncCollector<ICommand>), typeof(IDurableOrchestrationContext), typeof(ILogger) });
+
+        return null;
+    });
+
     public const string ProcessorQueue = "command-processor";
     public const string MonitorQueue = "command-monitor";
 
@@ -30,9 +49,7 @@ public virtual bool CanHandle(ICommand command)
         if (command is null)
             throw new ArgumentNullException(nameof(command));
 
-        return typeof(ICommandHandler<>)
-            .MakeGenericType(command.GetType())
-            .IsAssignableFrom(GetType());
+        return GetHandleMethod(command) is not null;
     }
 
     public virtual Task<ICommandResult> HandleAsync(ICommand command, IAsyncCollector<ICommand> commandQueue, IDurableOrchestrationContext orchestrationContext, ILogger log)
@@ -42,11 +59,7 @@ public virtual Task<ICommandResult> HandleAsync(ICommand command, IAsyncCollecto
 
         if (CanHandle(command))
         {
-            var handleMethod = typeof(ICommandHandler<>)
-                .MakeGenericType(command.GetType())
-                .GetMethod(nameof(HandleAsync), new Type[] { command.GetType(), typeof(IAsyncCollector<ICommand>), typeof(IDurableOrchestrationContext), typeof(ILogger) });
-
-            return (Task<ICommandResult>)handleMethod
+            return (Task<ICommandResult>)GetHandleMethod(command)
                 .Invoke(this, new object[] { command, commandQueue, orchestrationContext, log });
         }