From 2625b22677f082aa770f0d8e7c7f14f4f43026ef Mon Sep 17 00:00:00 2001 From: dombat Date: Tue, 10 Sep 2024 12:25:59 +0100 Subject: [PATCH 1/7] Remove unused GitHub Pages workflow --- .github/workflows/pages.yml | 62 ------------------------------------- 1 file changed, 62 deletions(-) delete mode 100644 .github/workflows/pages.yml diff --git a/.github/workflows/pages.yml b/.github/workflows/pages.yml deleted file mode 100644 index cedae546..00000000 --- a/.github/workflows/pages.yml +++ /dev/null @@ -1,62 +0,0 @@ -# This workflow uses actions that are not certified by GitHub. -# They are provided by a third-party and are governed by -# separate terms of service, privacy policy, and support -# documentation. - -# Sample workflow for building and deploying a Jekyll site to GitHub Pages -name: Deploy Jekyll site to Pages - -on: - push: - branches: ["main"] - - # Allows you to run this workflow manually from the Actions tab - workflow_dispatch: - -# Sets permissions of the GITHUB_TOKEN to allow deployment to GitHub Pages -permissions: - contents: read - pages: write - id-token: write - -# Allow one concurrent deployment -concurrency: - group: "pages" - cancel-in-progress: true - -jobs: - # Build job - build: - runs-on: ubuntu-latest - steps: - - name: Checkout - uses: actions/checkout@v3 - - name: Setup Ruby - uses: ruby/setup-ruby@v1 - with: - ruby-version: '3.1' # Not needed with a .ruby-version file - bundler-cache: true # runs 'bundle install' and caches installed gems automatically - cache-version: 0 # Increment this number if you need to re-download cached gems - - name: Setup Pages - id: pages - uses: actions/configure-pages@v2 - - name: Build with Jekyll - # Outputs to the './_site' directory by default - run: bundle exec jekyll build --baseurl "${{ steps.pages.outputs.base_path }}" - env: - JEKYLL_ENV: production - - name: Upload artifact - # Automatically uploads an artifact from the './_site' directory by default - uses: actions/upload-pages-artifact@v1 - - # Deployment job - deploy: - environment: - name: github-pages - url: "${{ steps.deployment.outputs.page_url }}" - runs-on: ubuntu-latest - needs: build - steps: - - name: Deploy to GitHub Pages - id: deployment - uses: actions/deploy-pages@v1 From 4e37d5e8c17e5b0c6a281ccaa97c550665157f0e Mon Sep 17 00:00:00 2001 From: dombat Date: Tue, 10 Sep 2024 13:39:47 +0100 Subject: [PATCH 2/7] Add first workflow YAML file --- .github/workflows/first-workflow.yml | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) create mode 100644 .github/workflows/first-workflow.yml diff --git a/.github/workflows/first-workflow.yml b/.github/workflows/first-workflow.yml new file mode 100644 index 00000000..14fe5747 --- /dev/null +++ b/.github/workflows/first-workflow.yml @@ -0,0 +1,21 @@ +name: First Workflow + +on: + workflow_dispatch: + +jobs: + build: + runs-on: ubuntu-latest + + steps: + - name: Checkout code + uses: actions/checkout@v2 + + # Add your build and test steps here + - name: Job1 + runs-on: ubuntu-latest + steps: + - name: Step 1 + run: echo "Step 1 complete!" + - name: Step 2 + run: echo "Step 2 complete!" \ No newline at end of file From 0093fa66b542729eab536d3d11f5684e5cdffda8 Mon Sep 17 00:00:00 2001 From: dombat Date: Tue, 10 Sep 2024 13:42:19 +0100 Subject: [PATCH 3/7] Refactor workflow YAML file to improve readability and remove unused steps --- .github/workflows/first-workflow.yml | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/.github/workflows/first-workflow.yml b/.github/workflows/first-workflow.yml index 14fe5747..910d5514 100644 --- a/.github/workflows/first-workflow.yml +++ b/.github/workflows/first-workflow.yml @@ -4,18 +4,12 @@ on: workflow_dispatch: jobs: - build: + job1: runs-on: ubuntu-latest steps: - - name: Checkout code - uses: actions/checkout@v2 - - # Add your build and test steps here - - name: Job1 - runs-on: ubuntu-latest - steps: - - name: Step 1 + - name: Step 1 run: echo "Step 1 complete!" - - name: Step 2 + + - name: Step 2 run: echo "Step 2 complete!" \ No newline at end of file From 71bb263312c5bf3f3588fc68b5e23695cf53d0ca Mon Sep 17 00:00:00 2001 From: dombat Date: Tue, 10 Sep 2024 13:48:08 +0100 Subject: [PATCH 4/7] Refactor workflow YAML file to improve readability and remove unused steps --- .github/workflows/first-workflow.yml | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/.github/workflows/first-workflow.yml b/.github/workflows/first-workflow.yml index 910d5514..0c2d2e63 100644 --- a/.github/workflows/first-workflow.yml +++ b/.github/workflows/first-workflow.yml @@ -12,4 +12,14 @@ jobs: run: echo "Step 1 complete!" - name: Step 2 - run: echo "Step 2 complete!" \ No newline at end of file + run: echo "Step 2 complete!" + + job2: + name: Cowsays + runs-on: ubuntu-latest + steps: + - name: Ship it + uses: mscoutermarsh/cowsays-action@master + with: + text: 'ship ship ship!' + color: 'magenta' \ No newline at end of file From 7483777d1711339fb4faf4b18d436349e04ba984 Mon Sep 17 00:00:00 2001 From: dombat Date: Tue, 10 Sep 2024 13:52:47 +0100 Subject: [PATCH 5/7] Refactor workflow YAML file to add issue trigger and dependency between jobs --- .github/workflows/first-workflow.yml | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/.github/workflows/first-workflow.yml b/.github/workflows/first-workflow.yml index 0c2d2e63..4a8686aa 100644 --- a/.github/workflows/first-workflow.yml +++ b/.github/workflows/first-workflow.yml @@ -2,6 +2,8 @@ name: First Workflow on: workflow_dispatch: + issues: + types: [opened] jobs: job1: @@ -15,6 +17,7 @@ jobs: run: echo "Step 2 complete!" job2: + needs: job1 name: Cowsays runs-on: ubuntu-latest steps: @@ -22,4 +25,5 @@ jobs: uses: mscoutermarsh/cowsays-action@master with: text: 'ship ship ship!' - color: 'magenta' \ No newline at end of file + color: 'magenta' + \ No newline at end of file From 12a1bfab51c4e0e4f7434b83f7f1a02c98416f7d Mon Sep 17 00:00:00 2001 From: dombat Date: Wed, 11 Sep 2024 09:12:29 +0100 Subject: [PATCH 6/7] chnaged length of string --- src/Application/src/RazorPagesTestSample/Data/Message.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Application/src/RazorPagesTestSample/Data/Message.cs b/src/Application/src/RazorPagesTestSample/Data/Message.cs index ea99cbd6..59f24395 100644 --- a/src/Application/src/RazorPagesTestSample/Data/Message.cs +++ b/src/Application/src/RazorPagesTestSample/Data/Message.cs @@ -9,7 +9,7 @@ public class Message [Required] [DataType(DataType.Text)] - [StringLength(200, ErrorMessage = "There's a 200 character limit on messages. Please shorten your message.")] + [StringLength(250, ErrorMessage = "There's a 250 character limit on messages. Please shorten your message.")] public string Text { get; set; } } #endregion From 80e3350c290f4a3968ec303d8124b4b389828979 Mon Sep 17 00:00:00 2001 From: dombat Date: Wed, 11 Sep 2024 09:14:42 +0100 Subject: [PATCH 7/7] Update character limit for message text field to 250 fixes issue #7 --- src/Application/src/RazorPagesTestSample/Data/Message.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Application/src/RazorPagesTestSample/Data/Message.cs b/src/Application/src/RazorPagesTestSample/Data/Message.cs index 59f24395..f3aff7c9 100644 --- a/src/Application/src/RazorPagesTestSample/Data/Message.cs +++ b/src/Application/src/RazorPagesTestSample/Data/Message.cs @@ -9,7 +9,7 @@ public class Message [Required] [DataType(DataType.Text)] - [StringLength(250, ErrorMessage = "There's a 250 character limit on messages. Please shorten your message.")] + [StringLength(250, ErrorMessage = "There's a 250 character limit on messages. Please shorten your message.")] //changed limnit from 200 to 250 public string Text { get; set; } } #endregion