added override and updated onerror for htmlelement

Author: cosmic-pixel-painter

baselines/dom.generated.d.ts

@@ -14026,7 +14026,7 @@ interface HTMLElementEventMap extends ElementEventMap, GlobalEventHandlersEventM
  *
  * [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLElement)
  */
-interface HTMLElement extends Element, ElementCSSInlineStyle, ElementContentEditable, GlobalEventHandlers, HTMLOrSVGElement {
+interface HTMLElement extends Element, ElementCSSInlineStyle, ElementContentEditable, Omit<GlobalEventHandlers, "onerror">, HTMLOrSVGElement {
     /**
      * The **`HTMLElement.accessKey`** property sets the keystroke which a user can press to jump to a given element.
      *
@@ -14117,6 +14117,13 @@ interface HTMLElement extends Element, ElementCSSInlineStyle, ElementContentEdit
      * [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLElement/offsetWidth)
      */
     readonly offsetWidth: number;
+    /**
+     * The error event is fired on an element when a resource failed to load, or can't be used.
+     *  [MDN Reference](https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/error_event)
+     *
+     * [MDN Reference](https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/error_event)
+     */
+    onerror: (((event: Event) => any) | ((event: UIEvent) => any)) | null;
     /**
      * The **`outerText`** property of the HTMLElement interface returns the same value as HTMLElement.innerText.
      *

baselines/ts5.5/dom.generated.d.ts

@@ -14013,7 +14013,7 @@ interface HTMLElementEventMap extends ElementEventMap, GlobalEventHandlersEventM
  *
  * [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLElement)
  */
-interface HTMLElement extends Element, ElementCSSInlineStyle, ElementContentEditable, GlobalEventHandlers, HTMLOrSVGElement {
+interface HTMLElement extends Element, ElementCSSInlineStyle, ElementContentEditable, Omit<GlobalEventHandlers, "onerror">, HTMLOrSVGElement {
     /**
      * The **`HTMLElement.accessKey`** property sets the keystroke which a user can press to jump to a given element.
      *
@@ -14104,6 +14104,13 @@ interface HTMLElement extends Element, ElementCSSInlineStyle, ElementContentEdit
      * [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLElement/offsetWidth)
      */
     readonly offsetWidth: number;
+    /**
+     * The error event is fired on an element when a resource failed to load, or can't be used.
+     *  [MDN Reference](https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/error_event)
+     *
+     * [MDN Reference](https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/error_event)
+     */
+    onerror: (((event: Event) => any) | ((event: UIEvent) => any)) | null;
     /**
      * The **`outerText`** property of the HTMLElement interface returns the same value as HTMLElement.innerText.
      *

baselines/ts5.6/dom.generated.d.ts

@@ -14026,7 +14026,7 @@ interface HTMLElementEventMap extends ElementEventMap, GlobalEventHandlersEventM
  *
  * [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLElement)
  */
-interface HTMLElement extends Element, ElementCSSInlineStyle, ElementContentEditable, GlobalEventHandlers, HTMLOrSVGElement {
+interface HTMLElement extends Element, ElementCSSInlineStyle, ElementContentEditable, Omit<GlobalEventHandlers, "onerror">, HTMLOrSVGElement {
     /**
      * The **`HTMLElement.accessKey`** property sets the keystroke which a user can press to jump to a given element.
      *
@@ -14117,6 +14117,13 @@ interface HTMLElement extends Element, ElementCSSInlineStyle, ElementContentEdit
      * [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLElement/offsetWidth)
      */
     readonly offsetWidth: number;
+    /**
+     * The error event is fired on an element when a resource failed to load, or can't be used.
+     *  [MDN Reference](https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/error_event)
+     *
+     * [MDN Reference](https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/error_event)
+     */
+    onerror: (((event: Event) => any) | ((event: UIEvent) => any)) | null;
     /**
      * The **`outerText`** property of the HTMLElement interface returns the same value as HTMLElement.innerText.
      *

inputfiles/overridingTypes.jsonc

@@ -404,6 +404,13 @@
                             // Blink only as of 2024-11
                             "overrideType": "boolean",
                             "nullable": false
+                        },
+                        "onerror": {
+                            "name": "onerror",
+                            "nullable": true,
+                            "overrideType": "((event: Event) => any) | ((event: UIEvent) => any)",
+                            "comment": "The error event is fired on an element when a resource failed to load, or can't be used. \n [MDN Reference](https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/error_event)",
+                            "mdnUrl": "https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/error_event"
                         }
                     }
                 },

src/build/emitter.ts

@@ -31,6 +31,17 @@ const extendConflictsBaseTypes: Record<
   },
 };
 
+const extendConflictsInterfaces: Record<
+  string,
+  { overrideMap: Record<string, string> }
+> = {
+  HTMLElement: {
+    overrideMap: {
+      GlobalEventHandlers: 'Omit<GlobalEventHandlers, "onerror">',
+    },
+  },
+};
+
 // Namespaces that have been in form of interfaces for years
 // and can't be converted to namespaces without breaking type packages
 const namespacesAsInterfaces = ["console"];
@@ -1270,7 +1281,7 @@ export function emitWebIdl(
     }
 
     function processMixinName(mixinName: string) {
-      if (allInterfacesMap[mixinName].typeParameters?.length === 1) {
+      if (allInterfacesMap[mixinName]?.typeParameters?.length === 1) {
         return `${mixinName}<${i.name}>`;
       }
       return mixinName;
@@ -1293,11 +1304,27 @@ export function emitWebIdl(
       `interface ${getNameWithTypeParameters(i.typeParameters, processedIName)}`,
     );
 
-    const finalExtends = [i.extends || "Object"]
+    // if (i.implements && extendConflictsInterfaces[i.name]?.implements?.length) {
+    //   i.implements = extendConflictsInterfaces[i.name]?.implements;
+    // }
+
+    let finalExtends = [i.extends || "Object"]
       .concat(getImplementList(i.name).map(processMixinName))
+      // .concat(extendConflictsInterfaces[i.name]?.extendType ?? [])
       .filter((i) => i !== "Object")
       .map(processIName);
 
+    if (finalExtends.length && extendConflictsInterfaces[i.name]?.overrideMap) {
+      finalExtends = finalExtends.reduce((agg, item) => {
+        if (extendConflictsInterfaces[i.name]?.overrideMap[item]) {
+          agg.push(extendConflictsInterfaces[i.name]?.overrideMap[item]);
+          return agg;
+        }
+        agg.push(item);
+        return agg;
+      }, [] as string[]);
+    }
+
     if (finalExtends.length) {
       printer.print(` extends ${assertUnique(finalExtends).join(", ")}`);
     }

unittests/files/onerror.ts

@@ -0,0 +1,35 @@
+/**
+ * window.onerror works as intended with global event handler
+ */
+window.onerror = (message, src, lineno, colno, error) => {
+  if (message && src && lineno && colno && error) {
+    return;
+  }
+};
+
+
+const div: HTMLElement = document.createElement("div");
+
+
+/**
+ * HTMLElement.onerror works with a single event arg, UIEvent
+ */
+div.onerror = (event: UIEvent) => {
+  if (event) {
+    return;
+  }
+};
+/**
+ * HTMLElement.onerror works with a single event arg, Event
+ */
+div.onerror = (event: Event) => {
+  if (event) {
+    return;
+  }
+};
+
+
+/**
+ * HTMLElement onerror is nullable
+ */
+div.onerror = null;