correct LockManager.prototype.request return type with async callback

Renegade334 · Renegade334 · commit d678a31e3966 · 2025-08-08T01:10:12.000+01:00
diff --git a/baselines/dom.generated.d.ts b/baselines/dom.generated.d.ts
@@ -19766,8 +19766,8 @@ interface LockManager {
      *
      * [MDN Reference](https://developer.mozilla.org/docs/Web/API/LockManager/request)
      */
-    request<T>(name: string, callback: LockGrantedCallback<T>): Promise<T>;
-    request<T>(name: string, options: LockOptions, callback: LockGrantedCallback<T>): Promise<T>;
+    request<T>(name: string, callback: LockGrantedCallback<T>): Promise<Awaited<T>>;
+    request<T>(name: string, options: LockOptions, callback: LockGrantedCallback<T>): Promise<Awaited<T>>;
 }
 
 declare var LockManager: {
diff --git a/baselines/serviceworker.generated.d.ts b/baselines/serviceworker.generated.d.ts
@@ -5024,8 +5024,8 @@ interface LockManager {
      *
      * [MDN Reference](https://developer.mozilla.org/docs/Web/API/LockManager/request)
      */
-    request<T>(name: string, callback: LockGrantedCallback<T>): Promise<T>;
-    request<T>(name: string, options: LockOptions, callback: LockGrantedCallback<T>): Promise<T>;
+    request<T>(name: string, callback: LockGrantedCallback<T>): Promise<Awaited<T>>;
+    request<T>(name: string, options: LockOptions, callback: LockGrantedCallback<T>): Promise<Awaited<T>>;
 }
 
 declare var LockManager: {
diff --git a/baselines/sharedworker.generated.d.ts b/baselines/sharedworker.generated.d.ts
@@ -4707,8 +4707,8 @@ interface LockManager {
      *
      * [MDN Reference](https://developer.mozilla.org/docs/Web/API/LockManager/request)
      */
-    request<T>(name: string, callback: LockGrantedCallback<T>): Promise<T>;
-    request<T>(name: string, options: LockOptions, callback: LockGrantedCallback<T>): Promise<T>;
+    request<T>(name: string, callback: LockGrantedCallback<T>): Promise<Awaited<T>>;
+    request<T>(name: string, options: LockOptions, callback: LockGrantedCallback<T>): Promise<Awaited<T>>;
 }
 
 declare var LockManager: {
diff --git a/baselines/ts5.5/dom.generated.d.ts b/baselines/ts5.5/dom.generated.d.ts
@@ -19745,8 +19745,8 @@ interface LockManager {
      *
      * [MDN Reference](https://developer.mozilla.org/docs/Web/API/LockManager/request)
      */
-    request<T>(name: string, callback: LockGrantedCallback<T>): Promise<T>;
-    request<T>(name: string, options: LockOptions, callback: LockGrantedCallback<T>): Promise<T>;
+    request<T>(name: string, callback: LockGrantedCallback<T>): Promise<Awaited<T>>;
+    request<T>(name: string, options: LockOptions, callback: LockGrantedCallback<T>): Promise<Awaited<T>>;
 }
 
 declare var LockManager: {
diff --git a/baselines/ts5.5/serviceworker.generated.d.ts b/baselines/ts5.5/serviceworker.generated.d.ts
@@ -5024,8 +5024,8 @@ interface LockManager {
      *
      * [MDN Reference](https://developer.mozilla.org/docs/Web/API/LockManager/request)
      */
-    request<T>(name: string, callback: LockGrantedCallback<T>): Promise<T>;
-    request<T>(name: string, options: LockOptions, callback: LockGrantedCallback<T>): Promise<T>;
+    request<T>(name: string, callback: LockGrantedCallback<T>): Promise<Awaited<T>>;
+    request<T>(name: string, options: LockOptions, callback: LockGrantedCallback<T>): Promise<Awaited<T>>;
 }
 
 declare var LockManager: {
diff --git a/baselines/ts5.5/sharedworker.generated.d.ts b/baselines/ts5.5/sharedworker.generated.d.ts
@@ -4707,8 +4707,8 @@ interface LockManager {
      *
      * [MDN Reference](https://developer.mozilla.org/docs/Web/API/LockManager/request)
      */
-    request<T>(name: string, callback: LockGrantedCallback<T>): Promise<T>;
-    request<T>(name: string, options: LockOptions, callback: LockGrantedCallback<T>): Promise<T>;
+    request<T>(name: string, callback: LockGrantedCallback<T>): Promise<Awaited<T>>;
+    request<T>(name: string, options: LockOptions, callback: LockGrantedCallback<T>): Promise<Awaited<T>>;
 }
 
 declare var LockManager: {
diff --git a/baselines/ts5.5/webworker.generated.d.ts b/baselines/ts5.5/webworker.generated.d.ts
@@ -5853,8 +5853,8 @@ interface LockManager {
      *
      * [MDN Reference](https://developer.mozilla.org/docs/Web/API/LockManager/request)
      */
-    request<T>(name: string, callback: LockGrantedCallback<T>): Promise<T>;
-    request<T>(name: string, options: LockOptions, callback: LockGrantedCallback<T>): Promise<T>;
+    request<T>(name: string, callback: LockGrantedCallback<T>): Promise<Awaited<T>>;
+    request<T>(name: string, options: LockOptions, callback: LockGrantedCallback<T>): Promise<Awaited<T>>;
 }
 
 declare var LockManager: {
diff --git a/baselines/ts5.6/dom.generated.d.ts b/baselines/ts5.6/dom.generated.d.ts
@@ -19766,8 +19766,8 @@ interface LockManager {
      *
      * [MDN Reference](https://developer.mozilla.org/docs/Web/API/LockManager/request)
      */
-    request<T>(name: string, callback: LockGrantedCallback<T>): Promise<T>;
-    request<T>(name: string, options: LockOptions, callback: LockGrantedCallback<T>): Promise<T>;
+    request<T>(name: string, callback: LockGrantedCallback<T>): Promise<Awaited<T>>;
+    request<T>(name: string, options: LockOptions, callback: LockGrantedCallback<T>): Promise<Awaited<T>>;
 }
 
 declare var LockManager: {
diff --git a/baselines/ts5.6/serviceworker.generated.d.ts b/baselines/ts5.6/serviceworker.generated.d.ts
@@ -5024,8 +5024,8 @@ interface LockManager {
      *
      * [MDN Reference](https://developer.mozilla.org/docs/Web/API/LockManager/request)
      */
-    request<T>(name: string, callback: LockGrantedCallback<T>): Promise<T>;
-    request<T>(name: string, options: LockOptions, callback: LockGrantedCallback<T>): Promise<T>;
+    request<T>(name: string, callback: LockGrantedCallback<T>): Promise<Awaited<T>>;
+    request<T>(name: string, options: LockOptions, callback: LockGrantedCallback<T>): Promise<Awaited<T>>;
 }
 
 declare var LockManager: {
diff --git a/baselines/ts5.6/sharedworker.generated.d.ts b/baselines/ts5.6/sharedworker.generated.d.ts
@@ -4707,8 +4707,8 @@ interface LockManager {
      *
      * [MDN Reference](https://developer.mozilla.org/docs/Web/API/LockManager/request)
      */
-    request<T>(name: string, callback: LockGrantedCallback<T>): Promise<T>;
-    request<T>(name: string, options: LockOptions, callback: LockGrantedCallback<T>): Promise<T>;
+    request<T>(name: string, callback: LockGrantedCallback<T>): Promise<Awaited<T>>;
+    request<T>(name: string, options: LockOptions, callback: LockGrantedCallback<T>): Promise<Awaited<T>>;
 }
 
 declare var LockManager: {
diff --git a/baselines/ts5.6/webworker.generated.d.ts b/baselines/ts5.6/webworker.generated.d.ts
@@ -5853,8 +5853,8 @@ interface LockManager {
      *
      * [MDN Reference](https://developer.mozilla.org/docs/Web/API/LockManager/request)
      */
-    request<T>(name: string, callback: LockGrantedCallback<T>): Promise<T>;
-    request<T>(name: string, options: LockOptions, callback: LockGrantedCallback<T>): Promise<T>;
+    request<T>(name: string, callback: LockGrantedCallback<T>): Promise<Awaited<T>>;
+    request<T>(name: string, options: LockOptions, callback: LockGrantedCallback<T>): Promise<Awaited<T>>;
 }
 
 declare var LockManager: {
diff --git a/baselines/webworker.generated.d.ts b/baselines/webworker.generated.d.ts
@@ -5853,8 +5853,8 @@ interface LockManager {
      *
      * [MDN Reference](https://developer.mozilla.org/docs/Web/API/LockManager/request)
      */
-    request<T>(name: string, callback: LockGrantedCallback<T>): Promise<T>;
-    request<T>(name: string, options: LockOptions, callback: LockGrantedCallback<T>): Promise<T>;
+    request<T>(name: string, callback: LockGrantedCallback<T>): Promise<Awaited<T>>;
+    request<T>(name: string, options: LockOptions, callback: LockGrantedCallback<T>): Promise<Awaited<T>>;
 }
 
 declare var LockManager: {
diff --git a/inputfiles/overridingTypes.jsonc b/inputfiles/overridingTypes.jsonc
@@ -3529,7 +3529,7 @@
                                             "overrideType": "LockGrantedCallback<T>"
                                         }
                                     ],
-                                    "overrideType": "Promise<T>"
+                                    "overrideType": "Promise<Awaited<T>>"
                                 },
                                 "1": {
                                     "typeParameters": [
@@ -3543,7 +3543,7 @@
                                             "overrideType": "LockGrantedCallback<T>"
                                         }
                                     ],
-                                    "overrideType": "Promise<T>"
+                                    "overrideType": "Promise<Awaited<T>>"
                                 }
                             }
                         }

Original file line number	Diff line number	Diff line change
`@@ -19766,8 +19766,8 @@ interface LockManager {`
`19766`	`19766`	`*`
`19767`	`19767`	`* [MDN Reference](https://developer.mozilla.org/docs/Web/API/LockManager/request)`
`19768`	`19768`	`*/`
`19769`		`- request<T>(name: string, callback: LockGrantedCallback<T>): Promise<T>;`
`19770`		`- request<T>(name: string, options: LockOptions, callback: LockGrantedCallback<T>): Promise<T>;`
	`19769`	`+ request<T>(name: string, callback: LockGrantedCallback<T>): Promise<Awaited<T>>;`
	`19770`	`+ request<T>(name: string, options: LockOptions, callback: LockGrantedCallback<T>): Promise<Awaited<T>>;`
`19771`	`19771`	`}`
`19772`	`19772`
`19773`	`19773`	`declare var LockManager: {`
Original file line number	Diff line number	Diff line change
`@@ -5024,8 +5024,8 @@ interface LockManager {`
`5024`	`5024`	`*`
`5025`	`5025`	`* [MDN Reference](https://developer.mozilla.org/docs/Web/API/LockManager/request)`
`5026`	`5026`	`*/`
`5027`		`- request<T>(name: string, callback: LockGrantedCallback<T>): Promise<T>;`
`5028`		`- request<T>(name: string, options: LockOptions, callback: LockGrantedCallback<T>): Promise<T>;`
	`5027`	`+ request<T>(name: string, callback: LockGrantedCallback<T>): Promise<Awaited<T>>;`
	`5028`	`+ request<T>(name: string, options: LockOptions, callback: LockGrantedCallback<T>): Promise<Awaited<T>>;`
`5029`	`5029`	`}`
`5030`	`5030`
`5031`	`5031`	`declare var LockManager: {`
Original file line number	Diff line number	Diff line change
`@@ -4707,8 +4707,8 @@ interface LockManager {`
`4707`	`4707`	`*`
`4708`	`4708`	`* [MDN Reference](https://developer.mozilla.org/docs/Web/API/LockManager/request)`
`4709`	`4709`	`*/`
`4710`		`- request<T>(name: string, callback: LockGrantedCallback<T>): Promise<T>;`
`4711`		`- request<T>(name: string, options: LockOptions, callback: LockGrantedCallback<T>): Promise<T>;`
	`4710`	`+ request<T>(name: string, callback: LockGrantedCallback<T>): Promise<Awaited<T>>;`
	`4711`	`+ request<T>(name: string, options: LockOptions, callback: LockGrantedCallback<T>): Promise<Awaited<T>>;`
`4712`	`4712`	`}`
`4713`	`4713`
`4714`	`4714`	`declare var LockManager: {`
Original file line number	Diff line number	Diff line change
`@@ -19745,8 +19745,8 @@ interface LockManager {`
`19745`	`19745`	`*`
`19746`	`19746`	`* [MDN Reference](https://developer.mozilla.org/docs/Web/API/LockManager/request)`
`19747`	`19747`	`*/`
`19748`		`- request<T>(name: string, callback: LockGrantedCallback<T>): Promise<T>;`
`19749`		`- request<T>(name: string, options: LockOptions, callback: LockGrantedCallback<T>): Promise<T>;`
	`19748`	`+ request<T>(name: string, callback: LockGrantedCallback<T>): Promise<Awaited<T>>;`
	`19749`	`+ request<T>(name: string, options: LockOptions, callback: LockGrantedCallback<T>): Promise<Awaited<T>>;`
`19750`	`19750`	`}`
`19751`	`19751`
`19752`	`19752`	`declare var LockManager: {`
Original file line number	Diff line number	Diff line change
`@@ -5853,8 +5853,8 @@ interface LockManager {`
`5853`	`5853`	`*`
`5854`	`5854`	`* [MDN Reference](https://developer.mozilla.org/docs/Web/API/LockManager/request)`
`5855`	`5855`	`*/`
`5856`		`- request<T>(name: string, callback: LockGrantedCallback<T>): Promise<T>;`
`5857`		`- request<T>(name: string, options: LockOptions, callback: LockGrantedCallback<T>): Promise<T>;`
	`5856`	`+ request<T>(name: string, callback: LockGrantedCallback<T>): Promise<Awaited<T>>;`
	`5857`	`+ request<T>(name: string, options: LockOptions, callback: LockGrantedCallback<T>): Promise<Awaited<T>>;`
`5858`	`5858`	`}`
`5859`	`5859`
`5860`	`5860`	`declare var LockManager: {`