Skip to content

Commit fc80646

Browse files
added addEventListener override
1 parent 9ece70d commit fc80646

File tree

6 files changed

+39
-2
lines changed

6 files changed

+39
-2
lines changed

baselines/dom.generated.d.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14190,6 +14190,7 @@ interface HTMLElement extends Element, ElementCSSInlineStyle, ElementContentEdit
1419014190
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLElement/togglePopover)
1419114191
*/
1419214192
togglePopover(options?: boolean): boolean;
14193+
addEventListener(type: string, listener: ((event: Event) => void) | ((event: UIEvent) => void)): void;
1419314194
addEventListener<K extends keyof HTMLElementEventMap>(type: K, listener: (this: HTMLElement, ev: HTMLElementEventMap[K]) => any, options?: boolean | AddEventListenerOptions): void;
1419414195
addEventListener(type: string, listener: EventListenerOrEventListenerObject, options?: boolean | AddEventListenerOptions): void;
1419514196
removeEventListener<K extends keyof HTMLElementEventMap>(type: K, listener: (this: HTMLElement, ev: HTMLElementEventMap[K]) => any, options?: boolean | EventListenerOptions): void;

baselines/ts5.5/dom.generated.d.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14177,6 +14177,7 @@ interface HTMLElement extends Element, ElementCSSInlineStyle, ElementContentEdit
1417714177
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLElement/togglePopover)
1417814178
*/
1417914179
togglePopover(options?: boolean): boolean;
14180+
addEventListener(type: string, listener: ((event: Event) => void) | ((event: UIEvent) => void)): void;
1418014181
addEventListener<K extends keyof HTMLElementEventMap>(type: K, listener: (this: HTMLElement, ev: HTMLElementEventMap[K]) => any, options?: boolean | AddEventListenerOptions): void;
1418114182
addEventListener(type: string, listener: EventListenerOrEventListenerObject, options?: boolean | AddEventListenerOptions): void;
1418214183
removeEventListener<K extends keyof HTMLElementEventMap>(type: K, listener: (this: HTMLElement, ev: HTMLElementEventMap[K]) => any, options?: boolean | EventListenerOptions): void;

baselines/ts5.6/dom.generated.d.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14190,6 +14190,7 @@ interface HTMLElement extends Element, ElementCSSInlineStyle, ElementContentEdit
1419014190
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLElement/togglePopover)
1419114191
*/
1419214192
togglePopover(options?: boolean): boolean;
14193+
addEventListener(type: string, listener: ((event: Event) => void) | ((event: UIEvent) => void)): void;
1419314194
addEventListener<K extends keyof HTMLElementEventMap>(type: K, listener: (this: HTMLElement, ev: HTMLElementEventMap[K]) => any, options?: boolean | AddEventListenerOptions): void;
1419414195
addEventListener(type: string, listener: EventListenerOrEventListenerObject, options?: boolean | AddEventListenerOptions): void;
1419514196
removeEventListener<K extends keyof HTMLElementEventMap>(type: K, listener: (this: HTMLElement, ev: HTMLElementEventMap[K]) => any, options?: boolean | EventListenerOptions): void;

inputfiles/overridingTypes.jsonc

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -428,6 +428,11 @@
428428
]
429429
}
430430
}
431+
},
432+
"addEventListener": {
433+
"overrideSignatures": [
434+
"addEventListener(type: string, listener: ((event: Event) => void) | ((event: UIEvent) => void)): void"
435+
]
431436
}
432437
}
433438
}
@@ -1235,7 +1240,7 @@
12351240
"name": "quality",
12361241
"overrideType": "number"
12371242
}
1238-
],
1243+
]
12391244
}
12401245
}
12411246
},
@@ -1248,7 +1253,7 @@
12481253
"name": "quality",
12491254
"overrideType": "number"
12501255
}
1251-
],
1256+
]
12521257
}
12531258
}
12541259
}

unittests/files/eventlistener.ts

Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,3 +7,31 @@ document.addEventListener("arbitrary_invalid_event", {
77
return ev.returnValue;
88
}
99
});
10+
11+
const divElement: HTMLElement = document.createElement("div");
12+
13+
14+
divElement.addEventListener(
15+
"click",
16+
(event: Event) => {
17+
if (event) {
18+
return;
19+
}
20+
},
21+
false,
22+
);
23+
24+
divElement.addEventListener(
25+
"click",
26+
(event: Event) => {
27+
if (event) {
28+
return;
29+
}
30+
}
31+
);
32+
33+
divElement.addEventListener("beep", (event: UIEvent) => {
34+
if (event) {
35+
return;
36+
}
37+
});

unittests/files/onerror.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ div.onerror = (event: UIEvent) => {
1919
return;
2020
}
2121
};
22+
2223
/**
2324
* HTMLElement.onerror works with a single event arg, Event
2425
*/

0 commit comments

Comments
 (0)