Feature: Rename enum in KDL #2095
Conversation
|
Thanks for the PR! This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged. |
inputfiles/patches/clienttype.kdl
Outdated
| @@ -0,0 +1 @@ | |||
| enum ClientType name="ClientTypes" | |||
There was a problem hiding this comment.
The file name can be type-rename.kdl
There was a problem hiding this comment.
Done, but i have named it typerename.kdl, to follow the same format as the other files
There was a problem hiding this comment.
Hmm? typerename is not single word while other file names are single words
There was a problem hiding this comment.
Okay, I will update it
I have changed it |
|
Sorry @Bashamega, you don't have access to these files: |
|
LGTM |
|
There was an issue merging, maybe try again saschanaz. Details |
inputfiles/patches/type-rename.kdl
Outdated
| @@ -0,0 +1 @@ | |||
| enum ClientType name="ClientTypes" | |||
There was a problem hiding this comment.
BTW you can also skip quote.
There was a problem hiding this comment.
Would you like me to remove them? I find it more readable with quotes, especially for properties
There was a problem hiding this comment.
enum ClientType name="ClientTypes"
enum ClientType name=ClientTypes
The quote gives a strong signal of "I'm string", but technically everything is string here, including enum (you can do "enum" and get the same result). So I prefer skipping it for consistency.
|
LGTM |
|
There was an issue merging, maybe try again saschanaz. Details |
|
LGTM |
|
Merging because @saschanaz is a code-owner of all the changes - thanks! |
3 participants
related #2053