Skip to content

Conversation

Bashamega
Copy link
Contributor

fixes #2156

I didn't add delay, and trackVisibility because they are only available for Blink.

Copy link
Contributor

Thanks for the PR!

This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged.

@wbolster
Copy link

wbolster commented Sep 24, 2025

thanks, lgtm.

note: i'm not involved in the maintenance of this project, so take my ‘approved this PR’ with a grain of salt. surprised that github let me click that button actually 🙃 (update: heh yep indeed #2157 (comment))

for the missing delay and trackVisibility, do you think module augmentations as exemplified in this PR to VueUse is the right approach, @Bashamega? would appreciate your opinion 🙏

Copy link
Contributor

Sorry @wbolster, you don't have access to these files:

@Bashamega
Copy link
Contributor Author

thanks, lgtm.

note: i'm not involved in the maintenance of this project, so take my ‘approved this PR’ with a grain of salt. surprised that github let me click that button actually 🙃 (update: heh yep indeed #2157 (comment))

for the missing delay and trackVisibility, do you think module augmentations as exemplified in this PR to VueUse is the right approach, @Bashamega? would appreciate your opinion 🙏

No issues 😃
For this project, one of the guidelines requires support in at least two browser engines.
I’m not sure if your VueUse PR is the right approach, since I’m not the maintainer and I don’t know their exact guidelines. It may be best to wait until the feature is fully supported. You could also ask the maintainer directly for clarification.

Copy link
Contributor

Sorry @Bashamega, you don't have access to these files:

@saschanaz
Copy link
Contributor

The argument in #2156 is incorrect as Gecko and WebKit only added it a few months ago. Anyway LGTM.

https://bugzilla.mozilla.org/show_bug.cgi?id=1860030
WebKit/WebKit#40687

Copy link
Contributor

There was an issue merging, maybe try again saschanaz. Details

@jakebailey jakebailey merged commit 246360b into microsoft:main Sep 24, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing options for IntersectionObserver in DOM definitions

4 participants