-
Notifications
You must be signed in to change notification settings - Fork 452
Adds Scroll margin #2157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Scroll margin #2157
Conversation
Thanks for the PR! This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged. |
thanks, lgtm. note: i'm not involved in the maintenance of this project, so take my ‘approved this PR’ with a grain of salt. surprised that github let me click that button actually 🙃 (update: heh yep indeed #2157 (comment)) for the missing |
Sorry @wbolster, you don't have access to these files: |
No issues 😃 |
Sorry @Bashamega, you don't have access to these files: |
The argument in #2156 is incorrect as Gecko and WebKit only added it a few months ago. Anyway LGTM. https://bugzilla.mozilla.org/show_bug.cgi?id=1860030 |
There was an issue merging, maybe try again saschanaz. Details |
fixes #2156
I didn't add delay, and trackVisibility because they are only available for Blink.