Add "until-found" to HTMLElement.hidden
#2254
Merged
+5
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks for the PR! This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged. |
Ref: https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/hidden#until-found This has now got support from Chrome and Firefox: https://caniuse.com/wf-hidden-until-found Will also land in Safari: https://bugs.webkit.org/show_bug.cgi?id=238266 Co-authored-by: Sage Abdullah <[email protected]>
laymonage
force-pushed
the
add-hidden-until-found
branch
from
effecbe to
7bf16e7
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Contributor
|
Is the whole block in |
Contributor
Author
|
@HolgerJeromin when I removed it, it produces the following output instead: hidden: boolean | number | string | null;which doesn't look accurate. |
Contributor
|
Thanks for testing! |
Contributor
|
LGTM, thanks! |
Contributor
|
There was an issue merging, maybe try again saschanaz. Details |
Member
|
@saschanaz Can you try that again? |
Contributor
|
LGTM |
Contributor
|
Merging because @saschanaz is a code-owner of all the changes - thanks! |
Contributor
|
Yaaaay thanks @jakebailey ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebase of #1670
This has now got support from Chrome and Firefox: https://caniuse.com/wf-hidden-until-found
Safari support has been merged: https://webkit.org/b/238266