Skip to content

Commit 57f591c

Browse files
authored
Merge pull request #570 from Microsoft/dev/billti/setJsxToHtmlClassifications
Fix issue with JSX attribute names not being colorized in VS
2 parents 77d21fd + aff0aba commit 57f591c

File tree

4 files changed

+983
-9
lines changed

4 files changed

+983
-9
lines changed

TypeScript.YAML-tmTheme

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -49,11 +49,11 @@ settings:
4949
settings: { vsclassificationtype: identifier }
5050

5151
- scope: entity.name.tag
52-
settings: { vsclassificationtype: xml literal - name }
52+
settings: { vsclassificationtype: HTML Element Name }
5353

5454
- scope: entity.other.attribute-name
55-
settings: { vsclassificationtype: XML Attribute }
55+
settings: { vsclassificationtype: HTML Attribute Name }
5656

5757
- scope: meta.tag string.quoted, meta.tag string.quoted punctuation.definition.string, meta.tag string.quoted constant.character.escape
58-
settings: { vsclassificationtype: xml literal - attribute value }
58+
settings: { vsclassificationtype: HTML Attribute Value }
5959
...

TypeScript.tmTheme

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,7 @@
158158
<key>settings</key>
159159
<dict>
160160
<key>vsclassificationtype</key>
161-
<string>xml literal - name</string>
161+
<string>HTML Element Name</string>
162162
</dict>
163163
</dict>
164164
<dict>
@@ -167,7 +167,7 @@
167167
<key>settings</key>
168168
<dict>
169169
<key>vsclassificationtype</key>
170-
<string>XML Attribute</string>
170+
<string>HTML Attribute Name</string>
171171
</dict>
172172
</dict>
173173
<dict>
@@ -176,7 +176,7 @@
176176
<key>settings</key>
177177
<dict>
178178
<key>vsclassificationtype</key>
179-
<string>xml literal - attribute value</string>
179+
<string>HTML Attribute Value</string>
180180
</dict>
181181
</dict>
182182
</array>

TypeScriptReact.tmTheme

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,7 @@
158158
<key>settings</key>
159159
<dict>
160160
<key>vsclassificationtype</key>
161-
<string>xml literal - name</string>
161+
<string>HTML Element Name</string>
162162
</dict>
163163
</dict>
164164
<dict>
@@ -167,7 +167,7 @@
167167
<key>settings</key>
168168
<dict>
169169
<key>vsclassificationtype</key>
170-
<string>XML Attribute</string>
170+
<string>HTML Attribute Name</string>
171171
</dict>
172172
</dict>
173173
<dict>
@@ -176,7 +176,7 @@
176176
<key>settings</key>
177177
<dict>
178178
<key>vsclassificationtype</key>
179-
<string>xml literal - attribute value</string>
179+
<string>HTML Attribute Value</string>
180180
</dict>
181181
</dict>
182182
<dict>

0 commit comments

Comments
 (0)