Skip to content

Commit 7bf8960

Browse files
committed
Fix incorrect detection of keyword vs function call
Fixes #628
1 parent 9a52efa commit 7bf8960

File tree

5 files changed

+25
-6
lines changed

5 files changed

+25
-6
lines changed

TypeScript.YAML-tmLanguage

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1349,9 +1349,9 @@ repository:
13491349
- name: keyword.operator.expression.delete.ts
13501350
match: '{{startOfIdentifier}}delete{{endOfIdentifier}}'
13511351
- name: keyword.operator.expression.in.ts
1352-
match: '{{startOfIdentifier}}in{{endOfIdentifier}}'
1352+
match: '{{startOfIdentifier}}in{{endOfIdentifier}}(?!\()'
13531353
- name: keyword.operator.expression.of.ts
1354-
match: '{{startOfIdentifier}}of{{endOfIdentifier}}'
1354+
match: '{{startOfIdentifier}}of{{endOfIdentifier}}(?!\()'
13551355
- name: keyword.operator.expression.instanceof.ts
13561356
match: '{{startOfIdentifier}}instanceof{{endOfIdentifier}}'
13571357
- name: keyword.operator.new.ts

TypeScript.tmLanguage

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4258,13 +4258,13 @@
42584258
<key>name</key>
42594259
<string>keyword.operator.expression.in.ts</string>
42604260
<key>match</key>
4261-
<string>(?&lt;![_$[:alnum:]])(?:(?&lt;=\.\.\.)|(?&lt;!\.))in(?![_$[:alnum:]])(?:(?=\.\.\.)|(?!\.))</string>
4261+
<string>(?&lt;![_$[:alnum:]])(?:(?&lt;=\.\.\.)|(?&lt;!\.))in(?![_$[:alnum:]])(?:(?=\.\.\.)|(?!\.))(?!\()</string>
42624262
</dict>
42634263
<dict>
42644264
<key>name</key>
42654265
<string>keyword.operator.expression.of.ts</string>
42664266
<key>match</key>
4267-
<string>(?&lt;![_$[:alnum:]])(?:(?&lt;=\.\.\.)|(?&lt;!\.))of(?![_$[:alnum:]])(?:(?=\.\.\.)|(?!\.))</string>
4267+
<string>(?&lt;![_$[:alnum:]])(?:(?&lt;=\.\.\.)|(?&lt;!\.))of(?![_$[:alnum:]])(?:(?=\.\.\.)|(?!\.))(?!\()</string>
42684268
</dict>
42694269
<dict>
42704270
<key>name</key>

TypeScriptReact.tmLanguage

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4204,13 +4204,13 @@
42044204
<key>name</key>
42054205
<string>keyword.operator.expression.in.tsx</string>
42064206
<key>match</key>
4207-
<string>(?&lt;![_$[:alnum:]])(?:(?&lt;=\.\.\.)|(?&lt;!\.))in(?![_$[:alnum:]])(?:(?=\.\.\.)|(?!\.))</string>
4207+
<string>(?&lt;![_$[:alnum:]])(?:(?&lt;=\.\.\.)|(?&lt;!\.))in(?![_$[:alnum:]])(?:(?=\.\.\.)|(?!\.))(?!\()</string>
42084208
</dict>
42094209
<dict>
42104210
<key>name</key>
42114211
<string>keyword.operator.expression.of.tsx</string>
42124212
<key>match</key>
4213-
<string>(?&lt;![_$[:alnum:]])(?:(?&lt;=\.\.\.)|(?&lt;!\.))of(?![_$[:alnum:]])(?:(?=\.\.\.)|(?!\.))</string>
4213+
<string>(?&lt;![_$[:alnum:]])(?:(?&lt;=\.\.\.)|(?&lt;!\.))of(?![_$[:alnum:]])(?:(?=\.\.\.)|(?!\.))(?!\()</string>
42144214
</dict>
42154215
<dict>
42164216
<key>name</key>

tests/baselines/Issue628.baseline.txt

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
original file
2+
-----------------------------------
3+
of(1);
4+
-----------------------------------
5+
6+
Grammar: TypeScript.tmLanguage
7+
-----------------------------------
8+
>of(1);
9+
^^
10+
source.ts meta.function-call.ts entity.name.function.ts
11+
^
12+
source.ts meta.brace.round.ts
13+
^
14+
source.ts constant.numeric.decimal.ts
15+
^
16+
source.ts meta.brace.round.ts
17+
^
18+
source.ts punctuation.terminator.statement.ts

tests/cases/Issue628.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
of(1);

0 commit comments

Comments
 (0)