Skip to content

Commit e0fffbf

Browse files
committed
Consume single line comment endings for import declaration to correctly detect end of the import declaration
Fixes #774
1 parent 9b9b130 commit e0fffbf

File tree

6 files changed

+337
-1
lines changed

6 files changed

+337
-1
lines changed

TypeScript.YAML-tmLanguage

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1085,6 +1085,7 @@ repository:
10851085
'5': { name: keyword.operator.assignment.ts }
10861086
end: (?=;|$|^)
10871087
patterns:
1088+
- include: '#single-line-comment-consuming-line-ending'
10881089
- include: '#comment'
10891090
- match: ({{identifier}})\s*{{propertyAccess}}
10901091
captures:
@@ -1103,6 +1104,7 @@ repository:
11031104
'3': { name: keyword.control.import.ts }
11041105
end: (?<!{{lookBehindImport}})(?=;|$|^)
11051106
patterns:
1107+
- include: '#single-line-comment-consuming-line-ending'
11061108
- include: '#comment'
11071109
- include: '#string'
11081110
- begin: (?<={{lookBehindImport}})(?!\s*["'])

TypeScript.tmLanguage

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3476,6 +3476,10 @@
34763476
<string>(?=;|$|^)</string>
34773477
<key>patterns</key>
34783478
<array>
3479+
<dict>
3480+
<key>include</key>
3481+
<string>#single-line-comment-consuming-line-ending</string>
3482+
</dict>
34793483
<dict>
34803484
<key>include</key>
34813485
<string>#comment</string>
@@ -3540,6 +3544,10 @@
35403544
<string>(?&lt;!^import|[^\._$[:alnum:]]import)(?=;|$|^)</string>
35413545
<key>patterns</key>
35423546
<array>
3547+
<dict>
3548+
<key>include</key>
3549+
<string>#single-line-comment-consuming-line-ending</string>
3550+
</dict>
35433551
<dict>
35443552
<key>include</key>
35453553
<string>#comment</string>

TypeScriptReact.tmLanguage

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3498,6 +3498,10 @@
34983498
<string>(?=;|$|^)</string>
34993499
<key>patterns</key>
35003500
<array>
3501+
<dict>
3502+
<key>include</key>
3503+
<string>#single-line-comment-consuming-line-ending</string>
3504+
</dict>
35013505
<dict>
35023506
<key>include</key>
35033507
<string>#comment</string>
@@ -3562,6 +3566,10 @@
35623566
<string>(?&lt;!^import|[^\._$[:alnum:]]import)(?=;|$|^)</string>
35633567
<key>patterns</key>
35643568
<array>
3569+
<dict>
3570+
<key>include</key>
3571+
<string>#single-line-comment-consuming-line-ending</string>
3572+
</dict>
35653573
<dict>
35663574
<key>include</key>
35673575
<string>#comment</string>

tests/baselines/Issue485.baseline.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ Grammar: TypeScript.tmLanguage
2929
source.ts meta.import.ts
3030
^^
3131
source.ts meta.import.ts comment.line.double-slash.ts punctuation.definition.comment.ts
32-
^^^^^
32+
^^^^^^
3333
source.ts meta.import.ts comment.line.double-slash.ts
3434
>import b from 'b'
3535
^^^^^^

0 commit comments

Comments
 (0)