Skip to content

Commit 0a83d79

Browse files
committed
Issue: Commit on enter isn't working correctly for JS completions in VS
Fix: revert the change to always return true for isNewIdentifierLocation for JavaScript files. With recent Roslyn completion list changes and the new VS default statement completion settings to "Only use Tab or Enter to commit" this change is no longer required. There is no longer a completion on space issue for JavaScript in VS and the previous fix is stopping completion on enter from working correctly.
1 parent a633652 commit 0a83d79

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/services/completions.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ namespace ts.Completions {
5656
addRange(entries, keywordCompletions);
5757
}
5858

59-
return { isMemberCompletion, isNewIdentifierLocation: isNewIdentifierLocation || isSourceFileJavaScript(sourceFile), entries };
59+
return { isMemberCompletion, isNewIdentifierLocation: isNewIdentifierLocation, entries };
6060

6161
function getJavaScriptCompletionEntries(sourceFile: SourceFile, position: number, uniqueNames: Map<string>): CompletionEntry[] {
6262
const entries: CompletionEntry[] = [];

0 commit comments

Comments
 (0)