Skip to content

Commit 0dbd303

Browse files
committed
Fix the quick info on error types
1 parent 4781224 commit 0dbd303

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

src/compiler/checker.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1288,7 +1288,7 @@ module ts {
12881288
}
12891289

12901290
function writeTypeParameters(typeParameters: TypeParameter[], writer: SymbolWriter, enclosingDeclaration?: Node, flags?: TypeFormatFlags, typeStack?: Type[]) {
1291-
if (typeParameters) {
1291+
if (typeParameters && typeParameters.length) {
12921292
writePunctuation(writer, SyntaxKind.LessThanToken);
12931293
for (var i = 0; i < typeParameters.length; i++) {
12941294
if (i > 0) {

tests/baselines/reference/dontShowCompilerGeneratedMembers.errors.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,14 +2,14 @@ tests/cases/compiler/dontShowCompilerGeneratedMembers.ts(3,5): error TS1098: Typ
22
tests/cases/compiler/dontShowCompilerGeneratedMembers.ts(3,6): error TS1005: '(' expected.
33
tests/cases/compiler/dontShowCompilerGeneratedMembers.ts(3,6): error TS1139: Type parameter declaration expected.
44
tests/cases/compiler/dontShowCompilerGeneratedMembers.ts(4,1): error TS1109: Expression expected.
5-
tests/cases/compiler/dontShowCompilerGeneratedMembers.ts(1,5): error TS2322: Type 'number' is not assignable to type '{ <>(): any; x: number; }':
5+
tests/cases/compiler/dontShowCompilerGeneratedMembers.ts(1,5): error TS2322: Type 'number' is not assignable to type '{ (): any; x: number; }':
66
Property 'x' is missing in type 'Number'.
77

88

99
==== tests/cases/compiler/dontShowCompilerGeneratedMembers.ts (5 errors) ====
1010
var f: {
1111
~
12-
!!! error TS2322: Type 'number' is not assignable to type '{ <>(): any; x: number; }':
12+
!!! error TS2322: Type 'number' is not assignable to type '{ (): any; x: number; }':
1313
!!! error TS2322: Property 'x' is missing in type 'Number'.
1414
x: number;
1515
<-

tests/cases/fourslash_old/quickInfoOnErrorTypes1.ts renamed to tests/cases/fourslash/quickInfoOnErrorTypes1.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,4 +6,4 @@
66
////};
77

88
goTo.marker('A');
9-
verify.quickInfoIs('{ x: number; (): any; }', "", "f", "var");
9+
verify.quickInfoIs('(var) f: {\n (): any;\n x: number;\n}', "");

0 commit comments

Comments
 (0)