Fixed the + overload according to feedback

Author: sheetalkamat

src/services/services.ts

@@ -2717,7 +2717,7 @@ module ts {
                         }
                         callExpression = <CallExpression>location.parent;
 
-                        var candidateSignatures = <Signature[]>[];
+                        var candidateSignatures: Signature[] = [];
                         signature = typeResolver.getResolvedSignature(callExpression, candidateSignatures);
                         if (!signature && candidateSignatures.length) {
                             // Use the first candidate:
@@ -2934,13 +2934,9 @@ module ts {
                     displayParts.push(spacePart());
                     displayParts.push(punctuationPart(SyntaxKind.OpenParenToken));
                     displayParts.push(operatorPart(SyntaxKind.PlusToken));
-                    displayParts.push(spacePart());
                     displayParts.push(displayPart((allSignatures.length - 1).toString(), SymbolDisplayPartKind.numericLiteral));
                     displayParts.push(spacePart());
-                    displayParts.push(textPart("overload"));
-                    displayParts.push(punctuationPart(SyntaxKind.OpenParenToken));
-                    displayParts.push(textPart("s"));
-                    displayParts.push(punctuationPart(SyntaxKind.CloseParenToken));
+                    displayParts.push(textPart(allSignatures.length === 2 ? "overload" : "overloads"));
                     displayParts.push(punctuationPart(SyntaxKind.CloseParenToken));
                 }
                 documentation = signature.getDocumentationComment();

tests/cases/fourslash/commentsCommentParsing.ts

@@ -334,21 +334,21 @@ goTo.marker('25');
 verify.currentSignatureHelpDocCommentIs("fn f1 with number");
 verify.currentParameterHelpArgumentDocCommentIs("");
 goTo.marker('25q');
-verify.quickInfoIs("(function) f1(a: number): any (+ 1 overload(s))", "fn f1 with number");
+verify.quickInfoIs("(function) f1(a: number): any (+1 overload)", "fn f1 with number");
 goTo.marker('25aq');
 verify.quickInfoIs("(parameter) a: number", "");
 
 goTo.marker('26');
 verify.currentSignatureHelpDocCommentIs("");
 verify.currentParameterHelpArgumentDocCommentIs("");
 goTo.marker('26q');
-verify.quickInfoIs("(function) f1(b: string): any (+ 1 overload(s))", "");
+verify.quickInfoIs("(function) f1(b: string): any (+1 overload)", "");
 goTo.marker('26aq');
 verify.quickInfoIs("(parameter) b: string", "");
 
 goTo.marker('27');
 verify.completionListContains("multiply", "(function) multiply(a: number, b: number, c?: number, d?: any, e?: any): void", "This is multiplication function\n@anotherTag\n@anotherTag");
-verify.completionListContains("f1", "(function) f1(a: number): any (+ 1 overload(s))", "fn f1 with number");
+verify.completionListContains("f1", "(function) f1(a: number): any (+1 overload)", "fn f1 with number");
 
 goTo.marker('28');
 verify.currentSignatureHelpDocCommentIs("This is subtract function");