Skip to content

Commit 13e60bc

Browse files
committed
Use resources, rather than string literals, in test baselines
1 parent cb6037b commit 13e60bc

File tree

2 files changed

+10
-10
lines changed

2 files changed

+10
-10
lines changed

src/harness/unittests/extractRanges.ts

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -180,7 +180,7 @@ function f() {
180180
}
181181
`,
182182
[
183-
"Cannot extract range containing conditional return statement."
183+
refactor.extractSymbol.Messages.CannotExtractRangeContainingConditionalReturnStatement.message
184184
]);
185185

186186
testExtractRangeFailed("extractRangeFailed2",
@@ -199,7 +199,7 @@ function f() {
199199
}
200200
`,
201201
[
202-
"Cannot extract range containing conditional break or continue statements."
202+
refactor.extractSymbol.Messages.CannotExtractRangeContainingConditionalBreakOrContinueStatements.message
203203
]);
204204

205205
testExtractRangeFailed("extractRangeFailed3",
@@ -218,7 +218,7 @@ function f() {
218218
}
219219
`,
220220
[
221-
"Cannot extract range containing conditional break or continue statements."
221+
refactor.extractSymbol.Messages.CannotExtractRangeContainingConditionalBreakOrContinueStatements.message
222222
]);
223223

224224
testExtractRangeFailed("extractRangeFailed4",
@@ -237,7 +237,7 @@ function f() {
237237
}
238238
`,
239239
[
240-
"Cannot extract range containing labeled break or continue with target outside of the range."
240+
refactor.extractSymbol.Messages.CannotExtractRangeContainingLabeledBreakOrContinueStatementWithTargetOutsideOfTheRange.message
241241
]);
242242

243243
testExtractRangeFailed("extractRangeFailed5",
@@ -258,7 +258,7 @@ function f2() {
258258
}
259259
`,
260260
[
261-
"Cannot extract range containing conditional return statement."
261+
refactor.extractSymbol.Messages.CannotExtractRangeContainingConditionalReturnStatement.message
262262
]);
263263

264264
testExtractRangeFailed("extractRangeFailed6",
@@ -279,7 +279,7 @@ function f2() {
279279
}
280280
`,
281281
[
282-
"Cannot extract range containing conditional return statement."
282+
refactor.extractSymbol.Messages.CannotExtractRangeContainingConditionalReturnStatement.message
283283
]);
284284

285285
testExtractRangeFailed("extractRangeFailed7",
@@ -292,7 +292,7 @@ while (x) {
292292
}
293293
`,
294294
[
295-
"Cannot extract range containing conditional break or continue statements."
295+
refactor.extractSymbol.Messages.CannotExtractRangeContainingConditionalBreakOrContinueStatements.message
296296
]);
297297

298298
testExtractRangeFailed("extractRangeFailed8",
@@ -305,7 +305,7 @@ switch (x) {
305305
}
306306
`,
307307
[
308-
"Cannot extract range containing conditional break or continue statements."
308+
refactor.extractSymbol.Messages.CannotExtractRangeContainingConditionalBreakOrContinueStatements.message
309309
]);
310310

311311
testExtractRangeFailed("extractRangeFailed9",
@@ -314,6 +314,6 @@ switch (x) {
314314
"Cannot extract empty range."
315315
]);
316316

317-
testExtractRangeFailed("extract-method-not-for-token-expression-statement", `[#|a|]`, ["Select more than a single identifier."]);
317+
testExtractRangeFailed("extract-method-not-for-token-expression-statement", `[#|a|]`, [refactor.extractSymbol.Messages.CannotExtractIdentifier.message]);
318318
});
319319
}

src/services/refactors/extractSymbol.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,7 @@ namespace ts.refactor.extractSymbol {
117117
}
118118

119119
// Move these into diagnostic messages if they become user-facing
120-
namespace Messages {
120+
export namespace Messages {
121121
function createMessage(message: string): DiagnosticMessage {
122122
return { message, code: 0, category: DiagnosticCategory.Message, key: message };
123123
}

0 commit comments

Comments
 (0)