Merge pull request #9305 from RyanCavanaugh/fix9293

Properly detect circular constructor-declared `this` properties (JS)

Author: RyanCavanaugh

src/compiler/checker.ts

@@ -3151,23 +3151,29 @@ namespace ts {
                 if (declaration.kind === SyntaxKind.ExportAssignment) {
                     return links.type = checkExpression((<ExportAssignment>declaration).expression);
                 }
-                // Handle module.exports = expr
+                // Handle variable, parameter or property
+                if (!pushTypeResolution(symbol, TypeSystemPropertyName.Type)) {
+                    return unknownType;
+                }
+
+                let type: Type = undefined;
+                // Handle module.exports = expr or this.p = expr
                 if (declaration.kind === SyntaxKind.BinaryExpression) {
-                    return links.type = getUnionType(map(symbol.declarations, (decl: BinaryExpression) => checkExpressionCached(decl.right)));
+                    type = getUnionType(map(symbol.declarations, (decl: BinaryExpression) => checkExpressionCached(decl.right)));
                 }
-                if (declaration.kind === SyntaxKind.PropertyAccessExpression) {
+                else if (declaration.kind === SyntaxKind.PropertyAccessExpression) {
                     // Declarations only exist for property access expressions for certain
                     // special assignment kinds
                     if (declaration.parent.kind === SyntaxKind.BinaryExpression) {
-                        // Handle exports.p = expr or this.p = expr or className.prototype.method = expr
-                        return links.type = checkExpressionCached((<BinaryExpression>declaration.parent).right);
+                        // Handle exports.p = expr  or className.prototype.method = expr
+                        type = checkExpressionCached((<BinaryExpression>declaration.parent).right);
                     }
                 }
-                // Handle variable, parameter or property
-                if (!pushTypeResolution(symbol, TypeSystemPropertyName.Type)) {
-                    return unknownType;
+
+                if (type === undefined) {
+                    type = getWidenedTypeForVariableLikeDeclaration(<VariableLikeDeclaration>declaration, /*reportErrors*/ true);
                 }
-                let type = getWidenedTypeForVariableLikeDeclaration(<VariableLikeDeclaration>declaration, /*reportErrors*/ true);
+
                 if (!popTypeResolution()) {
                     if ((<VariableLikeDeclaration>symbol.valueDeclaration).type) {
                         // Variable has type annotation that circularly references the variable itself

tests/baselines/reference/constDeclarations-useBeforeDefinition2.symbols

@@ -0,0 +1,17 @@
+=== tests/cases/compiler/foo.js ===
+
+export class StackOverflowTest {
+>StackOverflowTest : Symbol(StackOverflowTest, Decl(foo.js, 0, 0))
+
+  constructor () {
+    this.testStackOverflow = this.testStackOverflow.bind(this)
+>this.testStackOverflow : Symbol(StackOverflowTest.testStackOverflow, Decl(foo.js, 2, 18))
+>this : Symbol(StackOverflowTest, Decl(foo.js, 0, 0))
+>testStackOverflow : Symbol(StackOverflowTest.testStackOverflow, Decl(foo.js, 2, 18))
+>this.testStackOverflow : Symbol(StackOverflowTest.testStackOverflow, Decl(foo.js, 2, 18))
+>this : Symbol(StackOverflowTest, Decl(foo.js, 0, 0))
+>testStackOverflow : Symbol(StackOverflowTest.testStackOverflow, Decl(foo.js, 2, 18))
+>this : Symbol(StackOverflowTest, Decl(foo.js, 0, 0))
+  }
+}
+

tests/baselines/reference/constDeclarations-useBeforeDefinition2.types

@@ -0,0 +1,21 @@
+=== tests/cases/compiler/foo.js ===
+
+export class StackOverflowTest {
+>StackOverflowTest : StackOverflowTest
+
+  constructor () {
+    this.testStackOverflow = this.testStackOverflow.bind(this)
+>this.testStackOverflow = this.testStackOverflow.bind(this) : any
+>this.testStackOverflow : any
+>this : this
+>testStackOverflow : any
+>this.testStackOverflow.bind(this) : any
+>this.testStackOverflow.bind : any
+>this.testStackOverflow : any
+>this : this
+>testStackOverflow : any
+>bind : any
+>this : this
+  }
+}
+