rename convert to named parameters (#30401)

Author: gabritto

src/compiler/diagnosticMessages.json

@@ -4927,7 +4927,7 @@
         "category": "Message",
         "code": 95074
     },
-    "Convert to named parameters": {
+    "Convert parameters to destructured object": {
         "category": "Message",
         "code": 95075
     }

src/services/refactors/convertToNamedParameters.ts renamed to src/services/refactors/convertParamsToDestructuredObject.ts

@@ -1,6 +1,6 @@
 /* @internal */
-namespace ts.refactor.convertToNamedParameters {
-    const refactorName = "Convert to named parameters";
+namespace ts.refactor.convertParamsToDestructuredObject {
+    const refactorName = "Convert parameters to destructured object";
     const minimumParameterLength = 2;
     registerRefactor(refactorName, { getEditsForAction, getAvailableActions });
 
@@ -12,7 +12,7 @@ namespace ts.refactor.convertToNamedParameters {
         const functionDeclaration = getFunctionDeclarationAtPosition(file, startPosition, context.program.getTypeChecker());
         if (!functionDeclaration) return emptyArray;
 
-        const description = getLocaleSpecificMessage(Diagnostics.Convert_to_named_parameters);
+        const description = getLocaleSpecificMessage(Diagnostics.Convert_parameters_to_destructured_object);
         return [{
             name: refactorName,
             description,

src/services/tsconfig.json

@@ -84,7 +84,7 @@
         "refactors/generateGetAccessorAndSetAccessor.ts",
         "refactors/moveToNewFile.ts",
         "refactors/addOrRemoveBracesToArrowFunction.ts",
-        "refactors/convertToNamedParameters.ts",
+        "refactors/convertParamsToDestructuredObject.ts",
         "services.ts",
         "breakpoints.ts",
         "transform.ts",

tests/cases/fourslash/refactorConvertToNamedParameters_allParamsOptional.ts renamed to tests/cases/fourslash/refactorConvertParamsToDestructuredObject_allParamsOptional.ts

@@ -7,9 +7,9 @@
 
 goTo.select("a", "b");
 edit.applyRefactor({
-    refactorName: "Convert to named parameters",
-    actionName: "Convert to named parameters",
-    actionDescription: "Convert to named parameters",
+    refactorName: "Convert parameters to destructured object",
+    actionName: "Convert parameters to destructured object",
+    actionDescription: "Convert parameters to destructured object",
     newContent: `function f({ a, b = "1" }: { a?: number; b?: string; } = {}): string {
     return b;
 }

tests/cases/fourslash/refactorConvertToNamedParameters_arrowFunction.ts renamed to tests/cases/fourslash/refactorConvertParamsToDestructuredObject_arrowFunction.ts

@@ -5,9 +5,9 @@
 
 goTo.select("a", "b");
 edit.applyRefactor({
-    refactorName: "Convert to named parameters",
-    actionName: "Convert to named parameters",
-    actionDescription: "Convert to named parameters",
+    refactorName: "Convert parameters to destructured object",
+    actionName: "Convert parameters to destructured object",
+    actionDescription: "Convert parameters to destructured object",
     newContent: `const foo = ({ a, b }: { a: number; b: number; }) => { };
 foo({ a: 1, b: 2 });`
 });

tests/cases/fourslash/refactorConvertToNamedParameters_arrowFunctionWithContextualType.ts renamed to tests/cases/fourslash/refactorConvertParamsToDestructuredObject_arrowFunctionWithType.ts

@@ -4,4 +4,4 @@
 ////foo(1, 2);
 
 goTo.select("a", "b");
-verify.not.refactorAvailable("Convert to named parameters");
+verify.not.refactorAvailable("Convert parameters to destructured object");

tests/cases/fourslash/refactorConvertToNamedParameters_callComments.ts renamed to tests/cases/fourslash/refactorConvertParamsToDestructuredObject_callComments.ts

@@ -7,9 +7,9 @@
 
 goTo.select("a", "b");
 edit.applyRefactor({
-    refactorName: "Convert to named parameters",
-    actionName: "Convert to named parameters",
-    actionDescription: "Convert to named parameters",
+    refactorName: "Convert parameters to destructured object",
+    actionName: "Convert parameters to destructured object",
+    actionDescription: "Convert parameters to destructured object",
     newContent: `function foo({ a, b, rest = [] }: { a: number; b: number; rest?: number[]; }) {
     return a + b;
 }

tests/cases/fourslash/refactorConvertToNamedParameters_callComments2.ts renamed to tests/cases/fourslash/refactorConvertParamsToDestructuredObject_callComments2.ts

@@ -16,9 +16,9 @@
 goTo.select("a", "b");
 /* The expected content is currently wrong. The new argument object has the wrong formatting. */
 edit.applyRefactor({
-    refactorName: "Convert to named parameters",
-    actionName: "Convert to named parameters",
-    actionDescription: "Convert to named parameters",
+    refactorName: "Convert parameters to destructured object",
+    actionName: "Convert parameters to destructured object",
+    actionDescription: "Convert parameters to destructured object",
     newContent: `function foo({ a, b, rest = [] }: { a: number; b: number; rest?: number[]; }) {
     return a + b;
 }

tests/cases/fourslash/refactorConvertToNamedParameters_chainedCall.ts renamed to tests/cases/fourslash/refactorConvertParamsToDestructuredObject_chainedCall.ts

@@ -7,9 +7,9 @@
 
 goTo.select("a", "b");
 edit.applyRefactor({
-    refactorName: "Convert to named parameters",
-    actionName: "Convert to named parameters",
-    actionDescription: "Convert to named parameters",
+    refactorName: "Convert parameters to destructured object",
+    actionName: "Convert parameters to destructured object",
+    actionDescription: "Convert parameters to destructured object",
     newContent: `function foo({ a, b }: { a: number; b: number; }) {
     return { bar: () => a + b };
 }

tests/cases/fourslash/refactorConvertToNamedParameters_classDeclarationAliasing.ts renamed to tests/cases/fourslash/refactorConvertParamsToDestructuredObject_classDeclarationAliasing.ts

@@ -9,9 +9,9 @@
 goTo.select("a", "b");
 // Refactor should not make changes
 edit.applyRefactor({
-    refactorName: "Convert to named parameters",
-    actionName: "Convert to named parameters",
-    actionDescription: "Convert to named parameters",
+    refactorName: "Convert parameters to destructured object",
+    actionName: "Convert parameters to destructured object",
+    actionDescription: "Convert parameters to destructured object",
     newContent: `class Foo {
     constructor(a: number, b: number) { }
 }