Merge pull request #28456 from Microsoft/nonExperimentalBigInt

BigInt shouldn't be considered experimental

Author: DanielRosenwasser

src/compiler/checker.ts

@@ -30642,13 +30642,10 @@ namespace ts {
                 isPrefixUnaryExpression(node.parent) && isLiteralTypeNode(node.parent.parent);
             if (!literalType) {
                 if (languageVersion < ScriptTarget.ESNext) {
-                    if (grammarErrorOnNode(node, Diagnostics.BigInt_literals_are_not_available_when_targetting_lower_than_ESNext)) {
+                    if (grammarErrorOnNode(node, Diagnostics.BigInt_literals_are_not_available_when_targeting_lower_than_ESNext)) {
                         return true;
                     }
                 }
-                if (!compilerOptions.experimentalBigInt) {
-                    return grammarErrorOnNode(node, Diagnostics.Experimental_support_for_BigInt_is_a_feature_that_is_subject_to_change_in_a_future_release_Set_the_experimentalBigInt_option_to_remove_this_warning);
-                }
             }
             return false;
         }

src/compiler/commandLineParser.ts

@@ -584,12 +584,6 @@ namespace ts {
             category: Diagnostics.Experimental_Options,
             description: Diagnostics.Enables_experimental_support_for_emitting_type_metadata_for_decorators
         },
-        {
-            name: "experimentalBigInt",
-            type: "boolean",
-            category: Diagnostics.Experimental_Options,
-            description: Diagnostics.Enables_experimental_support_for_ESNext_BigInt_literals
-        },
 
         // Advanced
         {

src/compiler/diagnosticMessages.json

@@ -1011,10 +1011,6 @@
         "category": "Message",
         "code": 1350
     },
-    "Experimental support for BigInt is a feature that is subject to change in a future release. Set the 'experimentalBigInt' option to remove this warning.": {
-        "category": "Error",
-        "code": 1351
-    },
 
     "Duplicate identifier '{0}'.": {
         "category": "Error",
@@ -2505,7 +2501,7 @@
         "category": "Error",
         "code": 2736
     },
-    "BigInt literals are not available when targetting lower than ESNext.": {
+    "BigInt literals are not available when targeting lower than ESNext.": {
         "category": "Error",
         "code": 2737
     },
@@ -3933,10 +3929,6 @@
         "category": "Error",
         "code": 6370
     },
-    "Enables experimental support for ESNext BigInt literals.": {
-        "category": "Message",
-        "code": 6371
-    },
 
     "The expected type comes from property '{0}' which is declared here on type '{1}'": {
         "category": "Message",

src/compiler/types.ts

@@ -4495,7 +4495,6 @@ namespace ts {
         downlevelIteration?: boolean;
         emitBOM?: boolean;
         emitDecoratorMetadata?: boolean;
-        experimentalBigInt?: boolean;
         experimentalDecorators?: boolean;
         forceConsistentCasingInFileNames?: boolean;
         /*@internal*/help?: boolean;

tests/baselines/reference/api/tsserverlibrary.d.ts

@@ -2450,7 +2450,6 @@ declare namespace ts {
         downlevelIteration?: boolean;
         emitBOM?: boolean;
         emitDecoratorMetadata?: boolean;
-        experimentalBigInt?: boolean;
         experimentalDecorators?: boolean;
         forceConsistentCasingInFileNames?: boolean;
         importHelpers?: boolean;

tests/baselines/reference/api/typescript.d.ts

@@ -2450,7 +2450,6 @@ declare namespace ts {
         downlevelIteration?: boolean;
         emitBOM?: boolean;
         emitDecoratorMetadata?: boolean;
-        experimentalBigInt?: boolean;
         experimentalDecorators?: boolean;
         forceConsistentCasingInFileNames?: boolean;
         importHelpers?: boolean;

tests/baselines/reference/bigIntWithTargetES3.errors.txt

@@ -0,0 +1,21 @@
+tests/cases/compiler/bigIntWithTargetES3.ts(5,22): error TS2737: BigInt literals are not available when targeting lower than ESNext.
+tests/cases/compiler/bigIntWithTargetES3.ts(5,29): error TS2737: BigInt literals are not available when targeting lower than ESNext.
+tests/cases/compiler/bigIntWithTargetES3.ts(5,39): error TS2737: BigInt literals are not available when targeting lower than ESNext.
+tests/cases/compiler/bigIntWithTargetES3.ts(5,48): error TS2737: BigInt literals are not available when targeting lower than ESNext.
+
+
+==== tests/cases/compiler/bigIntWithTargetES3.ts (4 errors) ====
+    const normalNumber = 123; // should not error
+    let bigintType: bigint; // should not error
+    let bigintLiteralType: 123n; // should not error when used as type
+    let bigintNegativeLiteralType: -123n; // should not error when used as type
+    const bigintNumber = 123n * 0b1111n + 0o444n * 0x7fn; // each literal should error
+                         ~~~~
+!!! error TS2737: BigInt literals are not available when targeting lower than ESNext.
+                                ~~~~~~~
+!!! error TS2737: BigInt literals are not available when targeting lower than ESNext.
+                                          ~~~~~~
+!!! error TS2737: BigInt literals are not available when targeting lower than ESNext.
+                                                   ~~~~~
+!!! error TS2737: BigInt literals are not available when targeting lower than ESNext.
+    

tests/baselines/reference/bigIntWithTargetES3.js

@@ -0,0 +1,14 @@
+//// [bigIntWithTargetES3.ts]
+const normalNumber = 123; // should not error
+let bigintType: bigint; // should not error
+let bigintLiteralType: 123n; // should not error when used as type
+let bigintNegativeLiteralType: -123n; // should not error when used as type
+const bigintNumber = 123n * 0b1111n + 0o444n * 0x7fn; // each literal should error
+
+
+//// [bigIntWithTargetES3.js]
+var normalNumber = 123; // should not error
+var bigintType; // should not error
+var bigintLiteralType; // should not error when used as type
+var bigintNegativeLiteralType; // should not error when used as type
+var bigintNumber = 123n * 15n + 292n * 0x7fn; // each literal should error

tests/baselines/reference/bigIntWithTargetES3.symbols

@@ -0,0 +1,16 @@
+=== tests/cases/compiler/bigIntWithTargetES3.ts ===
+const normalNumber = 123; // should not error
+>normalNumber : Symbol(normalNumber, Decl(bigIntWithTargetES3.ts, 0, 5))
+
+let bigintType: bigint; // should not error
+>bigintType : Symbol(bigintType, Decl(bigIntWithTargetES3.ts, 1, 3))
+
+let bigintLiteralType: 123n; // should not error when used as type
+>bigintLiteralType : Symbol(bigintLiteralType, Decl(bigIntWithTargetES3.ts, 2, 3))
+
+let bigintNegativeLiteralType: -123n; // should not error when used as type
+>bigintNegativeLiteralType : Symbol(bigintNegativeLiteralType, Decl(bigIntWithTargetES3.ts, 3, 3))
+
+const bigintNumber = 123n * 0b1111n + 0o444n * 0x7fn; // each literal should error
+>bigintNumber : Symbol(bigintNumber, Decl(bigIntWithTargetES3.ts, 4, 5))
+

tests/baselines/reference/bigIntWithTargetES3.types

@@ -0,0 +1,26 @@
+=== tests/cases/compiler/bigIntWithTargetES3.ts ===
+const normalNumber = 123; // should not error
+>normalNumber : 123
+>123 : 123
+
+let bigintType: bigint; // should not error
+>bigintType : bigint
+
+let bigintLiteralType: 123n; // should not error when used as type
+>bigintLiteralType : 123n
+
+let bigintNegativeLiteralType: -123n; // should not error when used as type
+>bigintNegativeLiteralType : -123n
+>-123n : -123n
+>123n : 123n
+
+const bigintNumber = 123n * 0b1111n + 0o444n * 0x7fn; // each literal should error
+>bigintNumber : bigint
+>123n * 0b1111n + 0o444n * 0x7fn : bigint
+>123n * 0b1111n : bigint
+>123n : 123n
+>0b1111n : 15n
+>0o444n * 0x7fn : bigint
+>0o444n : 292n
+>0x7fn : 127n
+