Add skip lib check to many tests (#18935)

weswigham · web-flow · commit 25c3b99f29e2 · 2017-10-04T13:14:05.000-07:00
* Add skip lib check to many tests, do not include unit test duration in profiler duration

* Add a few more skipLibCheck flags

* A few more

* Add more skip lib check flags
diff --git a/src/harness/parallel/worker.ts b/src/harness/parallel/worker.ts
@@ -12,6 +12,11 @@ namespace Harness.Parallel.Worker {
             testList.length = 0;
         }
         reportedUnitTests = true;
+        if (testList.length) {
+            // Execute unit tests
+            testList.forEach(({ name, callback, kind }) => executeCallback(name, callback, kind));
+            testList.length = 0;
+        }
         const start = +(new Date());
         runner.initializeTests();
         testList.forEach(({ name, callback, kind }) => executeCallback(name, callback, kind));
diff --git a/tests/cases/compiler/APISample_compile.ts b/tests/cases/compiler/APISample_compile.ts
@@ -1,4 +1,5 @@
 ﻿// @module: commonjs
+// @skipLibCheck: true
 // @includebuiltfile: typescript_standalone.d.ts
 // @noImplicitAny:true
 // @strictNullChecks:true
diff --git a/tests/cases/compiler/APISample_jsdoc.ts b/tests/cases/compiler/APISample_jsdoc.ts
@@ -1,4 +1,5 @@
 // @module: commonjs
+// @skipLibCheck: true
 // @includebuiltfile: typescript_standalone.d.ts
 // @strict:true
 
diff --git a/tests/cases/compiler/APISample_linter.ts b/tests/cases/compiler/APISample_linter.ts
@@ -1,4 +1,5 @@
 ﻿// @module: commonjs
+// @skipLibCheck: true
 // @includebuiltfile: typescript_standalone.d.ts
 // @noImplicitAny:true
 // @strictNullChecks:true
diff --git a/tests/cases/compiler/APISample_parseConfig.ts b/tests/cases/compiler/APISample_parseConfig.ts
@@ -1,4 +1,5 @@
 // @module: commonjs
+// @skipLibCheck: true
 // @includebuiltfile: typescript_standalone.d.ts
 // @noImplicitAny:true
 // @strictNullChecks:true
diff --git a/tests/cases/compiler/APISample_transform.ts b/tests/cases/compiler/APISample_transform.ts
@@ -1,4 +1,5 @@
 ﻿// @module: commonjs
+// @skipLibCheck: true
 // @includebuiltfile: typescript_standalone.d.ts
 // @noImplicitAny:true
 // @strictNullChecks:true
diff --git a/tests/cases/compiler/APISample_watcher.ts b/tests/cases/compiler/APISample_watcher.ts
@@ -1,4 +1,5 @@
 ﻿// @module: commonjs
+// @skipLibCheck: true
 // @includebuiltfile: typescript_standalone.d.ts
 // @noImplicitAny:true
 // @strictNullChecks:true
diff --git a/tests/cases/compiler/contextuallyTypeArgumentsKeyword.ts b/tests/cases/compiler/contextuallyTypeArgumentsKeyword.ts
@@ -1,6 +1,7 @@
 // @noEmit: true
 // @allowJs: true
 // @checkJs: true
+// @skipLibCheck: true
 // @lib: es2017, dom
 // @Filename: foo.js
 // Repro for #16585
diff --git a/tests/cases/compiler/correctOrderOfPromiseMethod.ts b/tests/cases/compiler/correctOrderOfPromiseMethod.ts
@@ -1,3 +1,4 @@
+// @skipLibCheck: true
 // @lib: dom, es7
 
 interface A {
diff --git a/tests/cases/compiler/metadataOfEventAlias.ts b/tests/cases/compiler/metadataOfEventAlias.ts
@@ -1,6 +1,7 @@
 // @experimentalDecorators: true
 // @emitDecoratorMetadata: true
 // @target: es5
+// @skipLibCheck: true
 // @includeBuiltFile: lib.d.ts
 
 // @filename: event.ts
diff --git a/tests/cases/compiler/modularizeLibrary_Dom.iterable.ts b/tests/cases/compiler/modularizeLibrary_Dom.iterable.ts
@@ -1,4 +1,5 @@
-﻿// @lib: es6,dom,dom.iterable
+﻿// @skipLibCheck: true
+// @lib: es6,dom,dom.iterable
 // @target: es6
 
 for (const element of document.getElementsByTagName("a")) {
diff --git a/tests/cases/compiler/symbolMergeValueAndImportedType.ts b/tests/cases/compiler/symbolMergeValueAndImportedType.ts
@@ -1,5 +1,6 @@
 // @target: es2015
 // @module: commonjs
+// @skipLibCheck: true
 // @lib: es2015,dom
 // @filename: main.ts
 import { X } from "./other";
diff --git a/tests/cases/conformance/jsx/checkJsxChildrenProperty12.tsx b/tests/cases/conformance/jsx/checkJsxChildrenProperty12.tsx
@@ -1,6 +1,7 @@
 // @filename: file.tsx
 // @jsx: preserve
 // @noLib: true
+// @skipLibCheck: true
 // @libFiles: react.d.ts,lib.d.ts
 
 import React = require('react');
diff --git a/tests/cases/conformance/jsx/checkJsxChildrenProperty3.tsx b/tests/cases/conformance/jsx/checkJsxChildrenProperty3.tsx
@@ -1,6 +1,7 @@
 // @filename: file.tsx
 // @jsx: preserve
 // @noLib: true
+// @skipLibCheck: true
 // @libFiles: react.d.ts,lib.d.ts
 
 import React = require('react');
diff --git a/tests/cases/conformance/jsx/checkJsxChildrenProperty5.tsx b/tests/cases/conformance/jsx/checkJsxChildrenProperty5.tsx
@@ -1,6 +1,7 @@
 // @filename: file.tsx
 // @jsx: preserve
 // @noLib: true
+// @skipLibCheck: true
 // @libFiles: react.d.ts,lib.d.ts
 
 import React = require('react');
diff --git a/tests/cases/conformance/jsx/correctlyMarkAliasAsReferences1.tsx b/tests/cases/conformance/jsx/correctlyMarkAliasAsReferences1.tsx
@@ -1,6 +1,7 @@
 // @target: es2017
 // @jsx: react
 // @moduleResolution: node
+// @skipLibCheck: true
 // @libFiles: react.d.ts,lib.d.ts
 
 // @filename: declaration.d.ts
diff --git a/tests/cases/conformance/jsx/correctlyMarkAliasAsReferences2.tsx b/tests/cases/conformance/jsx/correctlyMarkAliasAsReferences2.tsx
@@ -1,6 +1,7 @@
 // @target: es2017
 // @jsx: react
 // @moduleResolution: node
+// @skipLibCheck: true
 // @libFiles: react.d.ts,lib.d.ts
 
 // @filename: declaration.d.ts
diff --git a/tests/cases/conformance/jsx/correctlyMarkAliasAsReferences3.tsx b/tests/cases/conformance/jsx/correctlyMarkAliasAsReferences3.tsx
@@ -2,6 +2,7 @@
 // @jsx: react
 // @moduleResolution: node
 // @noImplicitAny: true
+// @skipLibCheck: true
 // @libFiles: react.d.ts,lib.d.ts
 
 // @filename: declaration.d.ts
diff --git a/tests/cases/conformance/jsx/correctlyMarkAliasAsReferences4.tsx b/tests/cases/conformance/jsx/correctlyMarkAliasAsReferences4.tsx
@@ -1,6 +1,7 @@
 // @target: es2017
 // @jsx: react
 // @moduleResolution: node
+// @skipLibCheck: true
 // @libFiles: react.d.ts,lib.d.ts
 
 // @filename: declaration.d.ts
diff --git a/tests/cases/conformance/jsx/tsxGenericAttributesType4.tsx b/tests/cases/conformance/jsx/tsxGenericAttributesType4.tsx
@@ -1,6 +1,7 @@
 // @filename: file.tsx
 // @jsx: preserve
 // @noLib: true
+// @skipLibCheck: true
 // @libFiles: react.d.ts,lib.d.ts
 
 import React = require('react');
diff --git a/tests/cases/conformance/jsx/tsxSfcReturnNull.tsx b/tests/cases/conformance/jsx/tsxSfcReturnNull.tsx
@@ -2,6 +2,7 @@
 // @jsx: preserve
 // @module: amd
 // @noLib: true
+// @skipLibCheck: true
 // @libFiles: react.d.ts,lib.d.ts
 
 import React = require('react');
diff --git a/tests/cases/conformance/jsx/tsxSpreadAttributesResolution3.tsx b/tests/cases/conformance/jsx/tsxSpreadAttributesResolution3.tsx
@@ -1,6 +1,7 @@
 // @filename: file.tsx
 // @jsx: preserve
 // @noLib: true
+// @skipLibCheck: true
 // @libFiles: react.d.ts,lib.d.ts
 
 import React = require('react');
diff --git a/tests/cases/conformance/jsx/tsxStatelessFunctionComponentOverload1.tsx b/tests/cases/conformance/jsx/tsxStatelessFunctionComponentOverload1.tsx
@@ -2,6 +2,7 @@
 // @jsx: preserve
 // @module: amd
 // @noLib: true
+// @skipLibCheck: true
 // @libFiles: react.d.ts,lib.d.ts
 
 import React = require('react')
diff --git a/tests/cases/conformance/jsx/tsxStatelessFunctionComponentOverload2.tsx b/tests/cases/conformance/jsx/tsxStatelessFunctionComponentOverload2.tsx
@@ -2,6 +2,7 @@
 // @jsx: preserve
 // @module: amd
 // @noLib: true
+// @skipLibCheck: true
 // @libFiles: react.d.ts,lib.d.ts
 
 import React = require('react')
diff --git a/tests/cases/conformance/jsx/tsxStatelessFunctionComponentOverload6.tsx b/tests/cases/conformance/jsx/tsxStatelessFunctionComponentOverload6.tsx
@@ -2,6 +2,7 @@
 // @jsx: preserve
 // @module: amd
 // @noLib: true
+// @skipLibCheck: true
 // @libFiles: react.d.ts,lib.d.ts
 
 import React = require('react')
diff --git a/tests/cases/conformance/jsx/tsxStatelessFunctionComponents1.tsx b/tests/cases/conformance/jsx/tsxStatelessFunctionComponents1.tsx
@@ -1,6 +1,7 @@
 // @filename: file.tsx
 // @jsx: preserve
 // @noLib: true
+// @skipLibCheck: true
 // @libFiles: react.d.ts,lib.d.ts
 
 function EmptyPropSFC() {
diff --git a/tests/cases/conformance/jsx/tsxStatelessFunctionComponentsWithTypeArguments2.tsx b/tests/cases/conformance/jsx/tsxStatelessFunctionComponentsWithTypeArguments2.tsx
@@ -2,6 +2,7 @@
 // @jsx: preserve
 // @module: amd
 // @noLib: true
+// @skipLibCheck: true
 // @libFiles: react.d.ts,lib.d.ts
 
 import React = require('react')
diff --git a/tests/cases/conformance/jsx/tsxStatelessFunctionComponentsWithTypeArguments3.tsx b/tests/cases/conformance/jsx/tsxStatelessFunctionComponentsWithTypeArguments3.tsx
@@ -2,6 +2,7 @@
 // @jsx: preserve
 // @module: amd
 // @noLib: true
+// @skipLibCheck: true
 // @libFiles: react.d.ts,lib.d.ts
 
 import React = require('react')
diff --git a/tests/cases/conformance/jsx/tsxUnionTypeComponent1.tsx b/tests/cases/conformance/jsx/tsxUnionTypeComponent1.tsx
@@ -1,6 +1,7 @@
 // @filename: file.tsx
 // @jsx: react
 // @noLib: true
+// @skipLibCheck: true
 // @libFiles: react.d.ts,lib.d.ts
 
 import React = require('react');
diff --git a/tests/cases/conformance/parser/ecmascriptnext/asyncGenerators/parser.asyncGenerators.objectLiteralMethods.esnext.ts b/tests/cases/conformance/parser/ecmascriptnext/asyncGenerators/parser.asyncGenerators.objectLiteralMethods.esnext.ts
@@ -1,4 +1,5 @@
 // @target: esnext
+// @skipLibCheck: true
 // @lib: esnext
 // @noEmit: true
 // @filename: methodIsOk.ts

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,5 @@`
`1`	`1`	`// @module: commonjs`
	`2`	`+// @skipLibCheck: true`
`2`	`3`	`// @includebuiltfile: typescript_standalone.d.ts`
`3`	`4`	`// @noImplicitAny:true`
`4`	`5`	`// @strictNullChecks:true`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,4 @@`
	`1`	`+// @skipLibCheck: true`
`1`	`2`	`// @lib: dom, es7`
`2`	`3`
`3`	`4`	`interface A {`