Skip to content

Commit 3b058a4

Browse files
committed
fix compile errors, accept baselines
1 parent 96480b5 commit 3b058a4

File tree

5 files changed

+15
-15
lines changed

5 files changed

+15
-15
lines changed

src/compiler/program.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -599,7 +599,7 @@ namespace ts {
599599
const cachedSemanticDiagnosticsForFile: DiagnosticCache<Diagnostic> = {};
600600
const cachedDeclarationDiagnosticsForFile: DiagnosticCache<DiagnosticWithLocation> = {};
601601

602-
let resolvedTypeReferenceDirectives = createMap<ResolvedTypeReferenceDirective>();
602+
let resolvedTypeReferenceDirectives = createMap<ResolvedTypeReferenceDirective | undefined>();
603603
let fileProcessingDiagnostics = createDiagnosticCollection();
604604

605605
// The below settings are to track if a .js file should be add to the program if loaded via searching under node_modules.
@@ -656,7 +656,7 @@ namespace ts {
656656
resolveModuleNamesWorker = (moduleNames, containingFile, _reusedNames, redirectedReference) => loadWithLocalCache<ResolvedModuleFull>(Debug.assertEachDefined(moduleNames), containingFile, redirectedReference, loader);
657657
}
658658

659-
let resolveTypeReferenceDirectiveNamesWorker: (typeDirectiveNames: string[], containingFile: string, redirectedReference?: ResolvedProjectReference) => ResolvedTypeReferenceDirective[];
659+
let resolveTypeReferenceDirectiveNamesWorker: (typeDirectiveNames: string[], containingFile: string, redirectedReference?: ResolvedProjectReference) => (ResolvedTypeReferenceDirective | undefined)[];
660660
if (host.resolveTypeReferenceDirectives) {
661661
resolveTypeReferenceDirectiveNamesWorker = (typeDirectiveNames, containingFile, redirectedReference) => host.resolveTypeReferenceDirectives!(Debug.assertEachDefined(typeDirectiveNames), containingFile, redirectedReference);
662662
}
@@ -2335,7 +2335,7 @@ namespace ts {
23352335
}
23362336
}
23372337

2338-
function processTypeReferenceDirective(typeReferenceDirective: string, resolvedTypeReferenceDirective: ResolvedTypeReferenceDirective,
2338+
function processTypeReferenceDirective(typeReferenceDirective: string, resolvedTypeReferenceDirective?: ResolvedTypeReferenceDirective,
23392339
refFile?: SourceFile, refPos?: number, refEnd?: number): void {
23402340

23412341
// If we already found this library as a primary reference - nothing to do

src/compiler/types.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2714,7 +2714,7 @@ namespace ts {
27142714
// It is used to resolve module names in the checker.
27152715
// Content of this field should never be used directly - use getResolvedModuleFileName/setResolvedModuleFileName functions instead
27162716
/* @internal */ resolvedModules?: Map<ResolvedModuleFull | undefined>;
2717-
/* @internal */ resolvedTypeReferenceDirectiveNames: Map<ResolvedTypeReferenceDirective>;
2717+
/* @internal */ resolvedTypeReferenceDirectiveNames: Map<ResolvedTypeReferenceDirective | undefined>;
27182718
/* @internal */ imports: ReadonlyArray<StringLiteralLike>;
27192719
/**
27202720
* When a file's references are redirected due to project reference directives,
@@ -2889,7 +2889,7 @@ namespace ts {
28892889
/* @internal */ getTypeCount(): number;
28902890

28912891
/* @internal */ getFileProcessingDiagnostics(): DiagnosticCollection;
2892-
/* @internal */ getResolvedTypeReferenceDirectives(): Map<ResolvedTypeReferenceDirective>;
2892+
/* @internal */ getResolvedTypeReferenceDirectives(): Map<ResolvedTypeReferenceDirective | undefined>;
28932893
isSourceFileFromExternalLibrary(file: SourceFile): boolean;
28942894
isSourceFileDefaultLibrary(file: SourceFile): boolean;
28952895

@@ -2997,7 +2997,7 @@ namespace ts {
29972997

29982998
getSourceFiles(): ReadonlyArray<SourceFile>;
29992999
getSourceFile(fileName: string): SourceFile | undefined;
3000-
getResolvedTypeReferenceDirectives(): ReadonlyMap<ResolvedTypeReferenceDirective>;
3000+
getResolvedTypeReferenceDirectives(): ReadonlyMap<ResolvedTypeReferenceDirective | undefined>;
30013001

30023002
readonly redirectTargetsMap: RedirectTargetsMap;
30033003
}
@@ -4979,7 +4979,7 @@ namespace ts {
49794979
/**
49804980
* This method is a companion for 'resolveModuleNames' and is used to resolve 'types' references to actual type declaration files
49814981
*/
4982-
resolveTypeReferenceDirectives?(typeReferenceDirectiveNames: string[], containingFile: string, redirectedReference?: ResolvedProjectReference): ResolvedTypeReferenceDirective[];
4982+
resolveTypeReferenceDirectives?(typeReferenceDirectiveNames: string[], containingFile: string, redirectedReference?: ResolvedProjectReference): (ResolvedTypeReferenceDirective | undefined)[];
49834983
getEnvironmentVariable?(name: string): string | undefined;
49844984
/* @internal */ onReleaseOldSourceFile?(oldSourceFile: SourceFile, oldOptions: CompilerOptions, hasSourceFileByPath: boolean): void;
49854985
/* @internal */ hasInvalidatedResolution?: HasInvalidatedResolution;

src/compiler/utilities.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -227,9 +227,9 @@ namespace ts {
227227
sourceFile.resolvedModules.set(moduleNameText, resolvedModule);
228228
}
229229

230-
export function setResolvedTypeReferenceDirective(sourceFile: SourceFile, typeReferenceDirectiveName: string, resolvedTypeReferenceDirective: ResolvedTypeReferenceDirective): void {
230+
export function setResolvedTypeReferenceDirective(sourceFile: SourceFile, typeReferenceDirectiveName: string, resolvedTypeReferenceDirective?: ResolvedTypeReferenceDirective): void {
231231
if (!sourceFile.resolvedTypeReferenceDirectiveNames) {
232-
sourceFile.resolvedTypeReferenceDirectiveNames = createMap<ResolvedTypeReferenceDirective>();
232+
sourceFile.resolvedTypeReferenceDirectiveNames = createMap<ResolvedTypeReferenceDirective | undefined>();
233233
}
234234

235235
sourceFile.resolvedTypeReferenceDirectiveNames.set(typeReferenceDirectiveName, resolvedTypeReferenceDirective);

tests/baselines/reference/api/tsserverlibrary.d.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2694,7 +2694,7 @@ declare namespace ts {
26942694
/**
26952695
* This method is a companion for 'resolveModuleNames' and is used to resolve 'types' references to actual type declaration files
26962696
*/
2697-
resolveTypeReferenceDirectives?(typeReferenceDirectiveNames: string[], containingFile: string, redirectedReference?: ResolvedProjectReference): ResolvedTypeReferenceDirective[];
2697+
resolveTypeReferenceDirectives?(typeReferenceDirectiveNames: string[], containingFile: string, redirectedReference?: ResolvedProjectReference): (ResolvedTypeReferenceDirective | undefined)[];
26982698
getEnvironmentVariable?(name: string): string | undefined;
26992699
createHash?(data: string): string;
27002700
}
@@ -4656,9 +4656,9 @@ declare namespace ts {
46564656
realpath?(path: string): string;
46574657
fileExists?(path: string): boolean;
46584658
getTypeRootsVersion?(): number;
4659-
resolveModuleNames?(moduleNames: string[], containingFile: string, reusedNames?: string[], redirectedReference?: ResolvedProjectReference): ResolvedModule[];
4659+
resolveModuleNames?(moduleNames: string[], containingFile: string, reusedNames?: string[], redirectedReference?: ResolvedProjectReference): (ResolvedModule | undefined)[];
46604660
getResolvedModuleWithFailedLookupLocationsFromCache?(modulename: string, containingFile: string): ResolvedModuleWithFailedLookupLocations | undefined;
4661-
resolveTypeReferenceDirectives?(typeDirectiveNames: string[], containingFile: string, redirectedReference?: ResolvedProjectReference): ResolvedTypeReferenceDirective[];
4661+
resolveTypeReferenceDirectives?(typeDirectiveNames: string[], containingFile: string, redirectedReference?: ResolvedProjectReference): (ResolvedTypeReferenceDirective | undefined)[];
46624662
getDirectories?(directoryName: string): string[];
46634663
/**
46644664
* Gets a set of custom transformers to use during emit.

tests/baselines/reference/api/typescript.d.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2694,7 +2694,7 @@ declare namespace ts {
26942694
/**
26952695
* This method is a companion for 'resolveModuleNames' and is used to resolve 'types' references to actual type declaration files
26962696
*/
2697-
resolveTypeReferenceDirectives?(typeReferenceDirectiveNames: string[], containingFile: string, redirectedReference?: ResolvedProjectReference): ResolvedTypeReferenceDirective[];
2697+
resolveTypeReferenceDirectives?(typeReferenceDirectiveNames: string[], containingFile: string, redirectedReference?: ResolvedProjectReference): (ResolvedTypeReferenceDirective | undefined)[];
26982698
getEnvironmentVariable?(name: string): string | undefined;
26992699
createHash?(data: string): string;
27002700
}
@@ -4656,9 +4656,9 @@ declare namespace ts {
46564656
realpath?(path: string): string;
46574657
fileExists?(path: string): boolean;
46584658
getTypeRootsVersion?(): number;
4659-
resolveModuleNames?(moduleNames: string[], containingFile: string, reusedNames?: string[], redirectedReference?: ResolvedProjectReference): ResolvedModule[];
4659+
resolveModuleNames?(moduleNames: string[], containingFile: string, reusedNames?: string[], redirectedReference?: ResolvedProjectReference): (ResolvedModule | undefined)[];
46604660
getResolvedModuleWithFailedLookupLocationsFromCache?(modulename: string, containingFile: string): ResolvedModuleWithFailedLookupLocations | undefined;
4661-
resolveTypeReferenceDirectives?(typeDirectiveNames: string[], containingFile: string, redirectedReference?: ResolvedProjectReference): ResolvedTypeReferenceDirective[];
4661+
resolveTypeReferenceDirectives?(typeDirectiveNames: string[], containingFile: string, redirectedReference?: ResolvedProjectReference): (ResolvedTypeReferenceDirective | undefined)[];
46624662
getDirectories?(directoryName: string): string[];
46634663
/**
46644664
* Gets a set of custom transformers to use during emit.

0 commit comments

Comments
 (0)