Skip to content

Commit 3d6dc58

Browse files
committed
Merge branch 'disallowNumericEnumMembers' of https://github.com/chrisbubernak/TypeScript into disallowNumericEnumMembers
2 parents 15c5c77 + 16f91b1 commit 3d6dc58

File tree

5 files changed

+27
-27
lines changed

5 files changed

+27
-27
lines changed

src/compiler/diagnosticInformationMap.generated.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,6 @@ module ts {
4848
Accessors_are_only_available_when_targeting_ECMAScript_5_and_higher: { code: 1056, category: DiagnosticCategory.Error, key: "Accessors are only available when targeting ECMAScript 5 and higher." },
4949
Enum_member_must_have_initializer: { code: 1061, category: DiagnosticCategory.Error, key: "Enum member must have initializer." },
5050
An_export_assignment_cannot_be_used_in_an_internal_module: { code: 1063, category: DiagnosticCategory.Error, key: "An export assignment cannot be used in an internal module." },
51-
An_enum_member_cannot_have_a_numeric_name: { code: 1065, category: DiagnosticCategory.Error, key: "An enum member cannot have a numeric name." },
5251
Ambient_enum_elements_can_only_have_integer_literal_initializers: { code: 1066, category: DiagnosticCategory.Error, key: "Ambient enum elements can only have integer literal initializers." },
5352
Unexpected_token_A_constructor_method_accessor_or_property_was_expected: { code: 1068, category: DiagnosticCategory.Error, key: "Unexpected token. A constructor, method, accessor, or property was expected." },
5453
A_declare_modifier_cannot_be_used_with_an_import_declaration: { code: 1079, category: DiagnosticCategory.Error, key: "A 'declare' modifier cannot be used with an import declaration." },
@@ -115,6 +114,7 @@ module ts {
115114
Cannot_compile_external_modules_unless_the_module_flag_is_provided: { code: 1148, category: DiagnosticCategory.Error, key: "Cannot compile external modules unless the '--module' flag is provided." },
116115
Filename_0_differs_from_already_included_filename_1_only_in_casing: { code: 1149, category: DiagnosticCategory.Error, key: "Filename '{0}' differs from already included filename '{1}' only in casing" },
117116
new_T_cannot_be_used_to_create_an_array_Use_new_Array_T_instead: { code: 1150, category: DiagnosticCategory.Error, key: "'new T[]' cannot be used to create an array. Use 'new Array<T>()' instead." },
117+
An_enum_member_cannot_have_a_numeric_name: { code: 1151, category: DiagnosticCategory.Error, key: "An enum member cannot have a numeric name." },
118118
Duplicate_identifier_0: { code: 2300, category: DiagnosticCategory.Error, key: "Duplicate identifier '{0}'." },
119119
Initializer_of_instance_member_variable_0_cannot_reference_identifier_1_declared_in_the_constructor: { code: 2301, category: DiagnosticCategory.Error, key: "Initializer of instance member variable '{0}' cannot reference identifier '{1}' declared in the constructor." },
120120
Static_members_cannot_reference_class_type_parameters: { code: 2302, category: DiagnosticCategory.Error, key: "Static members cannot reference class type parameters." },

src/compiler/diagnosticMessages.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -183,10 +183,6 @@
183183
"category": "Error",
184184
"code": 1063
185185
},
186-
"An enum member cannot have a numeric name.": {
187-
"category": "Error",
188-
"code": 1065
189-
},
190186
"Ambient enum elements can only have integer literal initializers.": {
191187
"category": "Error",
192188
"code": 1066
@@ -451,6 +447,10 @@
451447
"category": "Error",
452448
"code": 1150
453449
},
450+
"An enum member cannot have a numeric name.": {
451+
"category": "Error",
452+
"code": 1151
453+
},
454454

455455
"Duplicate identifier '{0}'.": {
456456
"category": "Error",
Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,25 +1,25 @@
1-
tests/cases/compiler/enumIdentifierLiterals.ts(2,5): error TS1065: An enum member cannot have a numeric name.
2-
tests/cases/compiler/enumIdentifierLiterals.ts(3,5): error TS1065: An enum member cannot have a numeric name.
3-
tests/cases/compiler/enumIdentifierLiterals.ts(4,5): error TS1065: An enum member cannot have a numeric name.
4-
tests/cases/compiler/enumIdentifierLiterals.ts(5,5): error TS1065: An enum member cannot have a numeric name.
5-
tests/cases/compiler/enumIdentifierLiterals.ts(6,5): error TS1065: An enum member cannot have a numeric name.
1+
tests/cases/compiler/enumIdentifierLiterals.ts(2,5): error TS1151: An enum member cannot have a numeric name.
2+
tests/cases/compiler/enumIdentifierLiterals.ts(3,5): error TS1151: An enum member cannot have a numeric name.
3+
tests/cases/compiler/enumIdentifierLiterals.ts(4,5): error TS1151: An enum member cannot have a numeric name.
4+
tests/cases/compiler/enumIdentifierLiterals.ts(5,5): error TS1151: An enum member cannot have a numeric name.
5+
tests/cases/compiler/enumIdentifierLiterals.ts(6,5): error TS1151: An enum member cannot have a numeric name.
66

77

88
==== tests/cases/compiler/enumIdentifierLiterals.ts (5 errors) ====
99
enum Nums {
1010
1.0,
1111
~~~
12-
!!! error TS1065: An enum member cannot have a numeric name.
12+
!!! error TS1151: An enum member cannot have a numeric name.
1313
11e-1,
1414
~~~~~
15-
!!! error TS1065: An enum member cannot have a numeric name.
15+
!!! error TS1151: An enum member cannot have a numeric name.
1616
0.12e1,
1717
~~~~~~
18-
!!! error TS1065: An enum member cannot have a numeric name.
18+
!!! error TS1151: An enum member cannot have a numeric name.
1919
"13e-1",
2020
~~~~~~~
21-
!!! error TS1065: An enum member cannot have a numeric name.
21+
!!! error TS1151: An enum member cannot have a numeric name.
2222
0xF00D
2323
~~~~~~
24-
!!! error TS1065: An enum member cannot have a numeric name.
24+
!!! error TS1151: An enum member cannot have a numeric name.
2525
}
Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
tests/cases/conformance/parser/ecmascript5/EnumDeclarations/parserEnum5.ts(2,12): error TS1005: ',' expected.
2-
tests/cases/conformance/parser/ecmascript5/EnumDeclarations/parserEnum5.ts(2,14): error TS1065: An enum member cannot have a numeric name.
2+
tests/cases/conformance/parser/ecmascript5/EnumDeclarations/parserEnum5.ts(2,14): error TS1151: An enum member cannot have a numeric name.
33
tests/cases/conformance/parser/ecmascript5/EnumDeclarations/parserEnum5.ts(3,15): error TS1005: ',' expected.
4-
tests/cases/conformance/parser/ecmascript5/EnumDeclarations/parserEnum5.ts(3,17): error TS1065: An enum member cannot have a numeric name.
4+
tests/cases/conformance/parser/ecmascript5/EnumDeclarations/parserEnum5.ts(3,17): error TS1151: An enum member cannot have a numeric name.
55
tests/cases/conformance/parser/ecmascript5/EnumDeclarations/parserEnum5.ts(3,24): error TS1005: ',' expected.
6-
tests/cases/conformance/parser/ecmascript5/EnumDeclarations/parserEnum5.ts(3,26): error TS1065: An enum member cannot have a numeric name.
6+
tests/cases/conformance/parser/ecmascript5/EnumDeclarations/parserEnum5.ts(3,26): error TS1151: An enum member cannot have a numeric name.
77

88

99
==== tests/cases/conformance/parser/ecmascript5/EnumDeclarations/parserEnum5.ts (6 errors) ====
@@ -12,13 +12,13 @@ tests/cases/conformance/parser/ecmascript5/EnumDeclarations/parserEnum5.ts(3,26)
1212
~
1313
!!! error TS1005: ',' expected.
1414
~
15-
!!! error TS1065: An enum member cannot have a numeric name.
15+
!!! error TS1151: An enum member cannot have a numeric name.
1616
enum E1 { a, b: 1, c, d: 2 = 3 }
1717
~
1818
!!! error TS1005: ',' expected.
1919
~
20-
!!! error TS1065: An enum member cannot have a numeric name.
20+
!!! error TS1151: An enum member cannot have a numeric name.
2121
~
2222
!!! error TS1005: ',' expected.
2323
~
24-
!!! error TS1065: An enum member cannot have a numeric name.
24+
!!! error TS1151: An enum member cannot have a numeric name.
Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,15 @@
1-
tests/cases/conformance/parser/ecmascript5/EnumDeclarations/parserEnum7.ts(2,3): error TS1065: An enum member cannot have a numeric name.
2-
tests/cases/conformance/parser/ecmascript5/EnumDeclarations/parserEnum7.ts(2,6): error TS1065: An enum member cannot have a numeric name.
3-
tests/cases/conformance/parser/ecmascript5/EnumDeclarations/parserEnum7.ts(2,9): error TS1065: An enum member cannot have a numeric name.
1+
tests/cases/conformance/parser/ecmascript5/EnumDeclarations/parserEnum7.ts(2,3): error TS1151: An enum member cannot have a numeric name.
2+
tests/cases/conformance/parser/ecmascript5/EnumDeclarations/parserEnum7.ts(2,6): error TS1151: An enum member cannot have a numeric name.
3+
tests/cases/conformance/parser/ecmascript5/EnumDeclarations/parserEnum7.ts(2,9): error TS1151: An enum member cannot have a numeric name.
44

55

66
==== tests/cases/conformance/parser/ecmascript5/EnumDeclarations/parserEnum7.ts (3 errors) ====
77
enum E {
88
1, 2, 3
99
~
10-
!!! error TS1065: An enum member cannot have a numeric name.
10+
!!! error TS1151: An enum member cannot have a numeric name.
1111
~
12-
!!! error TS1065: An enum member cannot have a numeric name.
12+
!!! error TS1151: An enum member cannot have a numeric name.
1313
~
14-
!!! error TS1065: An enum member cannot have a numeric name.
14+
!!! error TS1151: An enum member cannot have a numeric name.
1515
}

0 commit comments

Comments
 (0)