fix lookup regression again and again

Author: Kingwl

src/compiler/checker.ts

@@ -1213,7 +1213,9 @@ namespace ts {
                             }
                             if (meaning & SymbolFlags.Value && result.flags & SymbolFlags.Variable) {
                                 // expression inside parameter will lookup as normal variable scope when targeting es2015+
-                                if (compilerOptions.target && compilerOptions.target >= ScriptTarget.ES2015 && isParameter(lastLocation) && !isParameterPropertyDeclaration(lastLocation) && result.valueDeclaration.pos > lastLocation.end) {
+                                const functionLocation = <FunctionLikeDeclaration>location;
+                                if (compilerOptions.target && compilerOptions.target >= ScriptTarget.ES2015 && isParameter(lastLocation) &&
+                                        functionLocation.body && result.valueDeclaration.pos >= functionLocation.body.pos && result.valueDeclaration.end <= functionLocation.body.end) {
                                     useResult = false;
                                 }
                                 else if (result.flags & SymbolFlags.FunctionScopedVariable) {

tests/baselines/reference/parameterInitializersForwardReferencing1_es6.errors.txt

@@ -1,8 +1,9 @@
+tests/cases/conformance/functions/parameterInitializersForwardReferencing1_es6.ts(13,20): error TS2373: Initializer of parameter 'bar' cannot reference identifier 'foo' declared after it.
 tests/cases/conformance/functions/parameterInitializersForwardReferencing1_es6.ts(21,18): error TS2372: Parameter 'a' cannot be referenced in its initializer.
 tests/cases/conformance/functions/parameterInitializersForwardReferencing1_es6.ts(25,22): error TS2372: Parameter 'async' cannot be referenced in its initializer.
 
 
-==== tests/cases/conformance/functions/parameterInitializersForwardReferencing1_es6.ts (2 errors) ====
+==== tests/cases/conformance/functions/parameterInitializersForwardReferencing1_es6.ts (3 errors) ====
     let foo: string = "";
 
     function f1 (bar = foo) { // unexpected compiler error; works at runtime
@@ -16,6 +17,8 @@ tests/cases/conformance/functions/parameterInitializersForwardReferencing1_es6.t
     }
 
     function f3 (bar = foo, foo = 2) { // correct compiler error, error at runtime
+                       ~~~
+!!! error TS2373: Initializer of parameter 'bar' cannot reference identifier 'foo' declared after it.
         return bar;
     }
 

tests/baselines/reference/parameterInitializersForwardReferencing1_es6.symbols

@@ -31,7 +31,7 @@ function f2 (bar = (baz = foo) => baz) { // unexpected compiler error; works at
 function f3 (bar = foo, foo = 2) { // correct compiler error, error at runtime
 >f3 : Symbol(f3, Decl(parameterInitializersForwardReferencing1_es6.ts, 10, 1))
 >bar : Symbol(bar, Decl(parameterInitializersForwardReferencing1_es6.ts, 12, 13))
->foo : Symbol(foo, Decl(parameterInitializersForwardReferencing1_es6.ts, 0, 3))
+>foo : Symbol(foo, Decl(parameterInitializersForwardReferencing1_es6.ts, 12, 23))
 >foo : Symbol(foo, Decl(parameterInitializersForwardReferencing1_es6.ts, 12, 23))
 
     return bar;

tests/baselines/reference/parameterInitializersForwardReferencing1_es6.types

@@ -34,14 +34,14 @@ function f2 (bar = (baz = foo) => baz) { // unexpected compiler error; works at
 }
 
 function f3 (bar = foo, foo = 2) { // correct compiler error, error at runtime
->f3 : (bar?: string, foo?: number) => string
->bar : string
->foo : string
+>f3 : (bar?: number, foo?: number) => number
+>bar : number
+>foo : number
 >foo : number
 >2 : 2
 
     return bar;
->bar : string
+>bar : number
 }
 
 function f4 (foo, bar = foo) {