Skip to content

Commit 509d243

Browse files
author
Ben Lichtman
committed
Add test
1 parent 49f7f25 commit 509d243

File tree

4 files changed

+34
-3
lines changed

4 files changed

+34
-3
lines changed

src/harness/fourslashImpl.ts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -843,8 +843,8 @@ namespace FourSlash {
843843
}
844844

845845
private verifyCompletionEntry(actual: ts.CompletionEntry, expected: FourSlashInterface.ExpectedCompletionEntry) {
846-
const { insertText, replacementSpan, hasAction, isRecommended, kind, kindModifiers, text, documentation, tags, source, sourceDisplay, sortText } = typeof expected === "string"
847-
? { insertText: undefined, replacementSpan: undefined, hasAction: undefined, isRecommended: undefined, kind: undefined, kindModifiers: undefined, text: undefined, documentation: undefined, tags: undefined, source: undefined, sourceDisplay: undefined, sortText: undefined }
846+
const { insertText, replacementSpan, hasAction, isRecommended, isFromUncheckedFile, kind, kindModifiers, text, documentation, tags, source, sourceDisplay, sortText } = typeof expected === "string"
847+
? { insertText: undefined, replacementSpan: undefined, hasAction: undefined, isRecommended: undefined, isFromUncheckedFile: undefined, kind: undefined, kindModifiers: undefined, text: undefined, documentation: undefined, tags: undefined, source: undefined, sourceDisplay: undefined, sortText: undefined }
848848
: expected;
849849

850850
if (actual.insertText !== insertText) {
@@ -868,7 +868,8 @@ namespace FourSlash {
868868
}
869869

870870
assert.equal(actual.hasAction, hasAction, `Expected 'hasAction' value '${actual.hasAction}' to equal '${hasAction}'`);
871-
assert.equal(actual.isRecommended, isRecommended, `Expected 'isRecommended' value '${actual.source}' to equal '${isRecommended}'`);
871+
assert.equal(actual.isRecommended, isRecommended, `Expected 'isRecommended' value '${actual.isRecommended}' to equal '${isRecommended}'`);
872+
assert.equal(actual.isFromUncheckedFile, isFromUncheckedFile, `Expected 'isFromUncheckedFile' value '${actual.isFromUncheckedFile}' to equal '${isFromUncheckedFile}'`);
872873
assert.equal(actual.source, source, `Expected 'source' value '${actual.source}' to equal '${source}'`);
873874
assert.equal(actual.sortText, sortText || ts.Completions.SortText.LocationPriority, this.messageAtLastKnownMarker(`Actual entry: ${JSON.stringify(actual)}`));
874875

src/harness/fourslashInterfaceImpl.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1472,6 +1472,7 @@ namespace FourSlashInterface {
14721472
readonly replacementSpan?: FourSlash.Range;
14731473
readonly hasAction?: boolean; // If not specified, will assert that this is false.
14741474
readonly isRecommended?: boolean; // If not specified, will assert that this is false.
1475+
readonly isFromUncheckedFile?: boolean; // If not specified, will assert that this is false.
14751476
readonly kind?: string; // If not specified, won't assert about this
14761477
readonly kindModifiers?: string; // Must be paired with 'kind'
14771478
readonly text?: string;
Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,28 @@
1+
/// <reference path="fourslash.ts" />
2+
3+
// @allowJs: true
4+
// @checkJs: false
5+
// @Filename: index.js
6+
////function hello() {
7+
////
8+
////}
9+
////
10+
////const goodbye = 5;
11+
////
12+
////console./*0*/
13+
14+
verify.completions({
15+
marker: "0",
16+
includes: [
17+
{
18+
name: "hello",
19+
sortText: completion.SortText.JavascriptIdentifiers,
20+
isFromUncheckedFile: true
21+
},
22+
{
23+
name: "goodbye",
24+
sortText: completion.SortText.JavascriptIdentifiers,
25+
isFromUncheckedFile: true
26+
}
27+
]
28+
});

tests/cases/fourslash/fourslash.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -609,6 +609,7 @@ declare namespace FourSlashInterface {
609609
readonly replacementSpan?: Range;
610610
readonly hasAction?: boolean;
611611
readonly isRecommended?: boolean;
612+
readonly isFromUncheckedFile?: boolean;
612613
readonly kind?: string;
613614
readonly kindModifiers?: string;
614615
readonly sortText?: completion.SortText;

0 commit comments

Comments
 (0)