PR feedback

Author: riknoll

src/harness/fourslash.ts

@@ -3017,7 +3017,7 @@ namespace FourSlashInterface {
         public typeDefinitionCountIs(expectedCount: number) {
             this.state.verifyTypeDefinitionsCount(this.negative, expectedCount);
         }
-	
+
         public implementationCountIs(expectedCount: number) {
             this.state.verifyImplementationsCount(this.negative, expectedCount);
         }

src/services/services.ts

@@ -7,6 +7,7 @@
 //// }
 ////
 //// var bar: Foo = { [|hello: helloImpl|] };
+//// var baz: Foo = { [|"hello": helloImpl|] };
 ////
 //// function helloImpl () {}
 ////

tests/cases/fourslash/goToImplementationInterfaceMethod_00.ts

@@ -15,7 +15,7 @@
 //// }
 ////
 //// class SubBar extends Bar {
-////    hello() {}
+////    [|hello() {}|]
 //// }
 
 

tests/cases/fourslash/goToImplementationInterfaceMethod_08.ts

@@ -15,6 +15,7 @@
 ////
 ////     whatever() {
 ////         super.he/*function_call*/llo();
+////         super["hel/*element_access*/lo"]();
 ////     }
 //// }
 ////
@@ -28,3 +29,6 @@
 
 goTo.marker("function_call");
 verify.allRangesAppearInImplementationList();
+
+goTo.marker("element_access");
+verify.allRangesAppearInImplementationList();

tests/cases/fourslash/goToImplementationInterfaceMethod_09.ts

@@ -1,12 +1,29 @@
 /// <reference path='fourslash.ts'/>
 
-// Should handle calls on namespaces
+// Should not return results on namespaces and modules
 
-//// [|namespace Foo {
-////     export function hello() {}
-//// }|]
-//// 
-//// let x = Fo/*reference*/o;
+//// namespace Foo {
+////     export function hello() {}
+//// }
+////
+//// namespace Foo.Bar {
+////     export function okay() {}
+//// }
+////
+//// namespace Baz {
+////     export function sure() {}
+//// }
+////
+//// namespace Baz.Bar {
+////     export function alright() {}
+//// }
+////
+//// let w = Fo/*reference0*/o;
+//// let x = Foo.B/*reference1*/ar;
+//// let w = Ba/*reference2*/z;
+//// let x = Baz.B/*reference3*/ar;
 
-goTo.marker("reference");
-verify.allRangesAppearInImplementationList();
+for (let i = 0; i < 4; i++) {
+    goTo.marker("reference" + i);
+    verify.implementationCountIs(0);
+}

tests/cases/fourslash/goToImplementationNamespace_00.ts

@@ -1,12 +1,12 @@
 /// <reference path='fourslash.ts'/>
 
-// Should handle calls on modules
+// Should handle property access expressions on namespaces
 
-//// [|module Foo {
-////     export function hello() {}
-//// }|]
+//// namespace Foo {
+////     [|export function hello() {}|]
+//// }
 //// 
-//// let x = Fo/*reference*/o;
+//// Foo.hell/*reference*/o();
 
 goTo.marker("reference");
 verify.allRangesAppearInImplementationList();

tests/cases/fourslash/goToImplementationNamespace_01.ts

@@ -2,7 +2,7 @@
 
 // Should handle property access expressions on namespaces
 
-//// namespace Foo {
+//// module Foo {
 ////     [|export function hello() {}|]
 //// }
 //// 

tests/cases/fourslash/goToImplementationNamespace_02.ts

@@ -1,12 +1,28 @@
 /// <reference path='fourslash.ts'/>
 
-// Should handle property access expressions on namespaces
+// Should handle types that are members of a namespace in type references and heritage clauses
 
-//// module Foo {
-////     [|export function hello() {}|]
-//// }
-//// 
-//// Foo.hell/*reference*/o();
+//// namespace Foo {
+////     export interface Bar {
+////         hello(): void;
+////     }
+////
+////     [|class BarImpl implements Bar {
+////         hello() {}
+////     }|]
+//// }
+////
+//// [|class Baz implements Foo.Bar {
+////     hello() {}
+//// }|]
+////
+//// var someVar1 : Foo.Bar = [|{ hello: () => {/**1*/} }|];
+////
+//// var someVar2 = <Foo.Bar> [|{ hello: () => {/**2*/} }|];
+////
+//// function whatever(x: Foo.Ba/*reference*/r) {
+////
+//// }
 
 goTo.marker("reference");
-verify.allRangesAppearInImplementationList();
+verify.allRangesAppearInImplementationList();

tests/cases/fourslash/goToImplementationNamespace_03.ts

@@ -1,26 +1,28 @@
 /// <reference path='fourslash.ts'/>
 
-// Should handle sub-namespaces
+// Should handle types that are members of a module in type references and heritage clauses
 
-//// /*parentNamespace*/namespace Foo {
-////     export function hello() {}
-//// }
+//// module Foo {
+////     export interface Bar {
+////         hello(): void;
+////     }
 ////
-//// /*parentNamespace2*/namespace Foo./*childNamespace*/Bar {
-////    export function okay() {}
+////     [|class BarImpl implements Bar {
+////         hello() {}
+////     }|]
 //// }
 ////
-//// Fo/*parentReference*/o.hello();
-//// Foo.Ba/*childReference*/r.okay();
-
-goTo.marker("parentReference");
-goTo.implementation(0);
-verify.caretAtMarker("parentNamespace");
-
-goTo.marker("parentReference");
-goTo.implementation(1);
-verify.caretAtMarker("parentNamespace2");
+//// [|class Baz implements Foo.Bar {
+////     hello() {}
+//// }|]
+////
+//// var someVar1 : Foo.Bar = [|{ hello: () => {/**1*/} }|];
+////
+//// var someVar2 = <Foo.Bar> [|{ hello: () => {/**2*/} }|];
+////
+//// function whatever(x: Foo.Ba/*reference*/r) {
+////
+//// }
 
-goTo.marker("childReference");
-goTo.implementation();
-verify.caretAtMarker("childNamespace")
+goTo.marker("reference");
+verify.allRangesAppearInImplementationList();